From: maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
To: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/4] spi: spi-fsl-dspi: Fix continuous selection format
Date: Fri, 18 Nov 2016 13:29:27 +0530 [thread overview]
Message-ID: <20161118075927.GA1572@Sanchayan-Arch.localdomain> (raw)
In-Reply-To: <c1c4a3f3eac6d4e7378971431bd5f595-XLVq0VzYD2Y@public.gmane.org>
Hello Stefan,
On 16-11-17 17:07:24, Stefan Agner wrote:
> On 2016-11-17 04:16, Sanchayan Maity wrote:
> > Current DMA implementation was not handling the continuous selection
> > format viz. SPI chip select would be deasserted even between sequential
> > serial transfers. Use the cs_change variable and correctly set or
> > reset the CONT bit accordingly for case where peripherals require
> > the chip select to be asserted between sequential transfers.
> >
> > Signed-off-by: Sanchayan Maity <maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> > drivers/spi/spi-fsl-dspi.c | 13 ++++++++++---
> > 1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
> > index aee8c88..164e2e1 100644
> > --- a/drivers/spi/spi-fsl-dspi.c
> > +++ b/drivers/spi/spi-fsl-dspi.c
> > @@ -258,9 +258,16 @@ static int dspi_next_xfer_dma_submit(struct fsl_dspi *dspi)
> > }
> >
> > val = tx_word ? *(u16 *) dspi->tx : *(u8 *) dspi->tx;
> > - dspi->dma->tx_dma_buf[i] = SPI_PUSHR_TXDATA(val) |
> > - SPI_PUSHR_PCS(dspi->cs) |
> > - SPI_PUSHR_CTAS(0);
> > + if (dspi->cs_change) {
> > + dspi->dma->tx_dma_buf[i] = SPI_PUSHR_TXDATA(val) |
> > + SPI_PUSHR_PCS(dspi->cs) |
> > + SPI_PUSHR_CTAS(0);
> > + } else {
> > + dspi->dma->tx_dma_buf[i] = SPI_PUSHR_TXDATA(val) |
> > + SPI_PUSHR_PCS(dspi->cs) |
> > + SPI_PUSHR_CTAS(0) |
> > + SPI_PUSHR_CONT;
> > + }
>
> How about:
>
>
> dspi->dma->tx_dma_buf[i] = SPI_PUSHR_TXDATA(val) |
> SPI_PUSHR_PCS(dspi->cs) |
> SPI_PUSHR_CTAS(0);
>
> + if (dspi->cs_change)
> + dspi->dma->tx_dma_buf[i] |= SPI_PUSHR_CONT;
>
>
> Avoids code duplication...
Agreed. It's much better. Should be !dspi->cs_change though.
Will include it in next iteration.
Thanks & Regards,
Sanchayan.
>
> --
> Stefan
>
>
>
> > dspi->tx += tx_word + 1;
> >
> > dma->tx_desc = dmaengine_prep_slave_single(dma->chan_tx,
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-11-18 7:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 12:19 [PATCH v3] spi: spi-fsl-dspi: Add DMA support for Vybrid Sanchayan Maity
[not found] ` <836dd6a84fa149cafdbb0b53e792d305febf6207.1478778329.git.maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-11 12:20 ` Mark Brown
2016-11-17 12:16 ` [PATCH 0/4] Fixes for Vybrid SPI DMA implementation Sanchayan Maity
2016-11-17 12:16 ` [PATCH 1/4] spi: spi-fsl-dspi: Fix SPI transfer issue when using multiple SPI_IOC_MESSAGE Sanchayan Maity
[not found] ` <bbdbc8df434dd2af74eb351b799a2812a1c1967e.1479384571.git.maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-18 0:52 ` Stefan Agner
2016-11-21 19:20 ` Applied "spi: spi-fsl-dspi: Fix SPI transfer issue when using multiple SPI_IOC_MESSAGE" to the spi tree Mark Brown
2016-11-17 12:16 ` [PATCH 2/4] spi: spi-fsl-dspi: Fix incorrect DMA setup Sanchayan Maity
[not found] ` <d83f4896d77f577ca92fd70534f6198bb3288d8a.1479384571.git.maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-18 1:03 ` Stefan Agner
[not found] ` <bc8d9b808b99d3b217361df6fa8853ea-XLVq0VzYD2Y@public.gmane.org>
2016-11-18 8:04 ` maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20161118080403.GB1572-2b/appYahYDPUjlVagVGR1Kr0EmMEXJSn9A1Ff6Mc9Q@public.gmane.org>
2016-11-18 23:39 ` Stefan Agner
2016-11-17 12:16 ` [PATCH 3/4] spi: spi-fsl-dspi: Fix continuous selection format Sanchayan Maity
[not found] ` <c1e51fc92dbcc9c31dcdcdfab3eed40d7745308a.1479384571.git.maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-18 1:07 ` Stefan Agner
[not found] ` <c1c4a3f3eac6d4e7378971431bd5f595-XLVq0VzYD2Y@public.gmane.org>
2016-11-18 7:59 ` maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w [this message]
2016-11-17 12:16 ` [PATCH 4/4] spi: spi-fsl-dspi: Minor code cleanup and error path fixes Sanchayan Maity
2016-11-11 13:05 ` Applied "spi: spi-fsl-dspi: Add DMA support for Vybrid" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118075927.GA1572@Sanchayan-Arch.localdomain \
--to=maitysanchayan-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).