linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: David Howells <dhowells@redhat.com>,
	arnd@arndb.de, linux-mips@linux-mips.org,
	linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org,
	linux-doc@vger.kernel.org, alsa-devel@alsa-project.org,
	dri-devel@lists.freedesktop.org, linux-mtd@lists.infradead.org,
	sparclinux@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-s390@vger.kernel.org, linux-am33-list@redhat.com,
	linux-c6x-dev@linux-c6x.org, linux-rdma@vger.kernel.org,
	linux-hexagon@vger.kernel.org, linux-sh@vger.kernel.org,
	coreteam@netfilter.org, fcoe-devel@open-fcoe.org,
	xen-devel@lists.xenproject.org,
	linux-snps-arc@lists.infradead.org, linux-media@vger.kernel.org,
	uclinux-h8-devel@lists.sourceforge.jp,
	linux-xtensa@linux-xtensa.org, linux-kbuild@vger.kernel.org,
	adi-buildroot-devel@lists.sourceforge.net, linux-raid@vg
Subject: Re: [PATCH v3 1/8] arm: put types.h in uapi
Date: Fri, 13 Jan 2017 16:19:52 +0000	[thread overview]
Message-ID: <20170113161951.GT14217@n2100.armlinux.org.uk> (raw)
In-Reply-To: <4633e475-47f2-5627-81a9-a1747dfddbc0@6wind.com>

On Fri, Jan 13, 2017 at 05:01:01PM +0100, Nicolas Dichtel wrote:
> Please, do not remove the email subject when you reply. I restore it to
> ease the thread follow-up.

I mentioned it to David, and he says it's because the long list of
recipients is breaking his mailer.  I've already posed the question
about whether that's exploitable!

> Le 13/01/2017 à 16:36, David Howells a écrit :
> > Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> > 
> >> This header file is exported, thus move it to uapi.
> > 
> > Exported how?
> 
> It is listed in include/uapi/asm-generic/Kbuild.asm, which is included by
> arch/arm/include/uapi/asm/Kbuild.

We really should not be installing non-uapi header files to userland
under _any_ circumstance - this to me sounds like a bug in kbuild.

The assumption is that headers outside of uapi directories are not
part of the user visible API, and so can be freely modified - which
in the presence of this bug is untrue.

However, as it's happening, and this header has been there since 2013
(commit 09096f6a0ee2 - "ARM: 7822/1: add workaround for ambiguous C99
stdint.h types") it's now well and truely part of the user API whether
we intended it to be or not, so your patch looks to me like the correct
thing to do.

I think it needs further evaluation to make sure kbuild isn't going to
do something else silly, like subsitute include/asm-generic/types.h for
the now missing arch/arm/include/asm/types.h

I wonder how many more headers are unintentionally exported.

... what a mess. :(

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2017-01-13 16:19 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161203.192346.1198940437155108508.davem@davemloft.net>
2017-01-03 14:35 ` [PATCH] uapi: use wildcards to list files Nicolas Dichtel
2017-01-03 15:56   ` David Miller
2017-01-03 21:37   ` Arnd Bergmann
2017-01-04  9:03     ` Nicolas Dichtel
2017-01-06  9:43       ` [PATCH v2 0/7] uapi: export all headers under uapi directories Nicolas Dichtel
2017-01-06  9:43         ` [PATCH v2 1/7] arm: put types.h in uapi Nicolas Dichtel
2017-01-09 11:33           ` Arnd Bergmann
2017-01-09 12:00             ` Russell King - ARM Linux
2017-01-06  9:43         ` [PATCH v2 2/7] h8300: put bitsperlong.h " Nicolas Dichtel
2017-01-06  9:43         ` [PATCH v2 3/7] nios2: put setup.h " Nicolas Dichtel
2017-01-09 11:33           ` Arnd Bergmann
2017-01-06  9:43         ` [PATCH v2 4/7] x86: put msr-index.h " Nicolas Dichtel
2017-01-06 12:14           ` Borislav Petkov
2017-01-06 20:50           ` Andy Shevchenko
2017-01-06  9:43         ` [PATCH v2 5/7] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-01-06  9:43         ` [PATCH v2 6/7] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-01-06  9:43         ` [PATCH v2 7/7] uapi: export all headers under uapi directories Nicolas Dichtel
2017-01-09 10:01           ` Daniel Vetter
     [not found]           ` <1483695839-18660-8-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2017-01-09 12:01             ` Russell King - ARM Linux
2017-01-09 12:56           ` Christoph Hellwig
2017-01-12 15:52             ` Nicolas Dichtel
2017-01-12 16:28               ` Jan Engelhardt
2017-01-12 16:32                 ` Nicolas Dichtel
2017-01-13  1:04                   ` Jeff Epler
2017-01-11 18:14           ` [Linux-c6x-dev] " Mark Salter
2017-01-09 11:33         ` [PATCH v2 0/7] " Arnd Bergmann
2017-01-11 12:42           ` Jesper Nilsson
2017-01-13 10:46           ` [PATCH v3 0/8] " Nicolas Dichtel
2017-01-13 10:46             ` [PATCH v3 1/8] arm: put types.h in uapi Nicolas Dichtel
2017-01-13 17:06               ` Russell King - ARM Linux
2017-01-13 10:46             ` [PATCH v3 2/8] h8300: put bitsperlong.h " Nicolas Dichtel
2017-01-13 10:46             ` [PATCH v3 3/8] nios2: put setup.h " Nicolas Dichtel
2017-01-13 10:55               ` Tobias Klauser
2017-01-13 10:46             ` [PATCH v3 4/8] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-01-13 10:46             ` [PATCH v3 5/8] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-01-13 10:46             ` [PATCH v3 6/8] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-01-13 10:46             ` [PATCH v3 7/8] uapi: export all headers under uapi directories Nicolas Dichtel
2017-01-13 10:46             ` [PATCH v3 8/8] uapi: export all arch specifics directories Nicolas Dichtel
2017-01-13 15:36             ` (unknown) David Howells
2017-01-13 16:01               ` [PATCH v3 1/8] arm: put types.h in uapi Nicolas Dichtel
2017-01-13 16:19                 ` Russell King - ARM Linux [this message]
2017-01-13 15:43             ` (no subject) David Howells
2017-01-13 16:08               ` [PATCH v3 4/8] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-01-13 16:38                 ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170113161951.GT14217@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=adi-buildroot-devel@lists.sourceforge.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=coreteam@netfilter.org \
    --cc=dhowells@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fcoe-devel@open-fcoe.org \
    --cc=linux-am33-list@redhat.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-c6x-dev@linux-c6x.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hexagon@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-raid@vg \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=uclinux-h8-devel@lists.sourceforge.jp \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH v3 1/8] arm: put types.h in uapi' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).