On Tue, Jan 17, 2017 at 07:03:28AM +0000, Pandy Gao wrote: > > > The patch recovers the pinctrl setting when exit VLLS mode. > > Why is this a change here and not in the pinctrl driver? It sounds like > > it's the pinctrl driver that's forgetting the settings and should be > > restoring them on resume but perhaps I'm missing something here. > If the pinctrl driver restores the setting on resume, then all device node > should be scanned, which is irregular. What would restoring the configuration have to do with scanning the device tree? The changelog says this is just reapplying the same settings we started out with so it's just a case of restoring the state of the device after a runtime resume which is a perfectly normal thing for a driver to do.