Re: [PATCH v2 1/2] spi: add check_finished() callback

[Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]

On Sat, Feb 04, 2017 at 02:45:57PM +0100, Hauke Mehrtens wrote:
> ping Mark,
> 
> What should I do in the driver now?

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings just adds to the mail volume (if they are
seen at all) and if something has gone wrong you'll have to resend the
patches anyway.

> > I can add the transfer status in some other way, no problem, but how do
> > I tell Linux that the transfer finished when it really finished. I also
> > tried to just ignore the last word, but when the controller is
> > configured for the next transfer, the old one gets corrupted.

As I've now said three or four times this sounds like you should use a
workqueue or something similar to do whatever is needed wait for the
hardware to finish whatever it's doing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]