From: Oleksij Rempel <ore-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Trent Piepho <tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [PATCH v2 3/4] spi: imx: Don't require platform data chipselect array
Date: Fri, 27 Oct 2017 13:14:04 +0200 [thread overview]
Message-ID: <20171027111404.nibuwyakef6bvjvn@pengutronix.de> (raw)
In-Reply-To: <20171027010841.28624-4-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
Hi Trent,
On Thu, Oct 26, 2017 at 06:08:40PM -0700, Trent Piepho wrote:
> If the array is not present, assume all chip selects are native. This
> is the standard behavior for SPI masters configured via the device
> tree and the behavior of this driver as well when it is configured via
> device tree.
>
> This reduces platform data vs DT differences and allows most of the
> platform data based boards to remove their chip select arrays.
>
> CC: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> CC: Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> CC: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> CC: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Signed-off-by: Trent Piepho <tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/spi/spi-imx.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index fea46cbf458a..535378ebab18 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -1362,8 +1362,7 @@ static int spi_imx_probe(struct platform_device *pdev)
> spi_imx->devtype_data = of_id ? of_id->data :
> (struct spi_imx_devtype_data *)pdev->id_entry->driver_data;
>
> - if (mxc_platform_info) {
> - master->num_chipselect = mxc_platform_info->num_chipselect;
> + if (mxc_platform_info && master->num_chipselect) {
after spi_alloc_master(), master->num_chipselect should be always 1.
This check makes no sense for me. Probably you wonted to use
mxc_platform_info->num_chipselect instead?
> master->cs_gpios = devm_kzalloc(&master->dev,
> sizeof(int) * master->num_chipselect, GFP_KERNEL);
> if (!master->cs_gpios)
> @@ -1371,7 +1370,7 @@ static int spi_imx_probe(struct platform_device *pdev)
>
> for (i = 0; i < master->num_chipselect; i++)
> master->cs_gpios[i] = mxc_platform_info->chipselect[i];
> - }
> + }
>
> spi_imx->bitbang.chipselect = spi_imx_chipselect;
> spi_imx->bitbang.setup_transfer = spi_imx_setupxfer;
> --
> 2.14.3
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-27 11:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 1:08 [PATCH v2 0/4] Fix for imx-spi CS GPIOs Trent Piepho
[not found] ` <20171027010841.28624-1-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-27 1:08 ` [PATCH v2 1/4] spi: imx: GPIO based chip selects should not be required Trent Piepho
[not found] ` <20171027010841.28624-2-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-31 11:19 ` Mark Brown
[not found] ` <20171031111919.gocl7wwrhkwnxrya-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-10-31 16:57 ` Trent Piepho
[not found] ` <1509469061.5473.16.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-02 15:14 ` Mark Brown
[not found] ` <20171102151439.6dpfud7a5vtc27dy-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-11-03 17:53 ` Trent Piepho
[not found] ` <1509731639.5473.60.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-03 18:37 ` Mark Brown
[not found] ` <20171103183700.spnqbagr4q7fth4k-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-11-03 19:18 ` Trent Piepho
[not found] ` <1509736735.5473.87.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-03 19:36 ` Mark Brown
[not found] ` <20171103193649.jcoiy3raefikko2h-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-11-03 20:09 ` Trent Piepho
[not found] ` <1509739759.5473.93.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-11-03 20:11 ` Mark Brown
2017-11-06 7:32 ` Sascha Hauer
[not found] ` <20171106073246.efcz7r2vnymz3me7-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-11-06 19:20 ` Trent Piepho
2017-10-27 1:08 ` [PATCH v2 2/4] spi: imx: Fix failure path leak on GPIO request error Trent Piepho
2017-10-27 1:08 ` [PATCH v2 3/4] spi: imx: Don't require platform data chipselect array Trent Piepho
[not found] ` <20171027010841.28624-4-tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2017-10-27 11:14 ` Oleksij Rempel [this message]
2017-10-27 1:08 ` [PATCH v2 4/4] ARM: imx: Update spi_imx platform data to reflect current state Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027111404.nibuwyakef6bvjvn@pengutronix.de \
--to=ore-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tpiepho-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).