From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH RFC 00/18] mtd: spi-nor: Proposal for 8-8-8 mode support Date: Fri, 19 Oct 2018 14:59:20 +0200 Message-ID: <20181019145920.43f9d5ec@bbrezillon> References: <20181012084825.23697-1-boris.brezillon@bootlin.com> <20181019122527.GJ5895@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Yogesh Gaur , Vignesh R , Julien Su , Richard Weinberger , linux-spi@vger.kernel.org, Marek Vasut , linux-mtd@lists.infradead.org, Mason Yang , Cyrille Pitchen , Brian Norris , David Woodhouse , zhengxunli@mxic.com.tw To: Mark Brown Return-path: In-Reply-To: <20181019122527.GJ5895@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org Hi Mark, On Fri, 19 Oct 2018 13:25:27 +0100 Mark Brown wrote: > On Fri, Oct 12, 2018 at 10:48:07AM +0200, Boris Brezillon wrote: > > > First question that might come to mind is why should we support such > > stateful modes? If you think about it, the gain of transmitting the > > opcode on 8 IO lines is rather small compared to the pain it is to > > teach the SPI NOR framework how to deal with that. The problem is, > > some SPI NOR manufacturers (Macronix for instance) only implement 1-1-1 > > and 8-8-8 (or 8D-8D-8D), and they want to be able to use their NORs in > > 8-8-8 mode when the controller supports it. > > The SPI framework changes definitely look OK to me, if everyone agrees > that this is a good way to go from a MTD point of view I'm happy to > apply them. I have no strong opinion on the MTD bits of the series. Actually, Yogesh posted similar patches before me, so maybe you can look at this series [1]. The spi/spi-mem side of things is rather uncontroversial. Feel free to apply them if you think they're good enough to go in. Thanks for your review. Boris [1]http://patchwork.ozlabs.org/project/linux-mtd/list/?series=70822 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/