linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/9] spi: Use dma_request_chan() directly for channel request
@ 2019-11-13  9:42 Peter Ujfalusi
  2019-11-13  9:42 ` [PATCH 1/9] spi: at91-usart: " Peter Ujfalusi
                   ` (9 more replies)
  0 siblings, 10 replies; 29+ messages in thread
From: Peter Ujfalusi @ 2019-11-13  9:42 UTC (permalink / raw)
  To: broonie, radu_nicolae.pirea, shawnguo, s.hauer, linus.walleij,
	agross, bjorn.andersson, andi, ldewangan, thierry.reding,
	jonathanh
  Cc: alexandre.belloni, linux-arm-msm, linux-kernel, krzk, linux-spi,
	vkoul, kgene, linux-tegra, linux-arm-kernel

Hi,

I'm going through the tree to remove dma_request_slave_channel_reason() as it
is just:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Regards,
Peter
---
Peter Ujfalusi (9):
  spi: at91-usart: Use dma_request_chan() directly for channel request
  spi: atmel: Use dma_request_chan() directly for channel request
  spi: fsl-lpspi: Use dma_request_chan() directly for channel request
  spi: imx: Use dma_request_chan() directly for channel request
  spi: pl022: Use dma_request_chan() directly for channel request
  spi: qup: Use dma_request_chan() directly for channel request
  spi: s3c64xx: Use dma_request_chan() directly for channel request
  spi: tegra114: Use dma_request_chan() directly for channel request
  spi: tegra20-slink: Use dma_request_chan() directly for channel
    request

 drivers/spi/spi-at91-usart.c    | 4 ++--
 drivers/spi/spi-atmel.c         | 2 +-
 drivers/spi/spi-fsl-lpspi.c     | 4 ++--
 drivers/spi/spi-imx.c           | 4 ++--
 drivers/spi/spi-pl022.c         | 4 ++--
 drivers/spi/spi-qup.c           | 4 ++--
 drivers/spi/spi-s3c64xx.c       | 6 ++----
 drivers/spi/spi-tegra114.c      | 3 +--
 drivers/spi/spi-tegra20-slink.c | 3 +--
 9 files changed, 15 insertions(+), 19 deletions(-)

-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH 1/9] spi: at91-usart: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-13  9:42 ` Peter Ujfalusi
  2019-11-13 14:18   ` Nicolas.Ferre
  2019-11-15 12:25   ` Applied "spi: at91-usart: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  2019-11-13  9:42 ` [PATCH 2/9] spi: atmel: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (8 subsequent siblings)
  9 siblings, 2 replies; 29+ messages in thread
From: Peter Ujfalusi @ 2019-11-13  9:42 UTC (permalink / raw)
  To: broonie, radu_nicolae.pirea, shawnguo, s.hauer, linus.walleij,
	agross, bjorn.andersson, andi, ldewangan, thierry.reding,
	jonathanh
  Cc: alexandre.belloni, linux-arm-msm, linux-kernel, krzk, linux-spi,
	vkoul, kgene, linux-tegra, linux-arm-kernel

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/spi/spi-at91-usart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c
index a40bb2ef89dc..88033422a42a 100644
--- a/drivers/spi/spi-at91-usart.c
+++ b/drivers/spi/spi-at91-usart.c
@@ -132,7 +132,7 @@ static int at91_usart_spi_configure_dma(struct spi_controller *ctlr,
 	dma_cap_zero(mask);
 	dma_cap_set(DMA_SLAVE, mask);
 
-	ctlr->dma_tx = dma_request_slave_channel_reason(dev, "tx");
+	ctlr->dma_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR_OR_NULL(ctlr->dma_tx)) {
 		if (IS_ERR(ctlr->dma_tx)) {
 			err = PTR_ERR(ctlr->dma_tx);
@@ -145,7 +145,7 @@ static int at91_usart_spi_configure_dma(struct spi_controller *ctlr,
 		goto at91_usart_spi_error_clear;
 	}
 
-	ctlr->dma_rx = dma_request_slave_channel_reason(dev, "rx");
+	ctlr->dma_rx = dma_request_chan(dev, "rx");
 	if (IS_ERR_OR_NULL(ctlr->dma_rx)) {
 		if (IS_ERR(ctlr->dma_rx)) {
 			err = PTR_ERR(ctlr->dma_rx);
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* [PATCH 2/9] spi: atmel: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Peter Ujfalusi
  2019-11-13  9:42 ` [PATCH 1/9] spi: at91-usart: " Peter Ujfalusi
@ 2019-11-13  9:42 ` Peter Ujfalusi
  2019-11-13 14:18   ` Nicolas.Ferre
  2019-11-15 12:25   ` Applied "spi: atmel: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  2019-11-13  9:42 ` [PATCH 3/9] spi: fsl-lpspi: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (7 subsequent siblings)
  9 siblings, 2 replies; 29+ messages in thread
From: Peter Ujfalusi @ 2019-11-13  9:42 UTC (permalink / raw)
  To: broonie, radu_nicolae.pirea, shawnguo, s.hauer, linus.walleij,
	agross, bjorn.andersson, andi, ldewangan, thierry.reding,
	jonathanh
  Cc: vkoul, linux-spi, linux-arm-kernel, linux-kernel,
	alexandre.belloni, linux-arm-msm, kgene, krzk, linux-tegra

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/spi/spi-atmel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 9e84a93083bc..56f0ca361deb 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -511,7 +511,7 @@ static int atmel_spi_configure_dma(struct spi_master *master,
 	dma_cap_zero(mask);
 	dma_cap_set(DMA_SLAVE, mask);
 
-	master->dma_tx = dma_request_slave_channel_reason(dev, "tx");
+	master->dma_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR(master->dma_tx)) {
 		err = PTR_ERR(master->dma_tx);
 		if (err == -EPROBE_DEFER) {
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* [PATCH 3/9] spi: fsl-lpspi: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Peter Ujfalusi
  2019-11-13  9:42 ` [PATCH 1/9] spi: at91-usart: " Peter Ujfalusi
  2019-11-13  9:42 ` [PATCH 2/9] spi: atmel: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-13  9:42 ` Peter Ujfalusi
  2019-11-15 12:25   ` Applied "spi: fsl-lpspi: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  2019-11-13  9:42 ` [PATCH 4/9] spi: imx: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (6 subsequent siblings)
  9 siblings, 1 reply; 29+ messages in thread
From: Peter Ujfalusi @ 2019-11-13  9:42 UTC (permalink / raw)
  To: broonie, radu_nicolae.pirea, shawnguo, s.hauer, linus.walleij,
	agross, bjorn.andersson, andi, ldewangan, thierry.reding,
	jonathanh
  Cc: vkoul, linux-spi, linux-arm-kernel, linux-kernel,
	alexandre.belloni, linux-arm-msm, kgene, krzk, linux-tegra

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/spi/spi-fsl-lpspi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
index 6f4769a53f8a..2cc0ddb4a988 100644
--- a/drivers/spi/spi-fsl-lpspi.c
+++ b/drivers/spi/spi-fsl-lpspi.c
@@ -675,7 +675,7 @@ static int fsl_lpspi_dma_init(struct device *dev,
 	int ret;
 
 	/* Prepare for TX DMA: */
-	controller->dma_tx = dma_request_slave_channel_reason(dev, "tx");
+	controller->dma_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR(controller->dma_tx)) {
 		ret = PTR_ERR(controller->dma_tx);
 		dev_dbg(dev, "can't get the TX DMA channel, error %d!\n", ret);
@@ -684,7 +684,7 @@ static int fsl_lpspi_dma_init(struct device *dev,
 	}
 
 	/* Prepare for RX DMA: */
-	controller->dma_rx = dma_request_slave_channel_reason(dev, "rx");
+	controller->dma_rx = dma_request_chan(dev, "rx");
 	if (IS_ERR(controller->dma_rx)) {
 		ret = PTR_ERR(controller->dma_rx);
 		dev_dbg(dev, "can't get the RX DMA channel, error %d\n", ret);
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* [PATCH 4/9] spi: imx: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (2 preceding siblings ...)
  2019-11-13  9:42 ` [PATCH 3/9] spi: fsl-lpspi: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-13  9:42 ` Peter Ujfalusi
  2019-11-15 12:25   ` Applied "spi: imx: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  2019-11-13  9:42 ` [PATCH 5/9] spi: pl022: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (5 subsequent siblings)
  9 siblings, 1 reply; 29+ messages in thread
From: Peter Ujfalusi @ 2019-11-13  9:42 UTC (permalink / raw)
  To: broonie, radu_nicolae.pirea, shawnguo, s.hauer, linus.walleij,
	agross, bjorn.andersson, andi, ldewangan, thierry.reding,
	jonathanh
  Cc: vkoul, linux-spi, linux-arm-kernel, linux-kernel,
	alexandre.belloni, linux-arm-msm, kgene, krzk, linux-tegra

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/spi/spi-imx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 09c9a1edb2c6..49f0099db0cb 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -1272,7 +1272,7 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx,
 	spi_imx->wml = spi_imx->devtype_data->fifo_size / 2;
 
 	/* Prepare for TX DMA: */
-	master->dma_tx = dma_request_slave_channel_reason(dev, "tx");
+	master->dma_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR(master->dma_tx)) {
 		ret = PTR_ERR(master->dma_tx);
 		dev_dbg(dev, "can't get the TX DMA channel, error %d!\n", ret);
@@ -1281,7 +1281,7 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx,
 	}
 
 	/* Prepare for RX : */
-	master->dma_rx = dma_request_slave_channel_reason(dev, "rx");
+	master->dma_rx = dma_request_chan(dev, "rx");
 	if (IS_ERR(master->dma_rx)) {
 		ret = PTR_ERR(master->dma_rx);
 		dev_dbg(dev, "can't get the RX DMA channel, error %d\n", ret);
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* [PATCH 5/9] spi: pl022: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (3 preceding siblings ...)
  2019-11-13  9:42 ` [PATCH 4/9] spi: imx: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-13  9:42 ` Peter Ujfalusi
  2019-11-13 17:16   ` Linus Walleij
  2019-11-15 12:25   ` Applied "spi: pl022: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  2019-11-13  9:42 ` [PATCH 6/9] spi: qup: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (4 subsequent siblings)
  9 siblings, 2 replies; 29+ messages in thread
From: Peter Ujfalusi @ 2019-11-13  9:42 UTC (permalink / raw)
  To: broonie, radu_nicolae.pirea, shawnguo, s.hauer, linus.walleij,
	agross, bjorn.andersson, andi, ldewangan, thierry.reding,
	jonathanh
  Cc: vkoul, linux-spi, linux-arm-kernel, linux-kernel,
	alexandre.belloni, linux-arm-msm, kgene, krzk, linux-tegra

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/spi/spi-pl022.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 3024c30e7f2e..66028ebbc336 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -1158,7 +1158,7 @@ static int pl022_dma_autoprobe(struct pl022 *pl022)
 	int err;
 
 	/* automatically configure DMA channels from platform, normally using DT */
-	chan = dma_request_slave_channel_reason(dev, "rx");
+	chan = dma_request_chan(dev, "rx");
 	if (IS_ERR(chan)) {
 		err = PTR_ERR(chan);
 		goto err_no_rxchan;
@@ -1166,7 +1166,7 @@ static int pl022_dma_autoprobe(struct pl022 *pl022)
 
 	pl022->dma_rx_channel = chan;
 
-	chan = dma_request_slave_channel_reason(dev, "tx");
+	chan = dma_request_chan(dev, "tx");
 	if (IS_ERR(chan)) {
 		err = PTR_ERR(chan);
 		goto err_no_txchan;
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* [PATCH 6/9] spi: qup: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (4 preceding siblings ...)
  2019-11-13  9:42 ` [PATCH 5/9] spi: pl022: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-13  9:42 ` Peter Ujfalusi
  2019-11-15 12:25   ` Applied "spi: qup: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  2019-11-13  9:42 ` [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (3 subsequent siblings)
  9 siblings, 1 reply; 29+ messages in thread
From: Peter Ujfalusi @ 2019-11-13  9:42 UTC (permalink / raw)
  To: broonie, radu_nicolae.pirea, shawnguo, s.hauer, linus.walleij,
	agross, bjorn.andersson, andi, ldewangan, thierry.reding,
	jonathanh
  Cc: vkoul, linux-spi, linux-arm-kernel, linux-kernel,
	alexandre.belloni, linux-arm-msm, kgene, krzk, linux-tegra

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/spi/spi-qup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 2f559e531100..dd3434a407ea 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -932,11 +932,11 @@ static int spi_qup_init_dma(struct spi_master *master, resource_size_t base)
 	int ret;
 
 	/* allocate dma resources, if available */
-	master->dma_rx = dma_request_slave_channel_reason(dev, "rx");
+	master->dma_rx = dma_request_chan(dev, "rx");
 	if (IS_ERR(master->dma_rx))
 		return PTR_ERR(master->dma_rx);
 
-	master->dma_tx = dma_request_slave_channel_reason(dev, "tx");
+	master->dma_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR(master->dma_tx)) {
 		ret = PTR_ERR(master->dma_tx);
 		goto err_tx;
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (5 preceding siblings ...)
  2019-11-13  9:42 ` [PATCH 6/9] spi: qup: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-13  9:42 ` Peter Ujfalusi
  2019-11-13 23:40   ` Andi Shyti
                     ` (2 more replies)
  2019-11-13  9:42 ` [PATCH 8/9] spi: tegra114: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (2 subsequent siblings)
  9 siblings, 3 replies; 29+ messages in thread
From: Peter Ujfalusi @ 2019-11-13  9:42 UTC (permalink / raw)
  To: broonie, radu_nicolae.pirea, shawnguo, s.hauer, linus.walleij,
	agross, bjorn.andersson, andi, ldewangan, thierry.reding,
	jonathanh
  Cc: vkoul, linux-spi, linux-arm-kernel, linux-kernel,
	alexandre.belloni, linux-arm-msm, kgene, krzk, linux-tegra

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/spi/spi-s3c64xx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 7b7151ec14c8..cf67ea60dc0e 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -1154,15 +1154,13 @@ static int s3c64xx_spi_probe(struct platform_device *pdev)
 
 	if (!is_polling(sdd)) {
 		/* Acquire DMA channels */
-		sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev,
-								  "rx");
+		sdd->rx_dma.ch = dma_request_chan(&pdev->dev, "rx");
 		if (IS_ERR(sdd->rx_dma.ch)) {
 			dev_err(&pdev->dev, "Failed to get RX DMA channel\n");
 			ret = PTR_ERR(sdd->rx_dma.ch);
 			goto err_disable_io_clk;
 		}
-		sdd->tx_dma.ch = dma_request_slave_channel_reason(&pdev->dev,
-								  "tx");
+		sdd->tx_dma.ch = dma_request_chan(&pdev->dev, "tx");
 		if (IS_ERR(sdd->tx_dma.ch)) {
 			dev_err(&pdev->dev, "Failed to get TX DMA channel\n");
 			ret = PTR_ERR(sdd->tx_dma.ch);
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* [PATCH 8/9] spi: tegra114: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (6 preceding siblings ...)
  2019-11-13  9:42 ` [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-13  9:42 ` Peter Ujfalusi
  2019-11-14  7:06   ` Jon Hunter
  2019-11-15 12:25   ` Applied "spi: tegra114: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  2019-11-13  9:42 ` [PATCH 9/9] spi: tegra20-slink: Use dma_request_chan() directly for channel request Peter Ujfalusi
  2019-11-14  4:35 ` [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Vinod Koul
  9 siblings, 2 replies; 29+ messages in thread
From: Peter Ujfalusi @ 2019-11-13  9:42 UTC (permalink / raw)
  To: broonie, radu_nicolae.pirea, shawnguo, s.hauer, linus.walleij,
	agross, bjorn.andersson, andi, ldewangan, thierry.reding,
	jonathanh
  Cc: vkoul, linux-spi, linux-arm-kernel, linux-kernel,
	alexandre.belloni, linux-arm-msm, kgene, krzk, linux-tegra

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/spi/spi-tegra114.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index e6a450d9b4f0..fc40ab146c86 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -666,8 +666,7 @@ static int tegra_spi_init_dma_param(struct tegra_spi_data *tspi,
 	dma_addr_t dma_phys;
 	int ret;
 
-	dma_chan = dma_request_slave_channel_reason(tspi->dev,
-					dma_to_memory ? "rx" : "tx");
+	dma_chan = dma_request_chan(tspi->dev, dma_to_memory ? "rx" : "tx");
 	if (IS_ERR(dma_chan)) {
 		ret = PTR_ERR(dma_chan);
 		if (ret != -EPROBE_DEFER)
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* [PATCH 9/9] spi: tegra20-slink: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (7 preceding siblings ...)
  2019-11-13  9:42 ` [PATCH 8/9] spi: tegra114: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-13  9:42 ` Peter Ujfalusi
  2019-11-14  7:06   ` Jon Hunter
  2019-11-15 12:25   ` Applied "spi: tegra20-slink: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  2019-11-14  4:35 ` [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Vinod Koul
  9 siblings, 2 replies; 29+ messages in thread
From: Peter Ujfalusi @ 2019-11-13  9:42 UTC (permalink / raw)
  To: broonie, radu_nicolae.pirea, shawnguo, s.hauer, linus.walleij,
	agross, bjorn.andersson, andi, ldewangan, thierry.reding,
	jonathanh
  Cc: vkoul, linux-spi, linux-arm-kernel, linux-kernel,
	alexandre.belloni, linux-arm-msm, kgene, krzk, linux-tegra

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/spi/spi-tegra20-slink.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index 111fffc91435..51573f41ed12 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -599,8 +599,7 @@ static int tegra_slink_init_dma_param(struct tegra_slink_data *tspi,
 	int ret;
 	struct dma_slave_config dma_sconfig;
 
-	dma_chan = dma_request_slave_channel_reason(tspi->dev,
-						dma_to_memory ? "rx" : "tx");
+	dma_chan = dma_request_chan(tspi->dev, dma_to_memory ? "rx" : "tx");
 	if (IS_ERR(dma_chan)) {
 		ret = PTR_ERR(dma_chan);
 		if (ret != -EPROBE_DEFER)
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* Re: [PATCH 2/9] spi: atmel: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 ` [PATCH 2/9] spi: atmel: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-13 14:18   ` Nicolas.Ferre
  2019-11-15 12:25   ` Applied "spi: atmel: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  1 sibling, 0 replies; 29+ messages in thread
From: Nicolas.Ferre @ 2019-11-13 14:18 UTC (permalink / raw)
  To: peter.ujfalusi, broonie, radu_nicolae.pirea, shawnguo, s.hauer,
	linus.walleij, agross, bjorn.andersson, andi, ldewangan,
	thierry.reding, jonathanh
  Cc: alexandre.belloni, linux-arm-msm, linux-kernel, krzk, linux-spi,
	vkoul, kgene, linux-tegra, linux-arm-kernel

On 13/11/2019 at 10:42, Peter Ujfalusi wrote:
> 
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
> 	dma_request_chan(dev, name)
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

I'm not sure we need one patch per driver. If series taken:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   drivers/spi/spi-atmel.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 9e84a93083bc..56f0ca361deb 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -511,7 +511,7 @@ static int atmel_spi_configure_dma(struct spi_master *master,
>   	dma_cap_zero(mask);
>   	dma_cap_set(DMA_SLAVE, mask);
>   
> -	master->dma_tx = dma_request_slave_channel_reason(dev, "tx");
> +	master->dma_tx = dma_request_chan(dev, "tx");
>   	if (IS_ERR(master->dma_tx)) {
>   		err = PTR_ERR(master->dma_tx);
>   		if (err == -EPROBE_DEFER) {
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH 1/9] spi: at91-usart: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 ` [PATCH 1/9] spi: at91-usart: " Peter Ujfalusi
@ 2019-11-13 14:18   ` Nicolas.Ferre
  2019-11-15 12:25   ` Applied "spi: at91-usart: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  1 sibling, 0 replies; 29+ messages in thread
From: Nicolas.Ferre @ 2019-11-13 14:18 UTC (permalink / raw)
  To: peter.ujfalusi, broonie, radu_nicolae.pirea, shawnguo, s.hauer,
	linus.walleij, agross, bjorn.andersson, andi, ldewangan,
	thierry.reding, jonathanh
  Cc: alexandre.belloni, linux-arm-msm, linux-kernel, krzk, linux-spi,
	vkoul, kgene, linux-tegra, linux-arm-kernel

On 13/11/2019 at 10:42, Peter Ujfalusi wrote:
> External E-Mail
> 
> 
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
> 	dma_request_chan(dev, name)
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   drivers/spi/spi-at91-usart.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c
> index a40bb2ef89dc..88033422a42a 100644
> --- a/drivers/spi/spi-at91-usart.c
> +++ b/drivers/spi/spi-at91-usart.c
> @@ -132,7 +132,7 @@ static int at91_usart_spi_configure_dma(struct spi_controller *ctlr,
>   	dma_cap_zero(mask);
>   	dma_cap_set(DMA_SLAVE, mask);
>   
> -	ctlr->dma_tx = dma_request_slave_channel_reason(dev, "tx");
> +	ctlr->dma_tx = dma_request_chan(dev, "tx");
>   	if (IS_ERR_OR_NULL(ctlr->dma_tx)) {
>   		if (IS_ERR(ctlr->dma_tx)) {
>   			err = PTR_ERR(ctlr->dma_tx);
> @@ -145,7 +145,7 @@ static int at91_usart_spi_configure_dma(struct spi_controller *ctlr,
>   		goto at91_usart_spi_error_clear;
>   	}
>   
> -	ctlr->dma_rx = dma_request_slave_channel_reason(dev, "rx");
> +	ctlr->dma_rx = dma_request_chan(dev, "rx");
>   	if (IS_ERR_OR_NULL(ctlr->dma_rx)) {
>   		if (IS_ERR(ctlr->dma_rx)) {
>   			err = PTR_ERR(ctlr->dma_rx);
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH 5/9] spi: pl022: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 ` [PATCH 5/9] spi: pl022: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-13 17:16   ` Linus Walleij
  2019-11-15 12:25   ` Applied "spi: pl022: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  1 sibling, 0 replies; 29+ messages in thread
From: Linus Walleij @ 2019-11-13 17:16 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: Mark Brown, radu_nicolae.pirea, Shawn Guo, Sascha Hauer,
	Andy Gross, Bjorn Andersson, Andi Shyti, Laxman Dewangan,
	thierry.reding, Jon Hunter, Vinod Koul, linux-spi, Linux ARM,
	linux-kernel, Alexandre Belloni, MSM, Kukjin Kim,
	Krzysztof Kozlowski, linux-tegra

On Wed, Nov 13, 2019 at 10:42 AM Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:

> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
>         dma_request_chan(dev, name)
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 ` [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-13 23:40   ` Andi Shyti
  2019-11-14  8:09     ` Peter Ujfalusi
  2019-11-14  6:27   ` Krzysztof Kozlowski
  2019-11-15 12:25   ` Applied "spi: s3c64xx: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  2 siblings, 1 reply; 29+ messages in thread
From: Andi Shyti @ 2019-11-13 23:40 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: broonie, radu_nicolae.pirea, shawnguo, s.hauer, linus.walleij,
	agross, bjorn.andersson, andi, ldewangan, thierry.reding,
	jonathanh, vkoul, linux-spi, linux-arm-kernel, linux-kernel,
	alexandre.belloni, linux-arm-msm, kgene, krzk, linux-tegra

Hi Peter,

>  	if (!is_polling(sdd)) {
>  		/* Acquire DMA channels */
> -		sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev,
> -								  "rx");
> +		sdd->rx_dma.ch = dma_request_chan(&pdev->dev, "rx");

I have a little concern here. We have two funcions
'dma_request_chan' and  'dma_request_channel' don't we end up
making some confusion here?

Wouldn't it make more sense renaming 'dma_request_chan' to
'dma_request_slave_channel_reason'?

Thanks,
Andi

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH 0/9] spi: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Peter Ujfalusi
                   ` (8 preceding siblings ...)
  2019-11-13  9:42 ` [PATCH 9/9] spi: tegra20-slink: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-14  4:35 ` Vinod Koul
  9 siblings, 0 replies; 29+ messages in thread
From: Vinod Koul @ 2019-11-14  4:35 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: broonie, radu_nicolae.pirea, shawnguo, s.hauer, linus.walleij,
	agross, bjorn.andersson, andi, ldewangan, thierry.reding,
	jonathanh, linux-spi, linux-arm-kernel, linux-kernel,
	alexandre.belloni, linux-arm-msm, kgene, krzk, linux-tegra

On 13-11-19, 11:42, Peter Ujfalusi wrote:
> Hi,
> 
> I'm going through the tree to remove dma_request_slave_channel_reason() as it
> is just:
> #define dma_request_slave_channel_reason(dev, name) \
> 	dma_request_chan(dev, name)

Reviewed-by: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 ` [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request Peter Ujfalusi
  2019-11-13 23:40   ` Andi Shyti
@ 2019-11-14  6:27   ` Krzysztof Kozlowski
  2019-11-15 12:25   ` Applied "spi: s3c64xx: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  2 siblings, 0 replies; 29+ messages in thread
From: Krzysztof Kozlowski @ 2019-11-14  6:27 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: linus.walleij, kgene, alexandre.belloni, linux-arm-msm,
	radu_nicolae.pirea, linux-spi, linux-kernel, bjorn.andersson,
	vkoul, agross, ldewangan, broonie, Andi Shyti, linux-tegra,
	thierry.reding, jonathanh, shawnguo, s.hauer, linux-arm-kernel

On Wed, 13 Nov 2019 at 17:42, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
>
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
>         dma_request_chan(dev, name)
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  drivers/spi/spi-s3c64xx.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH 8/9] spi: tegra114: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 ` [PATCH 8/9] spi: tegra114: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-14  7:06   ` Jon Hunter
  2019-11-15 12:25   ` Applied "spi: tegra114: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  1 sibling, 0 replies; 29+ messages in thread
From: Jon Hunter @ 2019-11-14  7:06 UTC (permalink / raw)
  To: Peter Ujfalusi, broonie, radu_nicolae.pirea, shawnguo, s.hauer,
	linus.walleij, agross, bjorn.andersson, andi, ldewangan,
	thierry.reding
  Cc: vkoul, linux-spi, linux-arm-kernel, linux-kernel,
	alexandre.belloni, linux-arm-msm, kgene, krzk, linux-tegra


On 13/11/2019 09:42, Peter Ujfalusi wrote:
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
> 	dma_request_chan(dev, name)
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  drivers/spi/spi-tegra114.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
> index e6a450d9b4f0..fc40ab146c86 100644
> --- a/drivers/spi/spi-tegra114.c
> +++ b/drivers/spi/spi-tegra114.c
> @@ -666,8 +666,7 @@ static int tegra_spi_init_dma_param(struct tegra_spi_data *tspi,
>  	dma_addr_t dma_phys;
>  	int ret;
>  
> -	dma_chan = dma_request_slave_channel_reason(tspi->dev,
> -					dma_to_memory ? "rx" : "tx");
> +	dma_chan = dma_request_chan(tspi->dev, dma_to_memory ? "rx" : "tx");
>  	if (IS_ERR(dma_chan)) {
>  		ret = PTR_ERR(dma_chan);
>  		if (ret != -EPROBE_DEFER)
> 

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers!
Jon

-- 
nvpublic

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH 9/9] spi: tegra20-slink: Use dma_request_chan() directly for channel request
  2019-11-13  9:42 ` [PATCH 9/9] spi: tegra20-slink: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-14  7:06   ` Jon Hunter
  2019-11-15 12:25   ` Applied "spi: tegra20-slink: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
  1 sibling, 0 replies; 29+ messages in thread
From: Jon Hunter @ 2019-11-14  7:06 UTC (permalink / raw)
  To: Peter Ujfalusi, broonie, radu_nicolae.pirea, shawnguo, s.hauer,
	linus.walleij, agross, bjorn.andersson, andi, ldewangan,
	thierry.reding
  Cc: vkoul, linux-spi, linux-arm-kernel, linux-kernel,
	alexandre.belloni, linux-arm-msm, kgene, krzk, linux-tegra


On 13/11/2019 09:42, Peter Ujfalusi wrote:
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
> 	dma_request_chan(dev, name)
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  drivers/spi/spi-tegra20-slink.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
> index 111fffc91435..51573f41ed12 100644
> --- a/drivers/spi/spi-tegra20-slink.c
> +++ b/drivers/spi/spi-tegra20-slink.c
> @@ -599,8 +599,7 @@ static int tegra_slink_init_dma_param(struct tegra_slink_data *tspi,
>  	int ret;
>  	struct dma_slave_config dma_sconfig;
>  
> -	dma_chan = dma_request_slave_channel_reason(tspi->dev,
> -						dma_to_memory ? "rx" : "tx");
> +	dma_chan = dma_request_chan(tspi->dev, dma_to_memory ? "rx" : "tx");
>  	if (IS_ERR(dma_chan)) {
>  		ret = PTR_ERR(dma_chan);
>  		if (ret != -EPROBE_DEFER)
> 

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers!
Jon

-- 
nvpublic

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request
  2019-11-13 23:40   ` Andi Shyti
@ 2019-11-14  8:09     ` Peter Ujfalusi
  2019-11-14  9:12       ` Andi Shyti
  0 siblings, 1 reply; 29+ messages in thread
From: Peter Ujfalusi @ 2019-11-14  8:09 UTC (permalink / raw)
  To: Andi Shyti
  Cc: jonathanh, alexandre.belloni, s.hauer, linux-arm-msm,
	radu_nicolae.pirea, broonie, linux-kernel, krzk, linux-spi,
	vkoul, kgene, ldewangan, agross, linux-tegra, thierry.reding,
	bjorn.andersson, shawnguo, linus.walleij, linux-arm-kernel



On 14/11/2019 1.40, Andi Shyti wrote:
> Hi Peter,
> 
>>  	if (!is_polling(sdd)) {
>>  		/* Acquire DMA channels */
>> -		sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev,
>> -								  "rx");
>> +		sdd->rx_dma.ch = dma_request_chan(&pdev->dev, "rx");
> 
> I have a little concern here. We have two funcions
> 'dma_request_chan' and  'dma_request_channel' don't we end up
> making some confusion here?
> 
> Wouldn't it make more sense renaming 'dma_request_chan' to
> 'dma_request_slave_channel_reason'?

The dma_request_channel() should go away. It was the old API before we
got the dma_slave_map for non DT (and non ACPI) platforms so we can get
rid of the filter function exports from DMA drivers to clients all over
the place.

I know there are users where they provide dummy filter function.

At the end the main API to request slave DMA channel should be
dma_request_chan()
For non slave channels (not HW triggered) we have dma_request_chan_by_mask()

Imoh the dma_request_slave_channel_compat() should also go away with time.

> 
> Thanks,
> Andi
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request
  2019-11-14  8:09     ` Peter Ujfalusi
@ 2019-11-14  9:12       ` Andi Shyti
  0 siblings, 0 replies; 29+ messages in thread
From: Andi Shyti @ 2019-11-14  9:12 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: jonathanh, alexandre.belloni, s.hauer, linux-arm-msm,
	radu_nicolae.pirea, broonie, linux-kernel, krzk, linux-spi,
	vkoul, kgene, ldewangan, agross, Andi Shyti, linux-tegra,
	thierry.reding, bjorn.andersson, shawnguo, linus.walleij,
	linux-arm-kernel

Hi Peter,

> >>  	if (!is_polling(sdd)) {
> >>  		/* Acquire DMA channels */
> >> -		sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev,
> >> -								  "rx");
> >> +		sdd->rx_dma.ch = dma_request_chan(&pdev->dev, "rx");
> > 
> > I have a little concern here. We have two funcions
> > 'dma_request_chan' and  'dma_request_channel' don't we end up
> > making some confusion here?
> > 
> > Wouldn't it make more sense renaming 'dma_request_chan' to
> > 'dma_request_slave_channel_reason'?
> 
> The dma_request_channel() should go away. It was the old API before we
> got the dma_slave_map for non DT (and non ACPI) platforms so we can get
> rid of the filter function exports from DMA drivers to clients all over
> the place.

Yes, I agree... thanks!

Acked-by: Andi Shyti <andi@etezian.org>

Thanks,
Andi

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Applied "spi: tegra20-slink: Use dma_request_chan() directly for channel request" to the spi tree
  2019-11-13  9:42 ` [PATCH 9/9] spi: tegra20-slink: Use dma_request_chan() directly for channel request Peter Ujfalusi
  2019-11-14  7:06   ` Jon Hunter
@ 2019-11-15 12:25   ` Mark Brown
  1 sibling, 0 replies; 29+ messages in thread
From: Mark Brown @ 2019-11-15 12:25 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: agross, alexandre.belloni, andi, bjorn.andersson, broonie,
	jonathanh, Jon Hunter, kgene, krzk, ldewangan, linus.walleij,
	linux-arm-kernel, linux-arm-msm, linux-kernel, linux-spi,
	linux-tegra, Mark Brown, radu_nicolae.pirea, s.hauer, shawnguo,
	thierry.reding, vkoul

The patch

   spi: tegra20-slink: Use dma_request_chan() directly for channel request

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 912a7df474d2cb22fc99a1fcf77997f2cea7d85e Mon Sep 17 00:00:00 2001
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date: Wed, 13 Nov 2019 11:42:56 +0200
Subject: [PATCH] spi: tegra20-slink: Use dma_request_chan() directly for
 channel request

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Link: https://lore.kernel.org/r/20191113094256.1108-10-peter.ujfalusi@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-tegra20-slink.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index 111fffc91435..51573f41ed12 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -599,8 +599,7 @@ static int tegra_slink_init_dma_param(struct tegra_slink_data *tspi,
 	int ret;
 	struct dma_slave_config dma_sconfig;
 
-	dma_chan = dma_request_slave_channel_reason(tspi->dev,
-						dma_to_memory ? "rx" : "tx");
+	dma_chan = dma_request_chan(tspi->dev, dma_to_memory ? "rx" : "tx");
 	if (IS_ERR(dma_chan)) {
 		ret = PTR_ERR(dma_chan);
 		if (ret != -EPROBE_DEFER)
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* Applied "spi: tegra114: Use dma_request_chan() directly for channel request" to the spi tree
  2019-11-13  9:42 ` [PATCH 8/9] spi: tegra114: Use dma_request_chan() directly for channel request Peter Ujfalusi
  2019-11-14  7:06   ` Jon Hunter
@ 2019-11-15 12:25   ` Mark Brown
  1 sibling, 0 replies; 29+ messages in thread
From: Mark Brown @ 2019-11-15 12:25 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: agross, alexandre.belloni, andi, bjorn.andersson, broonie,
	jonathanh, Jon Hunter, kgene, krzk, ldewangan, linus.walleij,
	linux-arm-kernel, linux-arm-msm, linux-kernel, linux-spi,
	linux-tegra, Mark Brown, radu_nicolae.pirea, s.hauer, shawnguo,
	thierry.reding, vkoul

The patch

   spi: tegra114: Use dma_request_chan() directly for channel request

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 4c973b98cdd3b413216fdb9655a420737c46a4cb Mon Sep 17 00:00:00 2001
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date: Wed, 13 Nov 2019 11:42:55 +0200
Subject: [PATCH] spi: tegra114: Use dma_request_chan() directly for channel
 request

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Link: https://lore.kernel.org/r/20191113094256.1108-9-peter.ujfalusi@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-tegra114.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index e6a450d9b4f0..fc40ab146c86 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -666,8 +666,7 @@ static int tegra_spi_init_dma_param(struct tegra_spi_data *tspi,
 	dma_addr_t dma_phys;
 	int ret;
 
-	dma_chan = dma_request_slave_channel_reason(tspi->dev,
-					dma_to_memory ? "rx" : "tx");
+	dma_chan = dma_request_chan(tspi->dev, dma_to_memory ? "rx" : "tx");
 	if (IS_ERR(dma_chan)) {
 		ret = PTR_ERR(dma_chan);
 		if (ret != -EPROBE_DEFER)
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* Applied "spi: s3c64xx: Use dma_request_chan() directly for channel request" to the spi tree
  2019-11-13  9:42 ` [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request Peter Ujfalusi
  2019-11-13 23:40   ` Andi Shyti
  2019-11-14  6:27   ` Krzysztof Kozlowski
@ 2019-11-15 12:25   ` Mark Brown
  2 siblings, 0 replies; 29+ messages in thread
From: Mark Brown @ 2019-11-15 12:25 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: agross, alexandre.belloni, andi, Andi Shyti, bjorn.andersson,
	broonie, jonathanh, kgene, krzk, Krzysztof Kozlowski, ldewangan,
	linus.walleij, linux-arm-kernel, linux-arm-msm, linux-kernel,
	linux-spi, linux-tegra, Mark Brown, radu_nicolae.pirea, s.hauer,
	shawnguo, thierry.reding, vkoul

The patch

   spi: s3c64xx: Use dma_request_chan() directly for channel request

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From df1b0141788527c032a9851c0589a1712d7e46b8 Mon Sep 17 00:00:00 2001
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date: Wed, 13 Nov 2019 11:42:54 +0200
Subject: [PATCH] spi: s3c64xx: Use dma_request_chan() directly for channel
 request

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Andi Shyti <andi@etezian.org>
Link: https://lore.kernel.org/r/20191113094256.1108-8-peter.ujfalusi@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-s3c64xx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 7b7151ec14c8..cf67ea60dc0e 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -1154,15 +1154,13 @@ static int s3c64xx_spi_probe(struct platform_device *pdev)
 
 	if (!is_polling(sdd)) {
 		/* Acquire DMA channels */
-		sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev,
-								  "rx");
+		sdd->rx_dma.ch = dma_request_chan(&pdev->dev, "rx");
 		if (IS_ERR(sdd->rx_dma.ch)) {
 			dev_err(&pdev->dev, "Failed to get RX DMA channel\n");
 			ret = PTR_ERR(sdd->rx_dma.ch);
 			goto err_disable_io_clk;
 		}
-		sdd->tx_dma.ch = dma_request_slave_channel_reason(&pdev->dev,
-								  "tx");
+		sdd->tx_dma.ch = dma_request_chan(&pdev->dev, "tx");
 		if (IS_ERR(sdd->tx_dma.ch)) {
 			dev_err(&pdev->dev, "Failed to get TX DMA channel\n");
 			ret = PTR_ERR(sdd->tx_dma.ch);
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* Applied "spi: pl022: Use dma_request_chan() directly for channel request" to the spi tree
  2019-11-13  9:42 ` [PATCH 5/9] spi: pl022: Use dma_request_chan() directly for channel request Peter Ujfalusi
  2019-11-13 17:16   ` Linus Walleij
@ 2019-11-15 12:25   ` Mark Brown
  1 sibling, 0 replies; 29+ messages in thread
From: Mark Brown @ 2019-11-15 12:25 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: agross, alexandre.belloni, andi, bjorn.andersson, broonie,
	jonathanh, kgene, krzk, ldewangan, linus.walleij, Linus Walleij,
	linux-arm-kernel, linux-arm-msm, linux-kernel, linux-spi,
	linux-tegra, Mark Brown, radu_nicolae.pirea, s.hauer, shawnguo,
	thierry.reding, vkoul

The patch

   spi: pl022: Use dma_request_chan() directly for channel request

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From c1008957ff1aee0ac92c28c55947173fb68cd451 Mon Sep 17 00:00:00 2001
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date: Wed, 13 Nov 2019 11:42:52 +0200
Subject: [PATCH] spi: pl022: Use dma_request_chan() directly for channel
 request

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20191113094256.1108-6-peter.ujfalusi@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-pl022.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 3024c30e7f2e..66028ebbc336 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -1158,7 +1158,7 @@ static int pl022_dma_autoprobe(struct pl022 *pl022)
 	int err;
 
 	/* automatically configure DMA channels from platform, normally using DT */
-	chan = dma_request_slave_channel_reason(dev, "rx");
+	chan = dma_request_chan(dev, "rx");
 	if (IS_ERR(chan)) {
 		err = PTR_ERR(chan);
 		goto err_no_rxchan;
@@ -1166,7 +1166,7 @@ static int pl022_dma_autoprobe(struct pl022 *pl022)
 
 	pl022->dma_rx_channel = chan;
 
-	chan = dma_request_slave_channel_reason(dev, "tx");
+	chan = dma_request_chan(dev, "tx");
 	if (IS_ERR(chan)) {
 		err = PTR_ERR(chan);
 		goto err_no_txchan;
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* Applied "spi: imx: Use dma_request_chan() directly for channel request" to the spi tree
  2019-11-13  9:42 ` [PATCH 4/9] spi: imx: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-15 12:25   ` Mark Brown
  0 siblings, 0 replies; 29+ messages in thread
From: Mark Brown @ 2019-11-15 12:25 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: agross, alexandre.belloni, andi, bjorn.andersson, broonie,
	jonathanh, kgene, krzk, ldewangan, linus.walleij,
	linux-arm-kernel, linux-arm-msm, linux-kernel, linux-spi,
	linux-tegra, Mark Brown, radu_nicolae.pirea, s.hauer, shawnguo,
	thierry.reding, vkoul

The patch

   spi: imx: Use dma_request_chan() directly for channel request

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 5d3aa9ccf40cdc9b94d1a708d11de9062e2d9eed Mon Sep 17 00:00:00 2001
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date: Wed, 13 Nov 2019 11:42:51 +0200
Subject: [PATCH] spi: imx: Use dma_request_chan() directly for channel request

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20191113094256.1108-5-peter.ujfalusi@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-imx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 09c9a1edb2c6..49f0099db0cb 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -1272,7 +1272,7 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx,
 	spi_imx->wml = spi_imx->devtype_data->fifo_size / 2;
 
 	/* Prepare for TX DMA: */
-	master->dma_tx = dma_request_slave_channel_reason(dev, "tx");
+	master->dma_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR(master->dma_tx)) {
 		ret = PTR_ERR(master->dma_tx);
 		dev_dbg(dev, "can't get the TX DMA channel, error %d!\n", ret);
@@ -1281,7 +1281,7 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx,
 	}
 
 	/* Prepare for RX : */
-	master->dma_rx = dma_request_slave_channel_reason(dev, "rx");
+	master->dma_rx = dma_request_chan(dev, "rx");
 	if (IS_ERR(master->dma_rx)) {
 		ret = PTR_ERR(master->dma_rx);
 		dev_dbg(dev, "can't get the RX DMA channel, error %d\n", ret);
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* Applied "spi: qup: Use dma_request_chan() directly for channel request" to the spi tree
  2019-11-13  9:42 ` [PATCH 6/9] spi: qup: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-15 12:25   ` Mark Brown
  0 siblings, 0 replies; 29+ messages in thread
From: Mark Brown @ 2019-11-15 12:25 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: agross, alexandre.belloni, andi, bjorn.andersson, broonie,
	jonathanh, kgene, krzk, ldewangan, linus.walleij,
	linux-arm-kernel, linux-arm-msm, linux-kernel, linux-spi,
	linux-tegra, Mark Brown, radu_nicolae.pirea, s.hauer, shawnguo,
	thierry.reding, vkoul

The patch

   spi: qup: Use dma_request_chan() directly for channel request

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 194e1d4bc262c2d23ba9a8a5c03855c372ea1b5c Mon Sep 17 00:00:00 2001
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date: Wed, 13 Nov 2019 11:42:53 +0200
Subject: [PATCH] spi: qup: Use dma_request_chan() directly for channel request

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20191113094256.1108-7-peter.ujfalusi@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-qup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 2f559e531100..dd3434a407ea 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -932,11 +932,11 @@ static int spi_qup_init_dma(struct spi_master *master, resource_size_t base)
 	int ret;
 
 	/* allocate dma resources, if available */
-	master->dma_rx = dma_request_slave_channel_reason(dev, "rx");
+	master->dma_rx = dma_request_chan(dev, "rx");
 	if (IS_ERR(master->dma_rx))
 		return PTR_ERR(master->dma_rx);
 
-	master->dma_tx = dma_request_slave_channel_reason(dev, "tx");
+	master->dma_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR(master->dma_tx)) {
 		ret = PTR_ERR(master->dma_tx);
 		goto err_tx;
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* Applied "spi: atmel: Use dma_request_chan() directly for channel request" to the spi tree
  2019-11-13  9:42 ` [PATCH 2/9] spi: atmel: Use dma_request_chan() directly for channel request Peter Ujfalusi
  2019-11-13 14:18   ` Nicolas.Ferre
@ 2019-11-15 12:25   ` Mark Brown
  1 sibling, 0 replies; 29+ messages in thread
From: Mark Brown @ 2019-11-15 12:25 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: agross, alexandre.belloni, andi, bjorn.andersson, broonie,
	jonathanh, kgene, krzk, ldewangan, linus.walleij,
	linux-arm-kernel, linux-arm-msm, linux-kernel, linux-spi,
	linux-tegra, Mark Brown, Nicolas Ferre, radu_nicolae.pirea,
	s.hauer, shawnguo, thierry.reding, vkoul

The patch

   spi: atmel: Use dma_request_chan() directly for channel request

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From bef1e0c8f74c87e7427cb98b2e76caf046c7b65a Mon Sep 17 00:00:00 2001
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date: Wed, 13 Nov 2019 11:42:49 +0200
Subject: [PATCH] spi: atmel: Use dma_request_chan() directly for channel
 request

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20191113094256.1108-3-peter.ujfalusi@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-atmel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index d88e2aa64839..d692cc388126 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -512,7 +512,7 @@ static int atmel_spi_configure_dma(struct spi_master *master,
 	dma_cap_zero(mask);
 	dma_cap_set(DMA_SLAVE, mask);
 
-	master->dma_tx = dma_request_slave_channel_reason(dev, "tx");
+	master->dma_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR(master->dma_tx)) {
 		err = PTR_ERR(master->dma_tx);
 		if (err == -EPROBE_DEFER) {
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* Applied "spi: at91-usart: Use dma_request_chan() directly for channel request" to the spi tree
  2019-11-13  9:42 ` [PATCH 1/9] spi: at91-usart: " Peter Ujfalusi
  2019-11-13 14:18   ` Nicolas.Ferre
@ 2019-11-15 12:25   ` Mark Brown
  1 sibling, 0 replies; 29+ messages in thread
From: Mark Brown @ 2019-11-15 12:25 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: agross, alexandre.belloni, andi, bjorn.andersson, broonie,
	jonathanh, kgene, krzk, ldewangan, linus.walleij,
	linux-arm-kernel, linux-arm-msm, linux-kernel, linux-spi,
	linux-tegra, Mark Brown, Nicolas Ferre, radu_nicolae.pirea,
	s.hauer, shawnguo, thierry.reding, vkoul

The patch

   spi: at91-usart: Use dma_request_chan() directly for channel request

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From cef76e5ace759848e78323a14df0dcd66b8de13d Mon Sep 17 00:00:00 2001
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date: Wed, 13 Nov 2019 11:42:48 +0200
Subject: [PATCH] spi: at91-usart: Use dma_request_chan() directly for channel
 request

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20191113094256.1108-2-peter.ujfalusi@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-at91-usart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c
index a40bb2ef89dc..88033422a42a 100644
--- a/drivers/spi/spi-at91-usart.c
+++ b/drivers/spi/spi-at91-usart.c
@@ -132,7 +132,7 @@ static int at91_usart_spi_configure_dma(struct spi_controller *ctlr,
 	dma_cap_zero(mask);
 	dma_cap_set(DMA_SLAVE, mask);
 
-	ctlr->dma_tx = dma_request_slave_channel_reason(dev, "tx");
+	ctlr->dma_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR_OR_NULL(ctlr->dma_tx)) {
 		if (IS_ERR(ctlr->dma_tx)) {
 			err = PTR_ERR(ctlr->dma_tx);
@@ -145,7 +145,7 @@ static int at91_usart_spi_configure_dma(struct spi_controller *ctlr,
 		goto at91_usart_spi_error_clear;
 	}
 
-	ctlr->dma_rx = dma_request_slave_channel_reason(dev, "rx");
+	ctlr->dma_rx = dma_request_chan(dev, "rx");
 	if (IS_ERR_OR_NULL(ctlr->dma_rx)) {
 		if (IS_ERR(ctlr->dma_rx)) {
 			err = PTR_ERR(ctlr->dma_rx);
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 29+ messages in thread

* Applied "spi: fsl-lpspi: Use dma_request_chan() directly for channel request" to the spi tree
  2019-11-13  9:42 ` [PATCH 3/9] spi: fsl-lpspi: Use dma_request_chan() directly for channel request Peter Ujfalusi
@ 2019-11-15 12:25   ` Mark Brown
  0 siblings, 0 replies; 29+ messages in thread
From: Mark Brown @ 2019-11-15 12:25 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: agross, alexandre.belloni, andi, bjorn.andersson, broonie,
	jonathanh, kgene, krzk, ldewangan, linus.walleij,
	linux-arm-kernel, linux-arm-msm, linux-kernel, linux-spi,
	linux-tegra, Mark Brown, radu_nicolae.pirea, s.hauer, shawnguo,
	thierry.reding, vkoul

The patch

   spi: fsl-lpspi: Use dma_request_chan() directly for channel request

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 2e33f310dcfbceb7492d7e88baa9ca4f056f7c40 Mon Sep 17 00:00:00 2001
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date: Wed, 13 Nov 2019 11:42:50 +0200
Subject: [PATCH] spi: fsl-lpspi: Use dma_request_chan() directly for channel
 request

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
	dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20191113094256.1108-4-peter.ujfalusi@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-fsl-lpspi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
index 6f4769a53f8a..2cc0ddb4a988 100644
--- a/drivers/spi/spi-fsl-lpspi.c
+++ b/drivers/spi/spi-fsl-lpspi.c
@@ -675,7 +675,7 @@ static int fsl_lpspi_dma_init(struct device *dev,
 	int ret;
 
 	/* Prepare for TX DMA: */
-	controller->dma_tx = dma_request_slave_channel_reason(dev, "tx");
+	controller->dma_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR(controller->dma_tx)) {
 		ret = PTR_ERR(controller->dma_tx);
 		dev_dbg(dev, "can't get the TX DMA channel, error %d!\n", ret);
@@ -684,7 +684,7 @@ static int fsl_lpspi_dma_init(struct device *dev,
 	}
 
 	/* Prepare for RX DMA: */
-	controller->dma_rx = dma_request_slave_channel_reason(dev, "rx");
+	controller->dma_rx = dma_request_chan(dev, "rx");
 	if (IS_ERR(controller->dma_rx)) {
 		ret = PTR_ERR(controller->dma_rx);
 		dev_dbg(dev, "can't get the RX DMA channel, error %d\n", ret);
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2019-11-15 12:25 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13  9:42 [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13  9:42 ` [PATCH 1/9] spi: at91-usart: " Peter Ujfalusi
2019-11-13 14:18   ` Nicolas.Ferre
2019-11-15 12:25   ` Applied "spi: at91-usart: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-13  9:42 ` [PATCH 2/9] spi: atmel: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 14:18   ` Nicolas.Ferre
2019-11-15 12:25   ` Applied "spi: atmel: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-13  9:42 ` [PATCH 3/9] spi: fsl-lpspi: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-15 12:25   ` Applied "spi: fsl-lpspi: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-13  9:42 ` [PATCH 4/9] spi: imx: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-15 12:25   ` Applied "spi: imx: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-13  9:42 ` [PATCH 5/9] spi: pl022: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 17:16   ` Linus Walleij
2019-11-15 12:25   ` Applied "spi: pl022: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-13  9:42 ` [PATCH 6/9] spi: qup: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-15 12:25   ` Applied "spi: qup: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-13  9:42 ` [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 23:40   ` Andi Shyti
2019-11-14  8:09     ` Peter Ujfalusi
2019-11-14  9:12       ` Andi Shyti
2019-11-14  6:27   ` Krzysztof Kozlowski
2019-11-15 12:25   ` Applied "spi: s3c64xx: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-13  9:42 ` [PATCH 8/9] spi: tegra114: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-14  7:06   ` Jon Hunter
2019-11-15 12:25   ` Applied "spi: tegra114: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-13  9:42 ` [PATCH 9/9] spi: tegra20-slink: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-14  7:06   ` Jon Hunter
2019-11-15 12:25   ` Applied "spi: tegra20-slink: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-14  4:35 ` [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).