From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: Date: Wed, 12 Feb 2020 12:24:44 +0200 Message-ID: <20200212102444.GR10400@smile.fi.intel.com> References: <20200211223400.107604-1-rajatja@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Rajat Jain , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Evan Green , rajatxjain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, evgreen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, shobhit.srivastava-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, porselvan.muthukrishnan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org To: Jarkko Nikula Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Wed, Feb 12, 2020 at 11:30:51AM +0200, Jarkko Nikula wrote: > On 2/12/20 12:34 AM, Rajat Jain wrote: > This patch subject is missing from mail subject. > I'm thinking can this be done only once after resume and may other LPSS > blocks need the same? I.e. should this be done in drivers/mfd/intel-lpss.c? On resume we restore the previously saved context, can we be sure that values we saved during suspend are correct? If above won't show any issue, it might be best place to have this quirk applied in intel_lpss_suspend() / intel_lpss_resume() callbacks as Jarkko suggested. -- With Best Regards, Andy Shevchenko