linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	linux-spi <linux-spi@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	Linux-renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] spi: dt-bindings: spi-controller: Fix #address-cells for slave mode
Date: Thu, 27 Feb 2020 15:16:49 +0100	[thread overview]
Message-ID: <20200227141649.ji6js7vhlrltpn6z@gilmour.lan> (raw)
In-Reply-To: <CAMuHMdWYF9RrLdkuK_PxfVqocUMHVKPpjnyc4FR+N69A_htdyQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2177 bytes --]

On Thu, Feb 27, 2020 at 03:05:56PM +0100, Geert Uytterhoeven wrote:
> Hi Maxime,
>
> On Thu, Feb 27, 2020 at 2:51 PM Maxime Ripard <maxime@cerno.tech> wrote:
> > On Thu, Feb 27, 2020 at 02:19:08PM +0100, Geert Uytterhoeven wrote:
> > > On Thu, Feb 27, 2020 at 2:09 PM Maxime Ripard <maxime@cerno.tech> wrote:
> > > > On Thu, Feb 27, 2020 at 02:03:23PM +0100, Geert Uytterhoeven wrote:
> > > > > Currently, the DT bindings for an SPI controller specify that
> > > > > "#address-cells" must be fixed to one.  However, that applies to an SPI
> > > > > controller in master mode only.  When running in SPI slave mode,
> > > > > "#address-cells" should be zero.
> > > > >
> > > > > Fix this making the value of "#address-cells" dependent on the presence
> > > > > of "spi-slave".
> > > > >
> > > > > Fixes: 0a1b929356830257 ("spi: Add YAML schemas for the generic SPI options")
> > > > > Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > > > --- a/Documentation/devicetree/bindings/spi/spi-controller.yaml
> > > > > +++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml
> > >
> > > > > @@ -52,6 +53,18 @@ properties:
> > > > >      description:
> > > > >        The SPI controller acts as a slave, instead of a master.
> > > > >
> > > > > +if:
> > > > > +  required:
> > > > > +    [ spi-slave ]
> > > >
> > > > Nit: Usually, that notation is when you would do it on the same line,
> > > > if you want to go to a new line, it would make more sense to use -
> > >
> > > Sorry, being a poor yaml-by-example programmer, I don't understand what
> > > you mean.  Which part do you refer to by "that notation"?
> >
> > I meant that usually the [] notation is used over a single line.
> >
> > If you want to have a list over multiple lines, usually you would have
> >
> > required:
> >   - spi-slave
>
> IC. So I can also write:
>
>     if:
>       required: [ spi-slave ]
>     else:
>       ...
>
> which is even shorter ;-)
>
> Both seem to work fine.

The rest of the file uses the multi-line syntax, so I wouldn't do it
for consistency, but yeah, they are equivalent.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2020-02-27 14:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 13:03 Geert Uytterhoeven
2020-02-27 13:09 ` Maxime Ripard
     [not found]   ` <20200227130937.qvrjyxcwim7rfum7-2DbqMqoCcjvhXIiyNabO3w@public.gmane.org>
2020-02-27 13:19     ` Geert Uytterhoeven
     [not found]       ` <CAMuHMdUVW_51dqMK=ziz_JVT3LuXX7vOF3-Ei-aHiiBuSepGpg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-27 13:51         ` Maxime Ripard
     [not found]           ` <20200227135109.l2oal55nwhm5un2c-2DbqMqoCcjvhXIiyNabO3w@public.gmane.org>
2020-02-27 14:05             ` Geert Uytterhoeven
2020-02-27 14:16               ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200227141649.ji6js7vhlrltpn6z@gilmour.lan \
    --to=maxime@cerno.tech \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    --subject='Re: [PATCH] spi: dt-bindings: spi-controller: Fix #address-cells for slave mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).