From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Sergiu Cuciurean
<sergiu.cuciurean-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
kdasu.kdev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] spi: spi-bcm-qspi: Use new structure for SPI transfer delays
Date: Thu, 27 Feb 2020 15:29:06 +0000 [thread overview]
Message-ID: <20200227152906.GD4062@sirena.org.uk> (raw)
In-Reply-To: <20200227141050.10969-1-sergiu.cuciurean-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Thu, Feb 27, 2020 at 04:10:50PM +0200, Sergiu Cuciurean wrote:
> if (qt->byte >= qt->trans->len) {
> /* we're at the end of the spi_transfer */
> /* in TX mode, need to pause for a delay or CS change */
> - if (qt->trans->delay_usecs &&
> + if (qt->trans->delay.value &&
> + (qt->trans->delay.unit == SPI_DELAY_UNIT_USECS) &&
It doesn't seem ideal that if the delay ends up specified in a unit over
microseconds that we end up just ignoring the delay entirely. This
probably needs fixing in the core though, for example allowing the
driver to say what range of delays it can actually implement.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-02-27 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 14:10 [PATCH] spi: spi-bcm-qspi: Use new structure for SPI transfer delays Sergiu Cuciurean
[not found] ` <20200227141050.10969-1-sergiu.cuciurean-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
2020-02-27 15:29 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227152906.GD4062@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=kdasu.kdev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sergiu.cuciurean-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).