From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [RESEND v6 06/13] spi: imx: fix ERR009165 Date: Tue, 10 Mar 2020 09:37:25 +0100 Message-ID: <20200310083725.sb6cufp5wznvxcji@pengutronix.de> References: <1583839922-22699-1-git-send-email-yibin.gong@nxp.com> <1583839922-22699-7-git-send-email-yibin.gong@nxp.com> <20200310073920.GR3335@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: Sascha Hauer , "vkoul-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "catalin.marinas-5wv7dgnIgG8@public.gmane.org" , "will.deacon-5wv7dgnIgG8@public.gmane.org" , "l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , "martin.fuzzey-X8SyT9posyX3d/wEbhiU/g@public.gmane.org" , "kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel@vg To: Robin Gong Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hello, On Tue, Mar 10, 2020 at 08:27:41AM +0000, Robin Gong wrote: > On 2020/03/10 Sascha Hauer wrote: > > On Tue, Mar 10, 2020 at 07:31:55PM +0800, Robin Gong wrote: > > > writel(ctrl, spi_imx->base + MX51_ECSPI_CTRL); > > > > > > @@ -612,12 +613,14 @@ static int mx51_ecspi_prepare_transfer(struct > > > spi_imx_data *spi_imx, > > > > > > static void mx51_setup_wml(struct spi_imx_data *spi_imx) { > > > + u32 tx_wml = 0; > > > + > > > /* > > > * Configure the DMA register: setup the watermark > > > * and enable DMA request. > > > */ > > > writel(MX51_ECSPI_DMA_RX_WML(spi_imx->wml - 1) | > > > - MX51_ECSPI_DMA_TX_WML(spi_imx->wml) | > > > + MX51_ECSPI_DMA_TX_WML(tx_wml) | > > > > tx_wml is never assigned any other value than 0. Drop the variable. > That's prepared for 07/13 patch which may assign spi_imx->wml to tx_wml. Then this belongs into patch 7, right? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |