From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 1/2] spi: dt-bindings: spi-controller: Fix #address-cells for slave mode Date: Thu, 12 Mar 2020 14:16:52 -0500 Message-ID: <20200312191652.GA14819@bogus> References: <20200306085038.8111-1-geert+renesas@glider.be> <20200306085038.8111-2-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mark Brown , Yoshihiro Shimoda , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Geert Uytterhoeven To: Geert Uytterhoeven Return-path: Content-Disposition: inline In-Reply-To: <20200306085038.8111-2-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Fri, 6 Mar 2020 09:50:37 +0100, Geert Uytterhoeven wrote: > Currently, the DT bindings for an SPI controller specify that > "#address-cells" must be fixed to one. However, that applies to an SPI > controller in master mode only. When running in SPI slave mode, > "#address-cells" should not be specified. > > Fix this making "#address-cells" mutually-exclusive with "spi-slave". > > Fixes: 0a1b929356830257 ("spi: Add YAML schemas for the generic SPI options") > Reported-by: Yoshihiro Shimoda > Signed-off-by: Geert Uytterhoeven > --- > v3: > - Make #address-cells mutually-exclusive with spi-slave, > > v2: > - Use "enum: [0, 1]" instead of min/max limit, > - use "- spi-slave" instead of "[ spi-slave ]". > --- > Documentation/devicetree/bindings/spi/spi-controller.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > Reviewed-by: Rob Herring