From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v1 35/36] dt-bindings: display: convert lgphilips,lb035q02 to DT Schema Date: Mon, 16 Mar 2020 09:53:11 +0100 Message-ID: <20200316085311.GA19201@ravnborg.org> References: <20200315134416.16527-1-sam@ravnborg.org> <20200315134416.16527-36-sam@ravnborg.org> <20200316082607.GA18510@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Thierry Reding , Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexandre Courbot , Andrzej Hajda , Brian Masney , Chris Zhong , Douglas Anderson , Guido Gunther , Heiko Schocher , Nikolaus Schaller , Hoegeun Kwon , Jagan Teki , Jerry Han , Jonathan Bakker , Laurent Pinchart , Lin Huang , Linus Walleij , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Marco Fr To: Tomi Valkeinen Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hi Tomi. On Mon, Mar 16, 2020 at 10:42:45AM +0200, Tomi Valkeinen wrote: > On 16/03/2020 10:26, Sam Ravnborg wrote: > > > > Isn't this also compatible with panel-simple bindings? 'label' is the only > > > one not in panel-simple, but that's optional and has never been used by the > > > panel driver. > > The panel is a SPI slave - which is not too obvious from the old > > binding. > > > > The new DT Schema includes spi/spi-slave.yaml to give the binding > > proper access to the spi slave properties. > > > > That would not be possible with panel-simple binding as no further > > properties are allowed with the panel-simple binding. > > > > I hope this explains why there is a dedicated binding for this panel. > > Hmm, but how is this different than, say, DSI panels? There are DSI panels > in panel-simple bindings, and those might require DSI bus parameters ('reg' > in the minimum). We have panel-simple-dsi for DSI simple based panels. This binding includes the reg property. If we have included DSI panels in panel-simple.yaml, and we likely have by accident, then they should be moved to panel-simple-dsi.yaml. If they requires anything else then they shall have their own binding. panel-simple.yaml and panel-simple.dsi.yaml are on purpose only for the simple panels and they have: "additionalProperties: false" to avoid that a lot of extra sneaks in. I actually considered shortly a panel-simple-spi.yaml, but the few panels I looked at had different names for the power-supply so that did not fly. I did not check them all - we have today (with this patch-set) 9 bindings that references spi-slave.yaml. Sam