From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v1 32/36] dt-bindings: display: convert sharp,ls037v7dw01 to DT Schema Date: Wed, 18 Mar 2020 21:07:34 -0600 Message-ID: <20200319030734.GH29911@bogus> References: <20200315134416.16527-1-sam@ravnborg.org> <20200315134416.16527-33-sam@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Thierry Reding , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexandre Courbot , Andrzej Hajda , Brian Masney , Chris Zhong , Douglas Anderson , Guido Gunther , Heiko Schocher , Nikolaus Schaller , Hoegeun Kwon , Jagan Teki , Jerry Han , Jonathan Bakker , Laurent Pinchart , Lin Huang , Linus Walleij , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Marco Franchi , To: Sam Ravnborg Return-path: Content-Disposition: inline In-Reply-To: <20200315134416.16527-33-sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-spi.vger.kernel.org On Sun, Mar 15, 2020 at 02:44:12PM +0100, Sam Ravnborg wrote: > Signed-off-by: Sam Ravnborg > Cc: Tony Lindgren > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../display/panel/sharp,ls037v7dw01.txt | 43 ------------ > .../display/panel/sharp,ls037v7dw01.yaml | 66 +++++++++++++++++++ > 2 files changed, 66 insertions(+), 43 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/panel/sharp,ls037v7dw01.txt > create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,ls037v7dw01.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/sharp,ls037v7dw01.txt b/Documentation/devicetree/bindings/display/panel/sharp,ls037v7dw01.txt > deleted file mode 100644 > index 0cc8981e9d49..000000000000 > --- a/Documentation/devicetree/bindings/display/panel/sharp,ls037v7dw01.txt > +++ /dev/null > @@ -1,43 +0,0 @@ > -SHARP LS037V7DW01 TFT-LCD panel > -=================================== > - > -Required properties: > -- compatible: "sharp,ls037v7dw01" > - > -Optional properties: > -- label: a symbolic name for the panel > -- enable-gpios: a GPIO spec for the optional enable pin. > - This pin is the INI pin as specified in the LS037V7DW01.pdf file. > -- reset-gpios: a GPIO spec for the optional reset pin. > - This pin is the RESB pin as specified in the LS037V7DW01.pdf file. > -- mode-gpios: a GPIO > - ordered MO, LR, and UD as specified in the LS037V7DW01.pdf file. > - > -Required nodes: > -- Video port for DPI input > - > -This panel can have zero to five GPIOs to configure to change configuration > -between QVGA and VGA mode and the scan direction. As these pins can be also > -configured with external pulls, all the GPIOs are considered optional with holes > -in the array. > - > -Example > -------- > - > -Example when connected to a omap2+ based device: > - > -lcd0: display { > - compatible = "sharp,ls037v7dw01"; > - power-supply = <&lcd_3v3>; > - enable-gpios = <&gpio5 24 GPIO_ACTIVE_HIGH>; /* gpio152, lcd INI */ > - reset-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>; /* gpio155, lcd RESB */ > - mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH /* gpio154, lcd MO */ > - &gpio1 2 GPIO_ACTIVE_HIGH /* gpio2, lcd LR */ > - &gpio1 3 GPIO_ACTIVE_HIGH>; /* gpio3, lcd UD */ > - > - port { > - lcd_in: endpoint { > - remote-endpoint = <&dpi_out>; > - }; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/display/panel/sharp,ls037v7dw01.yaml b/Documentation/devicetree/bindings/display/panel/sharp,ls037v7dw01.yaml > new file mode 100644 > index 000000000000..56bd510ae398 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/sharp,ls037v7dw01.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/sharp,ls037v7dw01.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: SHARP LS037V7DW01 TFT-LCD panel > + > +description: | > + This panel can have zero to five GPIOs to configure to change configuration > + between QVGA and VGA mode and the scan direction. As these pins can be also > + configured with external pulls, all the GPIOs are considered optional with holes > + in the array. > + > +maintainers: > + - Tony Lindgren > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: sharp,ls037v7dw01 > + > + label: true > + enable-gpios: true > + reset-gpios: true > + port: true > + power-supply: true > + > + mode-gpios: > + description: | > + GPIO ordered MO, LR, and UD as specified in LS037V7DW01.pdf 3 or... > + This panel can have zero to five GPIOs to configure to 5? > + change configuration between QVGA and VGA mode and the > + scan direction. As these pins can be also configured > + with external pulls, all the GPIOs are considered > + optional with holes in the array. minItems: 3 maxItems: 5 > + > +required: > + - compatible > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + lcd0: display { > + compatible = "sharp,ls037v7dw01"; > + power-supply = <&lcd_3v3>; > + enable-gpios = <&gpio5 24 GPIO_ACTIVE_HIGH>; /* gpio152, lcd INI */ > + reset-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>; /* gpio155, lcd RESB */ > + mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH /* gpio154, lcd MO */ > + &gpio1 2 GPIO_ACTIVE_HIGH /* gpio2, lcd LR */ > + &gpio1 3 GPIO_ACTIVE_HIGH>; /* gpio3, lcd UD */ > + > + port { > + lcd_in: endpoint { > + remote-endpoint = <&dpi_out>; > + }; > + }; > + }; > + > +... > -- > 2.20.1 >