From: Boris Brezillon <boris.brezillon@collabora.com>
To: Ashish Kumar <Ashish.Kumar@nxp.com>
Cc: broonie@kernel.org, frieder.schrempf@kontron.de,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Kuldeep Singh <kuldeep.singh@nxp.com>
Subject: Re: [PATCH v3] spi: spi-fsl-qspi: Reduce devm_ioremap size to 4 times AHB buffer size
Date: Thu, 16 Apr 2020 14:06:04 +0200 [thread overview]
Message-ID: <20200416140604.3d8c9d78@collabora.com> (raw)
In-Reply-To: <1587037399-18672-1-git-send-email-Ashish.Kumar@nxp.com>
On Thu, 16 Apr 2020 17:13:19 +0530
Ashish Kumar <Ashish.Kumar@nxp.com> wrote:
> Reduce devm_ioremap size to (4 * AHB_BUFER_SIZE) rather than mapping
> complete QSPI-Memmory as driver is now independent of flash size.
> Flash of any size can be accessed.
>
> Issue was reported on platform where devm_ioremap failure is observed
> with size > 256M.
> Error log on LS1021ATWR :
> fsl-quadspi 1550000.spi: ioremap failed for resource [mem 0x40000000-0x7fffffff]
> fsl-quadspi 1550000.spi: Freescale QuadSPI probe failed
> fsl-quadspi: probe of 1550000.spi failed with error -12
>
> This change was also suggested previously:
> https://patchwork.kernel.org/patch/10508753/#22166385
>
> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
> Signed-off-by: Ashish Kumar <Ashish.kumar@nxp.com>
> ---
> v3:
> Update comment
> v2:
> Add Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
> Incorrporate review comments from Frieder
> drivers/spi/spi-fsl-qspi.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c
> index 63c9f7e..8b95e2f 100644
> --- a/drivers/spi/spi-fsl-qspi.c
> +++ b/drivers/spi/spi-fsl-qspi.c
> @@ -859,14 +859,15 @@ static int fsl_qspi_probe(struct platform_device *pdev)
>
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "QuadSPI-memory");
> - q->ahb_addr = devm_ioremap_resource(dev, res);
> + q->memmap_phy = res->start;
> + /* Since there are 4 cs, map size required is 4 times ahb_buf_size */
> + q->ahb_addr = devm_ioremap(dev, q->memmap_phy,
> + (q->devtype_data->ahb_buf_size * 4));
> if (IS_ERR(q->ahb_addr)) {
> ret = PTR_ERR(q->ahb_addr);
> goto err_put_ctrl;
> }
>
> - q->memmap_phy = res->start;
> -
Looks like this line move is unrelated to the ioremap range change. Not
a big but I thought I'd mention it. In any case,
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> /* find the clocks */
> q->clk_en = devm_clk_get(dev, "qspi_en");
> if (IS_ERR(q->clk_en)) {
next prev parent reply other threads:[~2020-04-16 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 11:43 [PATCH v3] spi: spi-fsl-qspi: Reduce devm_ioremap size to 4 times AHB buffer size Ashish Kumar
2020-04-16 12:04 ` Schrempf Frieder
2020-04-16 12:06 ` Boris Brezillon [this message]
2020-04-16 15:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416140604.3d8c9d78@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=Ashish.Kumar@nxp.com \
--cc=broonie@kernel.org \
--cc=frieder.schrempf@kontron.de \
--cc=kuldeep.singh@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).