From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6FE7CA90AF for ; Wed, 13 May 2020 11:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D154320769 for ; Wed, 13 May 2020 11:04:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730064AbgEMLEM (ORCPT ); Wed, 13 May 2020 07:04:12 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:57410 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729893AbgEMLEM (ORCPT ); Wed, 13 May 2020 07:04:12 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 64084803087C; Wed, 13 May 2020 11:04:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O1ivolSjJlIp; Wed, 13 May 2020 14:04:08 +0300 (MSK) Date: Wed, 13 May 2020 14:04:07 +0300 From: Serge Semin To: Mark Brown CC: Serge Semin , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Maxim Kaurkin , Pavel Parkhomenko , Ekaterina Skachko , Vadim Vlasov , Alexey Kolotnikov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Arnd Bergmann , Allison Randal , Andy Shevchenko , Gareth Williams , Rob Herring , , , , Subject: Re: [PATCH 00/17] spi: dw: Add generic DW DMA controller support Message-ID: <20200513110407.uaosfxebsgnllsf4@mobilestation> References: <20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru> <20200508133336.GK4820@sirena.org.uk> <20200512200733.bdbbhkjkwjd5yzqq@mobilestation> <20200513102324.GB4803@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200513102324.GB4803@sirena.org.uk> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Wed, May 13, 2020 at 11:23:24AM +0100, Mark Brown wrote: > On Tue, May 12, 2020 at 11:07:33PM +0300, Serge Semin wrote: > > On Fri, May 08, 2020 at 02:33:36PM +0100, Mark Brown wrote: > > > > Please don't make new feature development dependent on conversion to the > > > new schema format, there's quite a backlog of reviews of schema > > > conversions so it can slow things down. It's good to do the conversions > > > but please do them after adding any new stuff to the binding rather than > > > before. > > > So by saying this do you want me to revert an order of the first two patches > > in the series, right? So the series would first add the DMA properties support > > to the binding, then would convert the binding file to DT schema. > > The conversion to YAML format should be the very last thing in the patch > series, Hm, haven't heard about this requirement. Could you point me out to a doc or some discussion concerning this for future reference? It's not a first DT conversion patch I've submitted and non of them were addressed with such request. I do understand that the order of DT concerning patches can be important and agree to fix it by updating the original legacy binding first, then perform a conversion. But placing the conversion in a tail of the series just seems unnecessary. The patch can be dropped from any place of the series if for some reason Rob would be late with review. Personally I prefer placing all DT changes in the head of the series, so Rob wouldn't need to search through the whole patchset looking for the DT-related patches. -Sergey > and as Andy says there's another patch in flight also doing this > conversion which you should coordinate with.