From: Lubomir Rintel <lkundrak@v3.sk>
To: Rob Herring <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-media@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org,
linux-spi@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 24/28] dt-bindings: media: Convert marvell,mmp2-ccic to json-schema
Date: Sun, 17 May 2020 21:21:10 +0200 [thread overview]
Message-ID: <20200517192110.GD1695525@furthur.local> (raw)
In-Reply-To: <20200327194637.GA18803@bogus>
On Fri, Mar 27, 2020 at 01:46:37PM -0600, Rob Herring wrote:
> On Tue, Mar 17, 2020 at 10:39:18AM +0100, Lubomir Rintel wrote:
> > Convert the marvell,mmp2-ccic binding to DT schema format using
> > json-schema.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> > .../bindings/media/marvell,mmp2-ccic.txt | 50 ---------
> > .../bindings/media/marvell,mmp2-ccic.yaml | 102 ++++++++++++++++++
> > 2 files changed, 102 insertions(+), 50 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> > create mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> > deleted file mode 100644
> > index 7ec2c8c8a3b98..0000000000000
> > --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> > +++ /dev/null
> > @@ -1,50 +0,0 @@
> > -Marvell MMP2 camera host interface
> > -
> > -Required properties:
> > - - compatible: Should be "marvell,mmp2-ccic".
> > - - reg: Register base and size.
> > - - interrupts: The interrupt number.
> > - - #clock-cells: Must be 0.
> > -
> > -Optional properties:
> > - - clocks: Reference to the input clock as specified by
> > - Documentation/devicetree/bindings/clock/clock-bindings.txt.
> > - - clock-names: Names of the clocks used; "axi" for the AXI bus interface,
> > - "func" for the peripheral clock and "phy" for the parallel
> > - video bus interface.
> > - - clock-output-names: Optional clock source for sensors. Shall be "mclk".
> > -
> > -Required subnodes:
> > - - port: The parallel bus interface port with a single endpoint linked to
> > - the sensor's endpoint as described in
> > - Documentation/devicetree/bindings/media/video-interfaces.txt.
> > -
> > -Required endpoint properties:
> > - - bus-type: data bus type, <5> or <6> for Parallel or Bt.656 respectively
> > - - pclk-sample: pixel clock polarity
> > - - hsync-active: horizontal synchronization polarity (only required for
> > - parallel bus)
> > - - vsync-active: vertical synchronization polarity (only required for
> > - parallel bus)
> > -
> > -Example:
> > -
> > - camera0: camera@d420a000 {
> > - compatible = "marvell,mmp2-ccic";
> > - reg = <0xd420a000 0x800>;
> > - interrupts = <42>;
> > - clocks = <&soc_clocks MMP2_CLK_CCIC0>;
> > - clock-names = "axi";
> > - #clock-cells = <0>;
> > - clock-output-names = "mclk";
> > -
> > - port {
> > - camera0_0: endpoint {
> > - remote-endpoint = <&ov7670_0>;
> > - bus-type = <5>; /* Parallel */
> > - hsync-active = <1>; /* Active high */
> > - vsync-active = <1>; /* Active high */
> > - pclk-sample = <0>; /* Falling */
> > - };
> > - };
> > - };
> > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > new file mode 100644
> > index 0000000000000..890a3f9d0302f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > @@ -0,0 +1,102 @@
> > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
>
> GPL-2.0-only please. Dual license only if you have rights on the old
> file to do so.
I do. I wrote the original binding file.
> > +# Copyright 2019,2020 Lubomir Rintel <lkundrak@v3.sk>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/marvell,mmp2-ccic.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell MMP2 camera host interface bindings
> > +
> > +maintainers:
> > + - Lubomir Rintel <lkundrak@v3.sk>
> > +
> > +properties:
> > + $nodename:
> > + pattern: '^camera@[a-f0-9]+$'
> > +
> > + compatible:
> > + const: marvell,mmp2-ccic
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + port:
> > + type: object
> > + additionalProperties: false
> > +
> > + properties:
> > + endpoint:
>
> Wrong indentaion.
>
> > + type: object
> > + additionalProperties: false
> > +
> > + # Properties described in
> > + # Documentation/devicetree/bindings/media/video-interfaces.txt
> > + properties:
> > + remote-endpoint: true
> > + hsync-active: true
> > + vsync-active: true
> > + pclk-sample: true
> > + bus-type: true
> > +
> > + required:
> > + - remote-endpoint
> > +
> > + required:
> > + - endpoint
> > +
> > + clocks:
> > + minItems: 1
> > + maxItems: 3
>
> Shouldn't really be variable for a single compatible.
>
> > + items:
> > + - description: AXI bus interface clock
> > + - description: Peripheral clock
> > + - description: Parallel video bus interface clock
> > +
> > + clock-names:
> > + minItems: 1
> > + maxItems: 3
> > + items:
> > + - const: axi
> > + - const: func
> > + - const: phy
> > +
> > + '#clock-cells':
> > + const: 0
> > +
> > + clock-output-names:
> > + const: mclk
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - port
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/marvell,mmp2.h>
> > +
> > + camera@d420a000 {
> > + compatible = "marvell,mmp2-ccic";
> > + reg = <0xd420a000 0x800>;
> > + interrupts = <42>;
> > + clocks = <&soc_clocks MMP2_CLK_CCIC0>;
> > + clock-names = "axi";
> > + #clock-cells = <0>;
> > + clock-output-names = "mclk";
> > +
> > + port {
> > + camera0_0: endpoint {
> > + remote-endpoint = <&ov7670_0>;
> > + bus-type = <5>; /* Parallel */
> > + hsync-active = <1>; /* Active high */
> > + vsync-active = <1>; /* Active high */
> > + pclk-sample = <0>; /* Falling */
> > + };
> > + };
> > + };
> > +
> > +...
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2020-05-17 19:21 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
2020-03-17 9:38 ` [PATCH 01/28] ARM: dts: kirkwood: Fix interrupt controller node name Lubomir Rintel
[not found] ` <20200317093922.20785-2-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-17 13:20 ` Andrew Lunn
2020-03-17 9:39 ` [PATCH 08/28] ARM: dts: mmp*: Fix up encoding of the /rtc interrupts property Lubomir Rintel
[not found] ` <20200317093922.20785-9-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-17 13:30 ` Andrew Lunn
2020-03-17 13:30 ` Andrew Lunn
2020-03-17 9:39 ` [PATCH 10/28] ARM: dts: mmp3: fix USB & USB PHY node names Lubomir Rintel
2020-03-17 13:32 ` Andrew Lunn
2020-03-17 9:39 ` [PATCH 11/28] ARM: dts: berlin*: Fix up the SDHCI " Lubomir Rintel
2020-03-17 13:34 ` Andrew Lunn
2020-03-17 9:39 ` [PATCH 12/28] spi: dt-bindings: spi-controller: Slaves have no address cells Lubomir Rintel
[not found] ` <20200317093922.20785-13-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-19 16:51 ` Rob Herring
2020-03-17 9:39 ` [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to 8250 binding doc Lubomir Rintel
2020-03-17 13:48 ` Andrew Lunn
2020-03-17 19:09 ` Lubomir Rintel
2020-03-19 16:09 ` Rob Herring
[not found] ` <20200317093922.20785-14-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-19 16:11 ` Rob Herring
2020-03-20 9:24 ` Lubomir Rintel
2020-03-17 9:39 ` [PATCH 14/28] dt-bindings: arm: l2x0: Tauros 3 is PL310 compatible Lubomir Rintel
2020-03-27 19:03 ` Rob Herring
2020-03-27 19:04 ` Rob Herring
2020-03-17 9:39 ` [PATCH 15/28] dt-bindings: arm: mrvl: Add missing compatible strings Lubomir Rintel
2020-03-17 13:54 ` Andrew Lunn
2020-03-27 19:06 ` Rob Herring
2020-03-17 9:39 ` [PATCH 16/28] dt-bindings: Add "mrvl", a legacy vendor prefix for Marvell Lubomir Rintel
2020-03-27 19:06 ` Rob Herring
[not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-17 9:38 ` [PATCH 02/28] ARM: dts: dove: Fix interrupt controller node name Lubomir Rintel
2020-03-17 13:20 ` Andrew Lunn
2020-03-17 9:38 ` [PATCH 03/28] ARM: dts: pxa168: Add missing address/size cells to i2c nodes Lubomir Rintel
[not found] ` <20200317093922.20785-4-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-17 13:21 ` Andrew Lunn
2020-03-17 9:38 ` [PATCH 04/28] ARM: dts: pxa168: Fix the gpio interrupt cell number Lubomir Rintel
2020-03-17 13:27 ` Andrew Lunn
2020-03-17 9:38 ` [PATCH 05/28] ARM: dts: pxa3xx: Fix up encoding of the /gpio interrupts property Lubomir Rintel
[not found] ` <20200317093922.20785-6-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-17 13:28 ` Andrew Lunn
2020-03-21 7:36 ` Robert Jarzmik
2020-03-17 9:39 ` [PATCH 06/28] ARM: dts: pxa910: Fix the gpio interrupt cell number Lubomir Rintel
2020-03-17 13:29 ` Andrew Lunn
2020-03-17 9:39 ` [PATCH 07/28] ARM: dts: pxa*: Fix up encoding of the /rtc interrupts property Lubomir Rintel
2020-03-17 13:29 ` Andrew Lunn
2020-03-17 9:39 ` [PATCH 09/28] ARM: dts: mmp3: fix L2 cache controller node name Lubomir Rintel
2020-03-17 13:31 ` Andrew Lunn
2020-03-17 9:39 ` [PATCH 17/28] dt-bindings: mmc: Fix up clk-phase-sd-hs in an example Lubomir Rintel
2020-03-17 10:04 ` Sergei Shtylyov
2020-03-27 19:08 ` Rob Herring
2020-03-17 9:39 ` [PATCH 20/28] dt-bindings: phy: Convert phy-mmp3-usb to json-schema Lubomir Rintel
2020-03-27 19:09 ` Rob Herring
2020-03-17 9:39 ` [PATCH 22/28] dt-bindings: i2c: Convert i2c-pxa " Lubomir Rintel
2020-06-03 20:41 ` Wolfram Sang
2020-03-17 13:19 ` [PATCH 00/28] DT: Improve validation for Marvell SoCs Mark Brown
2020-03-17 9:39 ` [PATCH 18/28] dt-bindings: mmc: Fix node name in an example Lubomir Rintel
2020-03-26 14:28 ` Ulf Hansson
2020-03-17 9:39 ` [PATCH 19/28] dt-bindings: mmc: Convert sdhci-pxa to json-schema Lubomir Rintel
2020-03-18 22:14 ` Rob Herring
2020-03-18 22:37 ` Rob Herring
2020-05-17 18:35 ` Lubomir Rintel
2020-03-17 9:39 ` [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio " Lubomir Rintel
2020-03-27 10:04 ` Linus Walleij
2020-03-27 19:29 ` Rob Herring
2020-03-27 19:28 ` Rob Herring
2020-05-17 19:00 ` Lubomir Rintel
2020-03-17 9:39 ` [PATCH 23/28] dt-bindings: interrupt-controller: Convert mrvl,intc " Lubomir Rintel
2020-03-27 19:42 ` Rob Herring
2020-05-17 19:11 ` Lubomir Rintel
2020-03-17 9:39 ` [PATCH 24/28] dt-bindings: media: Convert marvell,mmp2-ccic " Lubomir Rintel
2020-03-27 19:46 ` Rob Herring
2020-05-17 19:21 ` Lubomir Rintel [this message]
2020-03-17 9:39 ` [PATCH 25/28] dt-bindings: rtc: Convert sa1100-rtc " Lubomir Rintel
2020-03-27 19:49 ` Rob Herring
2020-05-17 19:25 ` Lubomir Rintel
2020-05-18 15:12 ` Rob Herring
2020-03-17 9:39 ` [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx " Lubomir Rintel
2020-03-27 19:52 ` Rob Herring
2020-05-17 19:30 ` Lubomir Rintel
2020-03-17 9:39 ` [PATCH 27/28] dt-bindings: timer: Convert mrvl,mmp-timer " Lubomir Rintel
2020-03-27 19:53 ` Rob Herring
2020-03-17 9:39 ` [PATCH 28/28] dt-bindings: usb: Convert ehci-mv " Lubomir Rintel
2020-03-27 19:55 ` Rob Herring
2020-05-17 19:34 ` Lubomir Rintel
2020-05-18 15:20 ` Rob Herring
2020-03-17 13:46 ` [PATCH 00/28] DT: Improve validation for Marvell SoCs Andrew Lunn
[not found] ` <20200317134609.GN24270-g2DYL2Zd6BY@public.gmane.org>
2020-03-17 13:55 ` Alexandre Belloni
[not found] ` <20200317135551.GE3448-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2020-03-17 13:59 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200517192110.GD1695525@furthur.local \
--to=lkundrak@v3.sk \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=haojian.zhuang@gmail.com \
--cc=jason@lakedaemon.net \
--cc=kishon@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mchehab@kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).