From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A66ABC433E0 for ; Sun, 17 May 2020 19:26:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 924F7207C4 for ; Sun, 17 May 2020 19:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbgEQT0D (ORCPT ); Sun, 17 May 2020 15:26:03 -0400 Received: from v6.sk ([167.172.42.174]:56938 "EHLO v6.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbgEQT0C (ORCPT ); Sun, 17 May 2020 15:26:02 -0400 Received: from localhost (v6.sk [IPv6:::1]) by v6.sk (Postfix) with ESMTP id F14B6610A8; Sun, 17 May 2020 19:25:58 +0000 (UTC) Date: Sun, 17 May 2020 21:25:57 +0200 From: Lubomir Rintel To: Rob Herring Cc: Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mauro Carvalho Chehab , Ulf Hansson , Kishon Vijay Abraham I , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Mark Brown , Daniel Lezcano , Andrew Lunn , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 25/28] dt-bindings: rtc: Convert sa1100-rtc to json-schema Message-ID: <20200517192557.GE1695525@furthur.local> References: <20200317093922.20785-1-lkundrak@v3.sk> <20200317093922.20785-26-lkundrak@v3.sk> <20200327194902.GA24914@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200327194902.GA24914@bogus> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Fri, Mar 27, 2020 at 01:49:02PM -0600, Rob Herring wrote: > On Tue, Mar 17, 2020 at 10:39:19AM +0100, Lubomir Rintel wrote: > > Convert the sa1100-rtc binding to DT schema format using json-schema. > > > > Signed-off-by: Lubomir Rintel > > --- > > .../devicetree/bindings/rtc/sa1100-rtc.txt | 17 ------ > > .../devicetree/bindings/rtc/sa1100-rtc.yaml | 55 +++++++++++++++++++ > > 2 files changed, 55 insertions(+), 17 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/rtc/sa1100-rtc.txt > > create mode 100644 Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml > > > > diff --git a/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt b/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt > > deleted file mode 100644 > > index 968ac820254bb..0000000000000 > > --- a/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt > > +++ /dev/null > > @@ -1,17 +0,0 @@ > > -* Marvell Real Time Clock controller > > - > > -Required properties: > > -- compatible: should be "mrvl,sa1100-rtc" > > -- reg: physical base address of the controller and length of memory mapped > > - region. > > -- interrupts: Should be two. The first interrupt number is the rtc alarm > > - interrupt and the second interrupt number is the rtc hz interrupt. > > -- interrupt-names: Assign name of irq resource. > > - > > -Example: > > - rtc: rtc@d4010000 { > > - compatible = "mrvl,mmp-rtc"; > > - reg = <0xd4010000 0x1000>; > > - interrupts = <5>, <6>; > > - interrupt-names = "rtc 1Hz", "rtc alarm"; > > - }; > > diff --git a/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml b/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml > > new file mode 100644 > > index 0000000000000..53a8b72df9f34 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml > > @@ -0,0 +1,55 @@ > > License The original file lacked one. Should I just go with GPL-2.0? > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/rtc/sa1100-rtc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Marvell Real Time Clock controller bindings > > + > > +allOf: > > + - $ref: rtc.yaml# > > + > > +maintainers: > > + - devicetree@vger.kernel.org > > Real person It's not clear who would that be. > > + > > +properties: > > + compatible: > > + enum: > > + - mrvl,sa1100-rtc > > + - mrvl,mmp-rtc > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + resets: > > + maxItems: 1 > > clocks and resets weren't documented before. Fine to add here, but add > that to the commit msg. > > > + > > + interrupts: > > + minItems: 2 > > + maxItems: 2 > > Drop minItems. It needs to be exactly 2. I suppose for that I should drop maxItems instead? > > + > > + interrupt-names: > > + items: > > + - const: 'rtc 1Hz' > > + - const: 'rtc alarm' > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - interrupt-names > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + rtc: rtc@d4010000 { > > + compatible = "mrvl,mmp-rtc"; > > + reg = <0xd4010000 0x1000>; > > + interrupts = <5>, <6>; > > + interrupt-names = "rtc 1Hz", "rtc alarm"; > > + }; > > + > > +... > > -- > > 2.25.1 > >