From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Rob Herring <robh@kernel.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Mark Brown <broonie@kernel.org>,
Ramil Zaripov <Ramil.Zaripov@baikalelectronics.ru>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Burton <paulburton@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
John Garry <john.garry@huawei.com>,
Chuanhong Guo <gch981213@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Arnd Bergmann <arnd@arndb.de>, <linux-mips@vger.kernel.org>,
<linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: spi: Add Baikal-T1 System Boot SPI Controller binding
Date: Tue, 19 May 2020 00:27:03 +0300 [thread overview]
Message-ID: <20200518212703.vju456kd3telctux@mobilestation> (raw)
In-Reply-To: <20200518152659.GA2525@bogus>
On Mon, May 18, 2020 at 09:26:59AM -0600, Rob Herring wrote:
> On Fri, May 08, 2020 at 12:36:20PM +0300, Serge Semin wrote:
> > Baikal-T1 Boot SPI is a part of the SoC System Controller and is
> > responsible for the system bootup from an external SPI flash. It's a DW
> > APB SSI-based SPI-controller with no interrupts, no DMA, with just one
> > native chip-select available and a single reference clock. Since Baikal-T1
> > SoC is normally booted up from an external SPI flash this SPI controller
> > in most of the cases is supposed to be connected to a single SPI-nor
> > flash. Additionally in order to provide a transparent from CPU point of
> > view initial code execution procedure the system designers created an IP
> > block which physically maps the SPI flash found at CS0 to a memory region.
> >
> > Co-developed-by: Ramil Zaripov <Ramil.Zaripov@baikalelectronics.ru>
> > Signed-off-by: Ramil Zaripov <Ramil.Zaripov@baikalelectronics.ru>
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > Cc: Paul Burton <paulburton@kernel.org>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Cc: John Garry <john.garry@huawei.com>
> > Cc: Chuanhong Guo <gch981213@gmail.com>
> > Cc: Tomer Maimon <tmaimon77@gmail.com>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: linux-mips@vger.kernel.org
> > Cc: linux-spi@vger.kernel.org
> > ---
> > .../bindings/spi/baikal,bt1-sys-ssi.yaml | 100 ++++++++++++++++++
> > 1 file changed, 100 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/spi/baikal,bt1-sys-ssi.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/spi/baikal,bt1-sys-ssi.yaml b/Documentation/devicetree/bindings/spi/baikal,bt1-sys-ssi.yaml
> > new file mode 100644
> > index 000000000000..d9d3257d78f4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/baikal,bt1-sys-ssi.yaml
> > @@ -0,0 +1,100 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (C) 2020 BAIKAL ELECTRONICS, JSC
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/spi/baikal,bt1-sys-ssi.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Baikal-T1 System Boot SSI Controller
> > +
> > +description: |
> > + Baikal-T1 System Controller includes a Boot SPI Controller, which is
> > + responsible for loading chip bootup code from an external SPI flash. In order
> > + to do this transparently from CPU point of view there is a dedicated IP block
> > + mapping the 16MB flash to a dedicated MMIO range. The controller is based on
> > + the DW APB SSI IP-core but equipped with very limited resources: no IRQ,
> > + no DMA, a single native CS being necessarily connected to a 16MB SPI flash
> > + (otherwise the system won't bootup from the flash), internal Tx/Rx FIFO of
> > + just 8 bytes depth. Access to DW APB SSI controller registers is mutually
> > + exclusive from normal MMIO interface and from physically mapped SPI Flash
> > + memory. So either one or another way of using the controller functionality
> > + can be enabled at a time.
> > +
> > +maintainers:
> > + - Serge Semin <fancer.lancer@gmail.com>
> > +
> > +allOf:
> > + - $ref: spi-controller.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: baikal,bt1-sys-ssi
> > +
> > + reg:
> > + items:
> > + - description: Baikal-T1 Boot Controller configuration registers
> > + - description: Physically mapped SPI flash ROM found at CS0
> > +
> > + reg-names:
> > + items:
> > + - const: config
> > + - const: map
> > +
> > + clocks:
> > + description: SPI Controller reference clock source
>
> Can drop this.
Ok.
>
> > + maxItems: 1
> > +
> > + clock-names:
> > + items:
> > + - const: ssi_clk
> > +
> > + num-cs:
> > + const: 1
> > +
> > +patternProperties:
> > + "^.*@[0-9a-f]+":
> > + type: object
> > + properties:
> > + reg:
> > + minimum: 0
> > + maximum: 0
> > +
> > + spi-rx-bus-width:
> > + const: 1
> > +
> > + spi-tx-bus-width:
> > + const: 1
>
> What's the point of these 2 properties if they aren't required?
Yes, they are optional, but this is a constraint on the bus-width parameters.
DW APB SSI provides a single laned Tx and Rx.
>
> > +
> > +unevaluatedProperties: false
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - reg-names
>
> > + - "#address-cells"
> > + - "#size-cells"
>
> These 2 are required by spi-controller.yaml, so you can drop here.
Yes, "#address-cells" is required, but "#size-cells" isn't. Is this supposed to
be like that?
-Sergey
>
> > + - clocks
> > +
> > +examples:
> > + - |
> > + spi@1f040000 {
> > + compatible = "baikal,bt1-sys-ssi";
> > + reg = <0x1f040000 0x1000>,
> > + <0x1c000000 0x1000000>;
> > + reg-names = "config", "map";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + clocks = <&ccu_sys>;
> > + clock-names = "ssi_clk";
> > +
> > + boot_flash: flash@0 {
> > + compatible = "jedec,spi-nor";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + reg = <0>;
> > +
> > + spi-max-frequency = <25000000>;
> > + };
> > + };
> > +...
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2020-05-18 21:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 9:36 [PATCH 0/2] spi: Add Baikal-T1 System Boot SPI Controller driver Serge Semin
2020-05-08 9:36 ` [PATCH 1/2] dt-bindings: spi: Add Baikal-T1 System Boot SPI Controller binding Serge Semin
2020-05-18 15:26 ` Rob Herring
2020-05-18 21:27 ` Serge Semin [this message]
2020-05-21 14:57 ` Rob Herring
2020-05-21 15:11 ` Serge Semin
2020-05-21 21:35 ` Rob Herring
2020-05-18 21:55 ` Serge Semin
2020-05-08 9:36 ` [PATCH 2/2] spi: Add Baikal-T1 System Boot SPI Controller driver Serge Semin
2020-05-08 10:03 ` Andy Shevchenko
2020-05-08 10:15 ` Serge Semin
2020-05-08 10:22 ` Mark Brown
2020-05-08 15:42 ` Serge Semin
2020-05-08 17:07 ` Mark Brown
2020-05-08 10:26 ` Andy Shevchenko
2020-05-08 16:24 ` Serge Semin
2020-05-08 11:37 ` Mark Brown
2020-05-10 0:20 ` Serge Semin
2020-05-10 22:17 ` Chris Packham
2020-05-11 21:25 ` Mark Brown
2020-05-18 0:05 ` Serge Semin
2020-05-18 15:19 ` Mark Brown
2020-05-18 21:17 ` Serge Semin
2020-05-19 10:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518212703.vju456kd3telctux@mobilestation \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Ramil.Zaripov@baikalelectronics.ru \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gch981213@gmail.com \
--cc=john.garry@huawei.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh@kernel.org \
--cc=tmaimon77@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).