From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C2FC433E0 for ; Thu, 21 May 2020 15:51:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 701FA20748 for ; Thu, 21 May 2020 15:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590076309; bh=mO0PzgDMdpQ32+Tp34GeQLw4brmQwyU7HhvPc3aXfRc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=UDVMaJx/VhkQpBpLk0uxy6HLRe2hDnZeJS5SbryD6vLibTG/HMPMkJWBqRKoZtoyB 3TIJsyJj9eAigVY0Q4bGDvuIe79+6RCeYBd/y4VEcMgZfuGF4h0HB5ljkm3mx56XyF LrFeuvF2kniFU0SH438Oqj5hhAvB6wZhrdd5Kaf4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727941AbgEUPvr (ORCPT ); Thu, 21 May 2020 11:51:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:42222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726814AbgEUPvq (ORCPT ); Thu, 21 May 2020 11:51:46 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E5C7206F6; Thu, 21 May 2020 15:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590076306; bh=mO0PzgDMdpQ32+Tp34GeQLw4brmQwyU7HhvPc3aXfRc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yB9mC01ohdIgpEdwUtfCboqeKzlvDlz3L1WEsOyI/5TSYkGjP5dxxtcvEVObFbTdn ciBuprt1AS/qB1bOWmpGsXRwzfnorXUw/X9fOmqrqTFcAQxvK1wWKM7BwqVL70cmjx DBxceZD7Ojt4PP+Tlpj7ukfiuraFYVmV/3PM4kxw= Date: Thu, 21 May 2020 16:51:43 +0100 From: Mark Brown To: Serge Semin Cc: Andy Shevchenko , Serge Semin , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Andy Shevchenko , Arnd Bergmann , Rob Herring , linux-mips@vger.kernel.org, devicetree , Thomas Gleixner , Wan Ahmad Zainie , Jarkko Nikula , Clement Leger , linux-spi , Linux Kernel Mailing List Subject: Re: [PATCH v3 03/16] spi: dw: Discard static DW DMA slave structures Message-ID: <20200521155143.GE4770@sirena.org.uk> References: <20200521012206.14472-1-Sergey.Semin@baikalelectronics.ru> <20200521012206.14472-4-Sergey.Semin@baikalelectronics.ru> <20200521121228.aqplh6eftylnys3p@mobilestation> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Q8BnQc91gJZX4vDc" Content-Disposition: inline In-Reply-To: <20200521121228.aqplh6eftylnys3p@mobilestation> X-Cookie: Keep your laws off my body! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org --Q8BnQc91gJZX4vDc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 21, 2020 at 03:12:28PM +0300, Serge Semin wrote: > Well, for me both solutions are equal except mine consumes less stack memory. > The only reason why your solution might be better is that if DW DMA driver or > the DMA engine subsystem changed the dw_dma_slave structure instance passed to > the dma_request_channel() method, which non of them do. So I'll leave this for > Mark to decide. Mark, could you give us your final word about this? Honestly I'm struggling to care either way. I guess saving a bit of stack is potentially useful. --Q8BnQc91gJZX4vDc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7Go44ACgkQJNaLcl1U h9ARkgf+MntLj5Do0nvBWAqICSlgK/Xn8rMj1fR5eJDBdfgclFhZsPYUHPbZHr6I /U2aWUFEslX7Gq/QAu2JNA+uYp3p798aYv1u/h+Ss858qzbkBsRWNVAVFzNph0Dk qiruZrmFMuDqF0O/ofqHI4yiOqlJnT4KixjR7tKDoHlW4IxXrsHCCR6mAFmunYpY 5XEIolhWrMiP6dN5vmAMwRt6My2zESwY3of8eW2lApg0n6tR2SFnWz5++CR7K04b TO73tMeXtI1lBogjeYz7iuC0joI16cg5aaDq5Lt6lMdbK6qhH5ZLjAynCRQLKE4C F/qLatJ9ve0BIC069lF4Tznzsq8NIg== =1v3o -----END PGP SIGNATURE----- --Q8BnQc91gJZX4vDc--