From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56232C433E0 for ; Thu, 21 May 2020 15:58:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34FDD20826 for ; Thu, 21 May 2020 15:58:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728339AbgEUP6K (ORCPT ); Thu, 21 May 2020 11:58:10 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:39322 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727968AbgEUP6J (ORCPT ); Thu, 21 May 2020 11:58:09 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 411AD803087B; Thu, 21 May 2020 15:58:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qtAkUXH4Z9NM; Thu, 21 May 2020 18:58:05 +0300 (MSK) Date: Thu, 21 May 2020 18:58:04 +0300 From: Serge Semin To: Mark Brown CC: Serge Semin , Andy Shevchenko , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Andy Shevchenko , Arnd Bergmann , Rob Herring , , devicetree , Thomas Gleixner , Wan Ahmad Zainie , Jarkko Nikula , Clement Leger , linux-spi , Linux Kernel Mailing List Subject: Re: [PATCH v3 03/16] spi: dw: Discard static DW DMA slave structures Message-ID: <20200521155804.qgaaqc23h2nll7r3@mobilestation> References: <20200521012206.14472-1-Sergey.Semin@baikalelectronics.ru> <20200521012206.14472-4-Sergey.Semin@baikalelectronics.ru> <20200521121228.aqplh6eftylnys3p@mobilestation> <20200521155143.GE4770@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200521155143.GE4770@sirena.org.uk> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Thu, May 21, 2020 at 04:51:43PM +0100, Mark Brown wrote: > On Thu, May 21, 2020 at 03:12:28PM +0300, Serge Semin wrote: > > > Well, for me both solutions are equal except mine consumes less stack memory. > > The only reason why your solution might be better is that if DW DMA driver or > > the DMA engine subsystem changed the dw_dma_slave structure instance passed to > > the dma_request_channel() method, which non of them do. So I'll leave this for > > Mark to decide. Mark, could you give us your final word about this? > > Honestly I'm struggling to care either way. I guess saving a bit of > stack is potentially useful. Settled then. Let's leave the patch as is. I suppose we've finally finished a review except a question Feng asked to the patch: [PATCH v3 01/16] spi: dw: Add Tx/Rx finish wait methods to the MID DMA If you are ok with my responses, then the patchset is ready for you further actions. -Sergey