From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D59C0C433E1 for ; Fri, 22 May 2020 11:07:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF6B7206B6 for ; Fri, 22 May 2020 11:07:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729034AbgEVLHm (ORCPT ); Fri, 22 May 2020 07:07:42 -0400 Received: from mga06.intel.com ([134.134.136.31]:53504 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728281AbgEVLHl (ORCPT ); Fri, 22 May 2020 07:07:41 -0400 IronPort-SDR: CmdHAY6W1HLB/zjzYcaJ7ckUD92W4TFQpY0wsE1E1R+QlbYxzBuzdxqLzs1O8FUk8K/hRrWloP XtPtkZf20jOQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2020 04:07:40 -0700 IronPort-SDR: Z2zqdpxfd8/g00epIfPGpigaTa+qxHKoNiRQBqNKxGV4N6uOKh0iwJfi0J9xJbBwZsRRKx++3+ ByVCGDiH1yiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,421,1583222400"; d="scan'208";a="255567112" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga008.fm.intel.com with ESMTP; 22 May 2020 04:07:35 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jc5Wc-008DYn-7B; Fri, 22 May 2020 14:07:38 +0300 Date: Fri, 22 May 2020 14:07:38 +0300 From: Andy Shevchenko To: Serge Semin Cc: Mark Brown , Serge Semin , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Arnd Bergmann , Rob Herring , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, John Garry , Chuanhong Guo , Joe Perches , Chris Packham , Tomer Maimon , Masahisa Kojima , Krzysztof Kozlowski , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 12/16] spi: dw: Add DW SPI DMA/PCI/MMIO dependency on the DW SPI core Message-ID: <20200522110738.GV1634618@smile.fi.intel.com> References: <20200522000806.7381-1-Sergey.Semin@baikalelectronics.ru> <20200522000806.7381-13-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200522000806.7381-13-Sergey.Semin@baikalelectronics.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Fri, May 22, 2020 at 03:08:01AM +0300, Serge Semin wrote: > Seeing all of the DW SPI driver components like DW SPI DMA/PCI/MMIO > depend on the DW SPI core code it's better to use the if-endif > conditional kernel config statement to signify that common dependency. > > Co-developed-by: Georgy Vlasov > Signed-off-by: Georgy Vlasov > Co-developed-by: Ramil Zaripov > Signed-off-by: Ramil Zaripov > Signed-off-by: Serge Semin > Reviewed-by: Andy Shevchenko > Cc: Alexey Malahov > Cc: Thomas Bogendoerfer > Cc: Paul Burton > Cc: Ralf Baechle > Cc: Arnd Bergmann > Cc: Andy Shevchenko Here and for the future, when you add somebody's tag, drop their appearance in Cc. git-send-email automatically converts known tags to Cc. > Cc: Rob Herring > Cc: linux-mips@vger.kernel.org > Cc: devicetree@vger.kernel.org -- With Best Regards, Andy Shevchenko