From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
David Lechner <david@lechnology.com>
Subject: Re: [PATCH] spi: omap2-mcspi: Convert to use GPIO descriptors
Date: Mon, 29 Jun 2020 09:27:18 -0700 [thread overview]
Message-ID: <20200629162718.GP53169@atomide.com> (raw)
In-Reply-To: <20200625231257.280615-1-linus.walleij@linaro.org>
* Linus Walleij <linus.walleij@linaro.org> [200625 23:13]:
> The OMAP2 MCSPI has some kind of half-baked GPIO CS support:
> it includes code like this:
>
> if (gpio_is_valid(spi->cs_gpio)) {
> ret = gpio_request(spi->cs_gpio, dev_name(&spi->dev));
> (...)
>
> But it doesn't parse the "cs-gpios" attribute in the device
> tree to count the number of GPIOs or pick out the GPIO numbers
> and put these in the SPI master's .cs_gpios property.
>
> We complete the implementation of supporting CS GPIOs
> from the device tree and switch it over to use the SPI core
> for this.
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2020-06-29 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 23:12 [PATCH] spi: omap2-mcspi: Convert to use GPIO descriptors Linus Walleij
2020-06-29 16:27 ` Tony Lindgren [this message]
2020-06-29 19:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629162718.GP53169@atomide.com \
--to=tony@atomide.com \
--cc=broonie@kernel.org \
--cc=david@lechnology.com \
--cc=linus.walleij@linaro.org \
--cc=linux-spi@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).