From: Lee Jones <lee.jones@linaro.org>
To: broonie@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 11/14] spi: spi-topcliff-pch: Add missing descriptions to 'struct pch_spi_data'
Date: Wed, 15 Jul 2020 16:06:29 +0100 [thread overview]
Message-ID: <20200715150632.409077-12-lee.jones@linaro.org> (raw)
In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'io_base_addr' not described in 'pch_spi_data'
drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_tx_buff' not described in 'pch_spi_data'
drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_rx_buff' not described in 'pch_spi_data'
drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'dma' not described in 'pch_spi_data'
drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'use_dma' not described in 'pch_spi_data'
drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'save_total_len' not described in 'pch_spi_data'
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/spi/spi-topcliff-pch.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index d7ea6af74743e..baadd380cb297 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -122,6 +122,7 @@ struct pch_spi_dma_ctrl {
/**
* struct pch_spi_data - Holds the SPI channel specific details
* @io_remap_addr: The remapped PCI base address
+ * @io_base_addr: Base address
* @master: Pointer to the SPI master structure
* @work: Reference to work queue handler
* @wait: Wait queue for waking up upon receiving an
@@ -138,8 +139,8 @@ struct pch_spi_dma_ctrl {
* transfer
* @rx_index: Receive data count; for bookkeeping during
* transfer
- * @tx_buff: Buffer for data to be transmitted
- * @rx_index: Buffer for Received data
+ * @pkt_tx_buff: Buffer for data to be transmitted
+ * @pkt_rx_buff: Buffer for received data
* @n_curnt_chip: The chip number that this SPI driver currently
* operates on
* @current_chip: Reference to the current chip that this SPI
@@ -151,7 +152,10 @@ struct pch_spi_dma_ctrl {
* @board_dat: Reference to the SPI device data structure
* @plat_dev: platform_device structure
* @ch: SPI channel number
+ * @dma: Local DMA information
+ * @use_dma: True if DMA is to be used
* @irq_reg_sts: Status of IRQ registration
+ * @save_total_len: Save length while data is being transferred
*/
struct pch_spi_data {
void __iomem *io_remap_addr;
--
2.25.1
next prev parent reply other threads:[~2020-07-15 15:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 15:06 [PATCH 00/14] Rid W=1 warnings in SPI Lee Jones
2020-07-15 15:06 ` [PATCH 01/14] spi: spi-loopback-test: Fix formatting issues in function header blocks Lee Jones
2020-07-15 15:06 ` [PATCH 02/14] spi: spi-bitbang: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-15 15:06 ` [PATCH 03/14] spi: spi-davinci: Fix a few kerneldoc misspellings and API slippages Lee Jones
2020-07-15 15:06 ` [PATCH 04/14] spi: spi-ep93xx: Fix API slippage Lee Jones
2020-07-15 15:06 ` [PATCH 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc' Lee Jones
2020-07-15 15:06 ` [PATCH 06/14] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo() Lee Jones
2020-07-15 15:06 ` [PATCH 07/14] spi: spi-s3c64xx: Add missing entries for structs 's3c64xx_spi_dma_data' and 's3c64xx_spi_dma_data' Lee Jones
2020-07-15 15:06 ` [PATCH 08/14] spi: spi-pl022: Provide missing struct attribute/function param docs Lee Jones
2020-07-16 13:59 ` Linus Walleij
2020-07-15 15:06 ` [PATCH 09/14] spi: spi-zynq-qspi: Add description for 2 missing attributes/parameters Lee Jones
2020-07-16 7:19 ` Michal Simek
2020-07-15 15:06 ` [PATCH 10/14] spi: spi-zynqmp-gqspi: Correct a couple of misspellings in kerneldoc Lee Jones
2020-07-16 7:20 ` Michal Simek
2020-07-15 15:06 ` Lee Jones [this message]
2020-07-15 15:06 ` [PATCH 12/14] spi: spi-at91-usart: Make use of the defined 'struct of_device_id' Lee Jones
2020-07-15 21:24 ` Alexandre Belloni
2020-07-16 7:56 ` Lee Jones
2020-07-16 8:50 ` Alexandre Belloni
2020-07-15 15:06 ` [PATCH 13/14] spi: spi-pxa2xx: Do not define 'struct acpi_device_id' when Lee Jones
2020-07-15 15:06 ` [PATCH 14/14] spi: spi-amd: " Lee Jones
2020-07-20 11:12 ` [PATCH 00/14] Rid W=1 warnings in SPI Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715150632.409077-12-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).