From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1BB7C433E0 for ; Mon, 27 Jul 2020 13:48:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77AA92073E for ; Mon, 27 Jul 2020 13:48:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HGdOixIk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726841AbgG0NsO (ORCPT ); Mon, 27 Jul 2020 09:48:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726797AbgG0NsN (ORCPT ); Mon, 27 Jul 2020 09:48:13 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B464C061794; Mon, 27 Jul 2020 06:48:12 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id d1so8017272plr.8; Mon, 27 Jul 2020 06:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NJmzr2KQBRICuAu1pv5/YVfC3bftlzNt8R1cIWx8IbE=; b=HGdOixIk+LNjSWHZUK4ATkRjyLKVYX9VDXRfBVLTFUpwXDGNhSj4hugCezPW9Watsx DYgDZ6JCFTZY80+LajAIl6hG/xxGlUt9ZyUgDqUdpVo6rBJwHbLJeDk5vXNDNvNc5B2E zs0J2SZylYJf7qK0SlBtWgx5evTnK03U1hVPC5Xlyc09IDWm/VQ1utPmgy0u+xM9jmaJ f+rhR8xPr3nXDIjYoKPiKCn/sPnMg3KgmFHHQOyy1tIFj00YAkUPvg9klo5iDy87NOyA tG7CHXjSi62kGyMvl26Mtc/GCmB2hAWEpTAenN83BgOUn6hgIkZxa32MZ8DXzyZZiwMX lEKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NJmzr2KQBRICuAu1pv5/YVfC3bftlzNt8R1cIWx8IbE=; b=DPTRzQZjja9g0WBmK5GZPHdoAeh0OPaEci671ajPiY3viiSPo7+GYykYmZcIMVE6ET OBgc3/hXG4k/0w4NmO0i1QYJYBKM9BquRJImBlPbDJG619kG02zwheaPnxng0M1QaLpJ 7BaOlWSo8aNs8ObME5MJ32s6vgyuUnHq0GSWsYmx1piDErP51kP0iqcxK6J7YNxFxraL jM8YOrGFNJATs8Y5mXaqlYfR6athIHn9xlDBDlADuGG/2YsaZBUNuoa3vpo1E2vmAjLg sM3oqLUcjcOPYq5IHkyU2luqeX+EI8GGfmIrDfoSKzBs/qSE2hhGkFcWHmm8tK7btxQi 78Jg== X-Gm-Message-State: AOAM531HScepw2cHUOOfR6iUpY6RLws/lQhseMQvWvPWAEuUnrjlKY+z zDMaEbC21YSn60nCkj1lgEfE7yNUTLIrng== X-Google-Smtp-Source: ABdhPJymzaESRpyXHYliILrQeceM1V9MDg1bBV/LilZuHpXMR5G3RB1SERXvj8gZzKFTg+PWAatrsg== X-Received: by 2002:a17:90a:3fc7:: with SMTP id u7mr18805322pjm.231.1595857691850; Mon, 27 Jul 2020 06:48:11 -0700 (PDT) Received: from gmail.com ([103.105.152.86]) by smtp.gmail.com with ESMTPSA id f6sm2551521pfa.23.2020.07.27.06.48.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 06:48:11 -0700 (PDT) Date: Mon, 27 Jul 2020 19:16:46 +0530 From: Vaibhav Gupta To: Andy Shevchenko Cc: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Mark Brown , linux-spi , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan Subject: Re: [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable Message-ID: <20200727134646.GA114726@gmail.com> References: <20200727131742.82289-1-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Mon, Jul 27, 2020 at 04:38:40PM +0300, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 4:21 PM Vaibhav Gupta wrote: > > > > Before generic upgrade, both .suspend() and .resume() were invoking > > pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both > > states. (Normal trend is .suspend() enables and .resume() disables the > > wakeup.) > > > > This was ambiguous and may be buggy. Instead of replicating the legacy > > behavior, drop the wakeup-disable call. > > > > > Fix: f185bcc77980("spi: spi-topcliff-pch: use generic power management") > > Fixes: and missed space. > > Note: > > % grep one ~/.gitconfig > one = show -s --pretty='format:%h (\"%s\")' > > % git one f185bcc77980 > f185bcc77980 ("spi: spi-topcliff-pch: use generic power management") > > > Reported by: Andy Shevchenko > > Missed dash. > Does checkpatch complain? No, I got this message: "* .patch has no obvious style problems and is ready for submission" I will fix the commit message. Thanks! Vaibhav Gupta > > > Signed-off-by: Vaibhav Gupta > > --- > > drivers/spi/spi-topcliff-pch.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c > > index 281a90f1b5d8..c73a03ddf5f3 100644 > > --- a/drivers/spi/spi-topcliff-pch.c > > +++ b/drivers/spi/spi-topcliff-pch.c > > @@ -1648,8 +1648,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev) > > > > dev_dbg(dev, "%s ENTRY\n", __func__); > > > > - device_wakeup_disable(dev); > > - > > /* set suspend status to false */ > > pd_dev_save->board_dat->suspend_sts = false; > > > > -- > > 2.27.0 > > > > > -- > With Best Regards, > Andy Shevchenko