From: Allen Pais <allen.cryptic@gmail.com>
To: jdike@addtoit.com, richard@nod.at,
anton.ivanov@cambridgegreys.com, 3chas3@gmail.com,
axboe@kernel.dk, stefanr@s5r6.in-berlin.de, airlied@linux.ie,
daniel@ffwll.ch, sre@kernel.org,
James.Bottomley@HansenPartnership.com, kys@microsoft.com,
deller@gmx.de, dmitry.torokhov@gmail.com,
jassisinghbrar@gmail.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, maximlevitsky@gmail.com, oakad@yahoo.com,
ulf.hansson@linaro.org, mporter@kernel.crashing.org,
alex.bou9@gmail.com, broonie@kernel.org, martyn@welchs.me.uk,
manohar.vanga@gmail.com, mitch@sfgoth.com, davem@davemloft.net,
kuba@kernel.org
Cc: keescook@chromium.org, linux-um@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-block@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
openipmi-developer@lists.sourceforge.net,
linux1394-devel@lists.sourceforge.net,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-hyperv@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-input@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-ntb@googlegroups.com, linux-s390@vger.kernel.org,
linux-spi@vger.kernel.org, devel@driverdev.osuosl.org,
Allen Pais <allen.lkml@gmail.com>,
Romain Perier <romain.perier@gmail.com>
Subject: [PATCH] drivers: ntb: convert tasklets to use new tasklet_setup() API
Date: Mon, 17 Aug 2020 14:46:00 +0530 [thread overview]
Message-ID: <20200817091617.28119-6-allen.cryptic@gmail.com> (raw)
In-Reply-To: <20200817091617.28119-1-allen.cryptic@gmail.com>
From: Allen Pais <allen.lkml@gmail.com>
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
drivers/ntb/ntb_transport.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
index e6d1f5b298f3..ab3bee2fc803 100644
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -273,7 +273,7 @@ enum {
#define NTB_QP_DEF_NUM_ENTRIES 100
#define NTB_LINK_DOWN_TIMEOUT 10
-static void ntb_transport_rxc_db(unsigned long data);
+static void ntb_transport_rxc_db(struct tasklet_struct *t);
static const struct ntb_ctx_ops ntb_transport_ops;
static struct ntb_client ntb_transport_client;
static int ntb_async_tx_submit(struct ntb_transport_qp *qp,
@@ -1234,8 +1234,7 @@ static int ntb_transport_init_queue(struct ntb_transport_ctx *nt,
INIT_LIST_HEAD(&qp->rx_free_q);
INIT_LIST_HEAD(&qp->tx_free_q);
- tasklet_init(&qp->rxc_db_work, ntb_transport_rxc_db,
- (unsigned long)qp);
+ tasklet_setup(&qp->rxc_db_work, ntb_transport_rxc_db);
return 0;
}
@@ -1685,9 +1684,9 @@ static int ntb_process_rxc(struct ntb_transport_qp *qp)
return 0;
}
-static void ntb_transport_rxc_db(unsigned long data)
+static void ntb_transport_rxc_db(struct tasklet_struct *t)
{
- struct ntb_transport_qp *qp = (void *)data;
+ struct ntb_transport_qp *qp = from_tasklet(qp, t, rxc_db_work);
int rc, i;
dev_dbg(&qp->ndev->pdev->dev, "%s: doorbell %d received\n",
--
2.17.1
next prev parent reply other threads:[~2020-08-17 9:17 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:15 [PATCH] arch: um: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-17 9:15 ` [PATCH] block: " Allen Pais
2020-08-17 13:56 ` Jens Axboe
2020-08-17 19:29 ` Kees Cook
2020-08-17 19:44 ` Jens Axboe
2020-08-17 19:48 ` Kees Cook
2020-08-17 20:02 ` Jens Axboe
2020-08-18 20:00 ` James Bottomley
2020-08-18 20:10 ` Kees Cook
2020-08-18 21:00 ` James Bottomley
2020-08-19 10:48 ` Allen
2020-08-19 13:00 ` Jens Axboe
2020-08-19 13:11 ` Greg KH
2020-08-19 13:17 ` Jens Axboe
2020-08-19 13:30 ` Greg KH
2020-08-19 14:59 ` James Bottomley
2020-08-19 16:24 ` Allen
2020-08-19 16:56 ` Jens Axboe
2020-08-19 21:39 ` James Bottomley
2020-08-26 1:51 ` Allen Pais
2020-08-26 9:55 ` Dan Carpenter
2020-08-26 15:13 ` Kees Cook
2020-08-27 1:37 ` Allen
2020-08-17 9:15 ` [PATCH] char: ipmi: " Allen Pais
2020-08-17 12:15 ` Corey Minyard
2020-08-18 9:16 ` Allen
2020-08-18 11:32 ` Corey Minyard
2020-08-17 9:15 ` [PATCH] driver: hv: " Allen Pais
2020-08-17 9:15 ` [PATCH] drivers: atm: " Allen Pais
2020-08-17 9:16 ` Allen Pais [this message]
2020-08-17 9:16 ` [PATCH] drivers: rapidio: " Allen Pais
2020-08-17 9:16 ` [PATCH] drivers: s390: " Allen Pais
2020-08-17 9:16 ` [PATCH] drivers: vme: " Allen Pais
2020-08-17 9:16 ` [PATCH] drm: i915: " Allen Pais
2020-08-17 9:16 ` [PATCH] firewire: ohci: " Allen Pais
2020-08-17 9:16 ` [PATCH 1/2] hsi: nokia-modem: " Allen Pais
2020-08-17 9:16 ` [PATCH] input: serio: " Allen Pais
2020-08-17 9:16 ` [PATCH 1/2] mailbox: bcm: " Allen Pais
2020-08-17 9:16 ` [PATCH 1/2] memstick: jmb38x: " Allen Pais
2020-08-17 9:16 ` [PATCH 1/2] misc: ibmvmc: " Allen Pais
2020-08-17 9:16 ` [PATCH] net: atm: convert tasklets callbacks to use from_tasklet() Allen Pais
2020-08-17 9:16 ` [PATCH] platform: goldfish: convert tasklets to use new tasklet_setup() API Allen Pais
2020-10-18 21:50 ` [PATCH] arch: um: " Richard Weinberger
2020-10-19 7:39 ` Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817091617.28119-6-allen.cryptic@gmail.com \
--to=allen.cryptic@gmail.com \
--cc=3chas3@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=airlied@linux.ie \
--cc=alex.bou9@gmail.com \
--cc=allen.lkml@gmail.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jassisinghbrar@gmail.com \
--cc=jdike@addtoit.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=maximlevitsky@gmail.com \
--cc=mitch@sfgoth.com \
--cc=mporter@kernel.crashing.org \
--cc=netdev@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=richard@nod.at \
--cc=romain.perier@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).