From: Ray Jui <ray.jui@broadcom.com>
To: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Kamal Dasu <kdasu.kdev@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Ray Jui <ray.jui@broadcom.com>
Subject: [PATCH 3/4] spi: bcm-qspi: Fix probe regression on iProc platforms
Date: Thu, 10 Sep 2020 08:25:38 -0700 [thread overview]
Message-ID: <20200910152539.45584-3-ray.jui@broadcom.com> (raw)
In-Reply-To: <20200910152539.45584-1-ray.jui@broadcom.com>
iProc chips have QSPI controller that does not have the MSPI_REV
offset. Reading from that offset will cause a bus error. Fix it by
having MSPI_REV query disabled in the generic compatible string.
Fixes: 3a01f04d74ef ("spi: bcm-qspi: Handle lack of MSPI_REV offset")
Link: https://lore.kernel.org/linux-arm-kernel/20200909211857.4144718-1-f.fainelli@gmail.com/T/#u
Signed-off-by: Ray Jui <ray.jui@broadcom.com>
---
drivers/spi/spi-bcm-qspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c
index c5209b42b0d2..b78d47a4403c 100644
--- a/drivers/spi/spi-bcm-qspi.c
+++ b/drivers/spi/spi-bcm-qspi.c
@@ -1300,7 +1300,7 @@ static const struct of_device_id bcm_qspi_of_match[] = {
},
{
.compatible = "brcm,spi-bcm-qspi",
- .data = &bcm_qspi_rev_data,
+ .data = &bcm_qspi_no_rev_data,
},
{
.compatible = "brcm,spi-bcm7216-qspi",
--
2.17.1
next prev parent reply other threads:[~2020-09-10 19:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 15:25 [PATCH 1/4] dt-bindings: spi: Add compatible string for brcmstb SoCs Ray Jui
2020-09-10 15:25 ` [PATCH 2/4] spi: bcm-qspi: Add compatible string for BRCMSTB 7445 SoCs Ray Jui
2020-09-10 18:18 ` Florian Fainelli
2020-09-10 15:25 ` Ray Jui [this message]
2020-09-10 18:20 ` [PATCH 3/4] spi: bcm-qspi: Fix probe regression on iProc platforms Florian Fainelli
2020-09-10 15:25 ` [PATCH 4/4] spi: bcm-qspi: Clean up 7425, 7429, and 7435 settings Ray Jui
2020-09-10 18:20 ` Florian Fainelli
2020-09-10 18:18 ` [PATCH 1/4] dt-bindings: spi: Add compatible string for brcmstb SoCs Florian Fainelli
2020-09-14 14:52 ` Mark Brown
2020-09-23 20:38 ` Florian Fainelli
2020-09-24 11:33 ` Mark Brown
2020-09-24 12:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910152539.45584-3-ray.jui@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).