From: Krzysztof Kozlowski <krzk@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Mark Brown <broonie@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH v2] spi: fsl-dspi: fix NULL pointer dereference
Date: Mon, 28 Sep 2020 10:44:20 +0200 [thread overview]
Message-ID: <20200928084420.GA9807@kozik-lap> (raw)
In-Reply-To: <20200928083238.27137-1-michael@walle.cc>
On Mon, Sep 28, 2020 at 10:32:38AM +0200, Michael Walle wrote:
> Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in remove
> path") this driver causes a kernel oops:
>
> [ 1.891065] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000080
> [ 1.899889] Mem abort info:
> [ 1.902692] ESR = 0x96000004
> [ 1.905754] EC = 0x25: DABT (current EL), IL = 32 bits
> [ 1.911089] SET = 0, FnV = 0
> [ 1.914156] EA = 0, S1PTW = 0
> [ 1.917303] Data abort info:
> [ 1.920193] ISV = 0, ISS = 0x00000004
> [ 1.924044] CM = 0, WnR = 0
> [ 1.927022] [0000000000000080] user address but active_mm is swapper
> [ 1.933403] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> [ 1.938995] Modules linked in:
> [ 1.942060] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.9.0-rc6-next-20200925-00026-gae556cc74e28-dirty #94
> [ 1.951838] Hardware name: Kontron SMARC-sAL28 (Single PHY) on SMARC Eval 2.0 carrier (DT)
> [ 1.960135] pstate: 40000005 (nZcv daif -PAN -UAO -TCO BTYPE=--)
> [ 1.966168] pc : dspi_setup+0xc8/0x2e0
> [ 1.969926] lr : dspi_setup+0xbc/0x2e0
> [ 1.973684] sp : ffff80001139b930
> [ 1.977005] x29: ffff80001139b930 x28: ffff00207a5d2000
> [ 1.982338] x27: 0000000000000006 x26: ffff00207a44d410
> [ 1.987669] x25: ffff002079c08100 x24: ffff00207a5d2400
> [ 1.993000] x23: ffff00207a5d2600 x22: ffff800011169948
> [ 1.998332] x21: ffff800010cbcd20 x20: ffff00207a58a800
> [ 2.003663] x19: ffff00207a76b700 x18: 0000000000000010
> [ 2.008994] x17: 0000000000000001 x16: 0000000000000019
> [ 2.014326] x15: ffffffffffffffff x14: 0720072007200720
> [ 2.019657] x13: 0720072007200720 x12: ffff8000111fc5e0
> [ 2.024989] x11: 0000000000000003 x10: ffff8000111e45a0
> [ 2.030320] x9 : 0000000000000000 x8 : ffff00207a76b780
> [ 2.035651] x7 : 0000000000000000 x6 : 000000000000003f
> [ 2.040982] x5 : 0000000000000040 x4 : ffff80001139b918
> [ 2.046313] x3 : 0000000000000001 x2 : 64b62cc917af5100
> [ 2.051643] x1 : 0000000000000000 x0 : 0000000000000000
You can skip all these addresses/registers, so only keep OOPS message
and call trace.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-09-28 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 8:32 [PATCH v2] spi: fsl-dspi: fix NULL pointer dereference Michael Walle
2020-09-28 8:44 ` Krzysztof Kozlowski [this message]
2020-09-28 19:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928084420.GA9807@kozik-lap \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael@walle.cc \
--cc=olteanv@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).