From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 347C4C4727C for ; Tue, 29 Sep 2020 13:13:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7D4B206DC for ; Tue, 29 Sep 2020 13:13:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601385208; bh=6XpaI32bLsO0x+e+H8bay4mTioZkH6ibfYfxFmOmPx4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tUDNoEjedGSB8iY6WfWBhQlZ4yh0cFpyXoY/y2e4mmu+16O1/9KDxf96hxkGZaexg LrY+IIBXrGQ6bu5shpVi4JH2qeiCHr7Mp2l32cAtAX4nQZhuYT4JDguGHf6Hov+fov iyKMIexxRFutX6L6cxKYe9mJmF75LClQFlGfbREU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729700AbgI2NNZ (ORCPT ); Tue, 29 Sep 2020 09:13:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:58528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729363AbgI2NNZ (ORCPT ); Tue, 29 Sep 2020 09:13:25 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 997AA20848; Tue, 29 Sep 2020 13:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601385204; bh=6XpaI32bLsO0x+e+H8bay4mTioZkH6ibfYfxFmOmPx4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kELx8PVTmcFE2nIQcHlOdOQV4RPHtL1KZkKq9wipTMzfm97pg3sV9cBHFqCaou8m5 KwI92r3iHSPmM3zGcjMMDBW6PzQB2grJmteKMR8mouhZyK6Q6sJpIrK3yKaH4jA9lq S33jt6WSpcL+RG96RtBWh/Ct2/D2DCZBF3KmRGUA= Date: Tue, 29 Sep 2020 14:12:25 +0100 From: Mark Brown To: Serge Semin Cc: Serge Semin , Alexey Malahov , Ramil Zaripov , Pavel Parkhomenko , Andy Shevchenko , Andy Shevchenko , Lars Povlsen , "wuxu . wu" , Feng Tang , Rob Herring , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/30] spi: dw: Initialize n_bytes before the memory barrier Message-ID: <20200929131225.GE4799@sirena.org.uk> References: <20200920112914.26501-1-Sergey.Semin@baikalelectronics.ru> <20200920112914.26501-4-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="a1QUDc0q7S3U7/Jg" Content-Disposition: inline In-Reply-To: <20200920112914.26501-4-Sergey.Semin@baikalelectronics.ru> X-Cookie: I left my WALLET in the BATHROOM!! User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org --a1QUDc0q7S3U7/Jg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Sep 20, 2020 at 02:28:47PM +0300, Serge Semin wrote: > Since n_bytes field of the DW SPI private data is also utilized by the > IRQ handler, we need to make sure it' initialization is done before the > memory barrier. This looks like a fix so should have been before any cosmetic cleanups. --a1QUDc0q7S3U7/Jg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9zMrgACgkQJNaLcl1U h9ADXwf/VfBVN64j5D1Qdpr1AuBo5GLZ7Lv8WZ+LOueVwNndpF1V1pUDAGi63hMm jzQi8luVWfoqRPiMa450CPnivKoDkVSMUBS/9uWCub/4Vea+cEL6TTrkOl6lxCU9 ND/mQgD0hUb4/f3b7KoTXn9Qp1E/4eSvcb8N7IIqIxjzcOKCrbn/g3vUNgAleE1r JnmEUpvkY1inP/yURskCB7xNTXdaJRzy2fMUn+6mbX1W5RMk6ocG8zkv3LJXrcoP e73Mq+qWCorphO639qclMW+er+LNU8FkT4BAr/FYyDuAN90Dzx13/vGFjhhG9fEG 7mwERlJcDeRU2/i9LsDzuf7hvmtjpw== =pdBD -----END PGP SIGNATURE----- --a1QUDc0q7S3U7/Jg--