From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B71AC4727C for ; Tue, 29 Sep 2020 13:53:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 111D62145D for ; Tue, 29 Sep 2020 13:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601387614; bh=XMlJFSSuGLwN5k1WwBefP32bozx8G9mTS3B5NnSlArI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=l8ZEq5Vx6QS8qwuKYR4W5l/LKEh9lpBH2OkXoiYRzqdAsnJcwhcEkbU40iUsQtcY4 BOMuu8sCxhm/VAd956G/FJJ+h2HCwrcA5VJbaCtkkTqdxkUQcZbIVcWG9CW/RV2dlR 08BnTfJol1MwC1RPcrjAgwBIlAsqmV4frOSCYQ94= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728917AbgI2Nxd (ORCPT ); Tue, 29 Sep 2020 09:53:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:41122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727328AbgI2Nxd (ORCPT ); Tue, 29 Sep 2020 09:53:33 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E017C207C4; Tue, 29 Sep 2020 13:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601387612; bh=XMlJFSSuGLwN5k1WwBefP32bozx8G9mTS3B5NnSlArI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u/bz7GDKIVERvmjP07DfF7CO+293Gz1UAt+rBmWu17V2qzF+0qTFiNpmREcXcVWVw IQanQVHjqxoBSg05IsapueT7Tcjrf+WJjD9qjUQCnc3Mse8jYI4A1x14LtQE2KgKeO /vlGWgnaiSN+1GrlOak46O+mPgTsHwU7ippWMze0= Date: Tue, 29 Sep 2020 14:52:33 +0100 From: Mark Brown To: Serge Semin Cc: Serge Semin , Alexey Malahov , Ramil Zaripov , Pavel Parkhomenko , Andy Shevchenko , Andy Shevchenko , Lars Povlsen , "wuxu . wu" , Feng Tang , Rob Herring , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/30] spi: dw: Add DWC SSI capability Message-ID: <20200929135233.GG4799@sirena.org.uk> References: <20200920112914.26501-1-Sergey.Semin@baikalelectronics.ru> <20200920112914.26501-12-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eVzOFob/8UvintSX" Content-Disposition: inline In-Reply-To: <20200920112914.26501-12-Sergey.Semin@baikalelectronics.ru> X-Cookie: I left my WALLET in the BATHROOM!! User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org --eVzOFob/8UvintSX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Sep 20, 2020 at 02:28:55PM +0300, Serge Semin wrote: > - /* > - * SPI mode (SCPOL|SCPH) > - * CTRLR0[ 8] Serial Clock Phase > - * CTRLR0[ 9] Serial Clock Polarity > - */ > - cr0 |= ((spi->mode & SPI_CPOL) ? 1 : 0) << DWC_SSI_CTRLR0_SCPOL_OFFSET; > - cr0 |= ((spi->mode & SPI_CPHA) ? 1 : 0) << DWC_SSI_CTRLR0_SCPH_OFFSET; > + cr0 |= SSI_MOTO_SPI << DWC_SSI_CTRLR0_FRF_OFFSET; > + cr0 |= ((spi->mode & SPI_CPOL) ? 1 : 0) << DWC_SSI_CTRLR0_SCPOL_OFFSET; > + cr0 |= ((spi->mode & SPI_CPHA) ? 1 : 0) << DWC_SSI_CTRLR0_SCPH_OFFSET; The new code seems less well commented than the old code here. --eVzOFob/8UvintSX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9zPCAACgkQJNaLcl1U h9DKGgf8Dusx5FsYcQ5npzfLKiRdTmIprfoh+fIEbrMCruynt16OBQS/sX6tmoGe SRj8t6pzB+q7LJ49Ct9MG0mDcCfTSXRp2B+bXCT8cOVmGR64fdYYprqdJw0P2iRL rAm6idVXHqjHOM1PnJNlInPIEIQwFqqMXQ9tyn9dgOHDK80pHbZPtXxx/ouBRYi9 YldOhxizTwenaE0koaxF4blxjPOs2f10QRlKji9zCMqMTOInFjtffJ7YDl56MMDI AXHvn8wTj0rDOkNXgmEN5kJrTTVG0ocZrJXTm5QLoGQD4eeAcrTuWhOg3+pRY8o7 p0Izj1+Tyj0LVHTejlwAq239vgPhMw== =r+YB -----END PGP SIGNATURE----- --eVzOFob/8UvintSX--