From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F16FC4363D for ; Fri, 2 Oct 2020 19:56:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC38C206C3 for ; Fri, 2 Oct 2020 19:56:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725355AbgJBT43 (ORCPT ); Fri, 2 Oct 2020 15:56:29 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:52542 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbgJBT43 (ORCPT ); Fri, 2 Oct 2020 15:56:29 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id E6316803017E; Fri, 2 Oct 2020 19:56:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6YRMgoMFRauJ; Fri, 2 Oct 2020 22:56:26 +0300 (MSK) Date: Fri, 2 Oct 2020 22:56:25 +0300 From: Serge Semin To: Andy Shevchenko CC: Serge Semin , Mark Brown , Alexey Malahov , Ramil Zaripov , Pavel Parkhomenko , Lars Povlsen , "wuxu . wu" , Feng Tang , Rob Herring , linux-spi , devicetree , Linux Kernel Mailing List Subject: Re: [PATCH v3 03/21] spi: dw: Detach SPI device specific CR0 config method Message-ID: <20201002195625.6lzutebffvpfgz54@mobilestation> References: <20201001222829.15977-1-Sergey.Semin@baikalelectronics.ru> <20201001222829.15977-4-Sergey.Semin@baikalelectronics.ru> <20201002102246.GX3956970@smile.fi.intel.com> <20201002174725.rpwdgfo6xzxafqhs@mobilestation> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Fri, Oct 02, 2020 at 09:24:55PM +0300, Andy Shevchenko wrote: > On Fri, Oct 2, 2020 at 8:47 PM Serge Semin > wrote: > > On Fri, Oct 02, 2020 at 01:22:46PM +0300, Andy Shevchenko wrote: > > > On Fri, Oct 02, 2020 at 01:28:11AM +0300, Serge Semin wrote: > > > > > + /* > > > > + * Update CR0 data each time the setup callback is invoked since > > > > + * the device parameters could have been changed, for instance, by > > > > + * the MMC SPI driver or something else. > > > > + */ > > > > + chip->cr0 = dw_spi_get_cr0(dws, spi); > > > > > > > > I would rather name it prepare or alike. 'get' assumes getting value or > > > something like that. > > > > This seems reasonable. What verb do you think would be better: prepare, > > calc, assemble, construct, make, compute, collect, compose, form, compile, etc ? > > Personally prepare or calc or assemble are the best candidates. What do you > > think? > > prepare is good enough if you agree on it. Ok. "prepare" it is then. -Sergey > > > -- > With Best Regards, > Andy Shevchenko