From: Mark Brown <broonie@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-spi@vger.kernel.org
Subject: Re: [PATCH 1/3] spi: fix resource leak for drivers without .remove callback
Date: Thu, 19 Nov 2020 16:09:47 +0000 [thread overview]
Message-ID: <20201119160947.GD5554@sirena.org.uk> (raw)
In-Reply-To: <20201119160412.nhu2rmwygyh6yg6e@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Thu, Nov 19, 2020 at 05:04:12PM +0100, Uwe Kleine-König wrote:
> On Thu, Nov 19, 2020 at 03:41:39PM +0000, Mark Brown wrote:
> > On Thu, Nov 19, 2020 at 04:35:40PM +0100, Uwe Kleine-König wrote:
> > > (Not sure this makes a difference in real life, are there drivers
> > > without a .probe callback?)
> > Your changelog seemed to say that it would make remove mandatory.
> No, that's not what the patch did. It made unconditional use of
> spi_drv_remove(), but an spi_driver without .remove() was still ok. I
> will reword to make this clearer.
Ah, OK - I hadn't read the patch closely as the description sounded
wrong.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-11-19 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 15:20 [PATCH 1/3] spi: fix resource leak for drivers without .remove callback Uwe Kleine-König
2020-11-19 15:20 ` [PATCH 2/3] spi: Use bus_type functions for probe, remove and shutdown Uwe Kleine-König
2020-11-19 15:20 ` [PATCH 3/3] spi: Warn when a driver's remove callback returns an error Uwe Kleine-König
2020-11-19 15:24 ` [PATCH 1/3] spi: fix resource leak for drivers without .remove callback Mark Brown
2020-11-19 15:35 ` Uwe Kleine-König
2020-11-19 15:41 ` Mark Brown
2020-11-19 16:04 ` Uwe Kleine-König
2020-11-19 16:09 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119160947.GD5554@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).