From: Brad Larson <brad@pensando.io>
To: linux-arm-kernel@lists.infradead.org
Cc: arnd@arndb.de, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, broonie@kernel.org,
fancer.lancer@gmail.com, adrian.hunter@intel.com,
ulf.hansson@linaro.org, olof@lixom.net, brad@pensando.io,
linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/8] spi: dw: Add support for Pensando Elba SoC SPI
Date: Wed, 3 Mar 2021 19:41:36 -0800 [thread overview]
Message-ID: <20210304034141.7062-4-brad@pensando.io> (raw)
In-Reply-To: <20210304034141.7062-1-brad@pensando.io>
The Pensando Elba SoC uses a GPIO based chip select
for two DW SPI busses with each bus having two
chip selects.
Signed-off-by: Brad Larson <brad@pensando.io>
---
drivers/spi/spi-dw-mmio.c | 35 ++++++++++++++++++++++++++++++++++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
index 17c06039a74d..417bd2125c07 100644
--- a/drivers/spi/spi-dw-mmio.c
+++ b/drivers/spi/spi-dw-mmio.c
@@ -56,7 +56,7 @@ struct dw_spi_mscc {
/*
* The Designware SPI controller (referred to as master in the documentation)
* automatically deasserts chip select when the tx fifo is empty. The chip
- * selects then needs to be either driven as GPIOs or, for the first 4 using the
+ * selects then needs to be either driven as GPIOs or, for the first 4 using
* the SPI boot controller registers. the final chip select is an OR gate
* between the Designware SPI controller and the SPI boot controller.
*/
@@ -237,6 +237,38 @@ static int dw_spi_canaan_k210_init(struct platform_device *pdev,
return 0;
}
+static void dw_spi_elba_set_cs(struct spi_device *spi, bool enable)
+{
+ struct dw_spi *dws = spi_master_get_devdata(spi->master);
+
+ if (!enable) {
+ if (spi->cs_gpiod) {
+ /*
+ * Using a GPIO-based chip-select, the DW SPI
+ * controller still needs its own CS bit selected
+ * to start the serial engine. On Elba the specific
+ * CS doesn't matter, so use CS0.
+ */
+ dw_writel(dws, DW_SPI_SER, BIT(0));
+ } else {
+ /*
+ * Using the intrinsic DW chip-select; set the
+ * appropriate CS.
+ */
+ dw_writel(dws, DW_SPI_SER, BIT(spi->chip_select));
+ }
+ } else
+ dw_writel(dws, DW_SPI_SER, 0);
+}
+
+static int dw_spi_elba_init(struct platform_device *pdev,
+ struct dw_spi_mmio *dwsmmio)
+{
+ dwsmmio->dws.set_cs = dw_spi_elba_set_cs;
+
+ return 0;
+}
+
static int dw_spi_mmio_probe(struct platform_device *pdev)
{
int (*init_func)(struct platform_device *pdev,
@@ -351,6 +383,7 @@ static const struct of_device_id dw_spi_mmio_of_match[] = {
{ .compatible = "intel,keembay-ssi", .data = dw_spi_keembay_init},
{ .compatible = "microchip,sparx5-spi", dw_spi_mscc_sparx5_init},
{ .compatible = "canaan,k210-spi", dw_spi_canaan_k210_init},
+ { .compatible = "pensando,elba-spi", .data = dw_spi_elba_init },
{ /* end of table */}
};
MODULE_DEVICE_TABLE(of, dw_spi_mmio_of_match);
--
2.17.1
next prev parent reply other threads:[~2021-03-04 3:44 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 3:41 [PATCH 0/8] Support Pensando Elba SoC Brad Larson
2021-03-04 3:41 ` [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control Brad Larson
2021-03-04 8:29 ` Linus Walleij
2021-03-04 9:10 ` Serge Semin
2021-03-04 13:38 ` Linus Walleij
2021-08-23 1:05 ` Brad Larson
2021-08-29 21:09 ` Linus Walleij
2021-10-04 16:46 ` Brad Larson
2021-10-12 23:51 ` Linus Walleij
2021-10-14 20:06 ` Brad Larson
2021-03-30 2:44 ` Brad Larson
2021-08-23 1:05 ` Brad Larson
2021-03-04 20:43 ` Elliott, Robert (Servers)
2021-08-23 1:06 ` Brad Larson
2021-03-05 11:25 ` Krzysztof Kozlowski
2021-08-23 1:07 ` Brad Larson
2021-03-05 13:57 ` Geert Uytterhoeven
2021-08-23 1:08 ` Brad Larson
2021-03-07 19:21 ` Andy Shevchenko
2021-03-29 1:19 ` Brad Larson
2021-03-29 10:39 ` Andy Shevchenko
2021-08-23 1:13 ` Brad Larson
2021-08-23 7:50 ` Geert Uytterhoeven
2021-08-23 16:30 ` Brad Larson
2021-08-23 20:11 ` Geert Uytterhoeven
2021-10-04 17:14 ` Brad Larson
2021-10-04 17:16 ` Geert Uytterhoeven
2021-08-23 1:10 ` Brad Larson
2021-03-04 3:41 ` [PATCH 2/8] spi: cadence-quadspi: Add QSPI support for Pensando Elba SoC Brad Larson
2021-03-04 9:29 ` Arnd Bergmann
2021-03-04 3:41 ` Brad Larson [this message]
2021-03-04 6:44 ` [PATCH 3/8] spi: dw: Add support for Pensando Elba SoC SPI Serge Semin
2021-08-23 1:17 ` Brad Larson
2021-03-04 8:48 ` Linus Walleij
2021-03-10 3:52 ` Brad Larson
2021-03-04 3:41 ` [PATCH 4/8] spidev: Add Pensando CPLD compatible Brad Larson
2021-03-04 9:33 ` Arnd Bergmann
2021-03-04 3:41 ` [PATCH 5/8] mmc: sdhci-cadence: Add Pensando Elba SoC support Brad Larson
2021-03-04 9:41 ` Arnd Bergmann
2021-03-04 3:41 ` [PATCH 6/8] arm64: Add config for Pensando SoC platforms Brad Larson
2021-03-04 9:42 ` Arnd Bergmann
2021-03-04 3:41 ` [PATCH 7/8] arm64: dts: Add Pensando Elba SoC support Brad Larson
2021-03-04 8:03 ` Serge Semin
2021-03-29 1:07 ` Brad Larson
2021-08-23 0:54 ` Brad Larson
2021-03-04 8:51 ` Linus Walleij
2021-03-29 0:54 ` Brad Larson
2021-03-04 9:06 ` Arnd Bergmann
2021-03-04 20:47 ` Rob Herring
2021-03-05 11:22 ` Krzysztof Kozlowski
2021-03-04 3:41 ` [PATCH 8/8] MAINTAINERS: Add entry for PENSANDO Brad Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304034141.7062-4-brad@pensando.io \
--to=brad@pensando.io \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).