From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A11EC433E6 for ; Mon, 15 Mar 2021 06:48:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D57C961481 for ; Mon, 15 Mar 2021 06:48:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229876AbhCOGry (ORCPT ); Mon, 15 Mar 2021 02:47:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:55194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229644AbhCOGrj (ORCPT ); Mon, 15 Mar 2021 02:47:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 753D061481; Mon, 15 Mar 2021 06:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615790859; bh=tbpcL/ugwKzj1S4GzRvx9tIUZ5PMxmhUXJW+GqVkm38=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U9wxdEN3AYMiwTYJBk+vOVyAzfBfEK4QSkQOUJZyQNVLJCNyA32bJy2nULPByxYR/ ivYVX3DWQqBNKsoNrBAjcvHjCNKGuHwgf5n8KqD/v6Usl17oQPt1doCcjB4ul9hK9Z n5GudCSdLvpnuNqWNJDWzedYpzkT4/esev8yhZQ9El7YCZr+Hmg2U8yctJTFhc+rQr r5W3d05skDhrAF72IgXegExiT6UniW1xYTjK44IGHpINeS/wYTHPaNcFW0DoiNdQcR pm72xo/VIsZLBK9AJz8PP3jQqz+nmok7BWA0ptpZhwn18jOXF/Z2e5M/BXWa+Z04nb Ghlm0hLuDJZ6A== Date: Mon, 15 Mar 2021 14:47:31 +0800 From: Shawn Guo To: Heiko Schocher Cc: linux-arm-kernel@lists.infradead.org, Alice Guo , Anson Huang , Ashish Kumar , Dong Aisheng , Fabio Estevam , Horia =?utf-8?Q?Geant=C4=83?= , Jacky Bai , Joakim Zhang , Krzysztof Kozlowski , Li Jun , Mark Brown , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Teresa Remmet , Yogesh Gaur , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: [PATCH v2 0/4] enable flexspi support on imx8mp Message-ID: <20210315064731.GL11246@dragon> References: <20210309053116.1486347-1-hs@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210309053116.1486347-1-hs@denx.de> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Tue, Mar 09, 2021 at 06:31:12AM +0100, Heiko Schocher wrote: > > This series enables support for the SPI NOR on the > imx8mp based phyboard-pollux-rdk board. > > Patches new in v2: > "spi: fspi: enable fspi driver for on imx8mp" > which adds own compatible entry for imx8mp > > and seperate in own patch the documentation entry in > patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller" > as checkpatch says: > > warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst > > > Changes in v2: > - work in comments from Marco > add own compatible entry for imx8mp > - work in comments from Marco > - add own compatible entry "nxp,imx8mp-fspi" > - reworked order of properties as Marco mentioned > - work in comments from Marco and Teresa > - rename node into "'som_flash: flash@0 { }" > - compatible is now first entry > - removed #size-cells and #address-cells > as no child node. If bootloader adds them bootloader > can add them too. > > Heiko Schocher (4): > spi: fspi: enable fspi driver for on imx8mp > dt-bindings: spi: add compatible entry for imx8mp in FlexSPI > controller > arm64: dts: imx8mp: add flexspi node > arm64: imx8mp: imx8mp-phycore-som enable spi nor Two DTS patch look good. Ping me when driver and bindings changes are accepted. Shawn