From: Mark Brown <broonie@kernel.org>
To: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, git@xilinx.com,
Karen Dombroski <karen.dombroski@marsbioimaging.com>
Subject: Re: [PATCH 2/2] spi: spi-zynq-qspi: Fix stack violation bug
Date: Thu, 18 Mar 2021 13:23:23 +0000 [thread overview]
Message-ID: <20210318132323.GG5469@sirena.org.uk> (raw)
In-Reply-To: <20210318102446.25142-3-amit.kumar-mahapatra@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
On Thu, Mar 18, 2021 at 04:24:46AM -0600, Amit Kumar Mahapatra wrote:
> When the number of bytes for the op is greater than one, the read could
> run off the end of the function stack and cause a crash.
> This patch restores the behaviour of safely reading out of the original
> opcode location.
> Kernel panic - not syncing: stack-protector: Kernel stack is corrupted
> in: zynq_qspi_exec_mem_op+0x1c0/0x2e0
> CPU1: stopping
Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-18 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 10:24 [PATCH 0/2]spi: spi-zynq-qspi: Fix stack violation bug Amit Kumar Mahapatra
2021-03-18 10:24 ` [PATCH 1/2] spi: spi-zynq-qspi: Fix kernel-doc warning Amit Kumar Mahapatra
2021-03-18 13:58 ` Mark Brown
2021-03-18 10:24 ` [PATCH 2/2] spi: spi-zynq-qspi: Fix stack violation bug Amit Kumar Mahapatra
2021-03-18 13:23 ` Mark Brown [this message]
2021-04-29 17:15 ` [PATCH 0/2]spi: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318132323.GG5469@sirena.org.uk \
--to=broonie@kernel.org \
--cc=amit.kumar-mahapatra@xilinx.com \
--cc=git@xilinx.com \
--cc=karen.dombroski@marsbioimaging.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).