From: Pratyush Yadav <p.yadav@ti.com>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Rob Herring <robh@kernel.org>, Mark Brown <broonie@kernel.org>,
Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
<linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml
Date: Thu, 1 Apr 2021 14:26:51 +0530 [thread overview]
Message-ID: <20210401085649.deocs3cbd7kiljrf@ti.com> (raw)
In-Reply-To: <1161dc3b-c889-c5d7-f7c8-baf5b7b79505@ti.com>
On 01/04/21 01:57PM, Vignesh Raghavendra wrote:
>
>
> On 3/29/21 11:52 PM, Pratyush Yadav wrote:
> >>> + cdns,fifo-depth:
> >>> + description:
> >>> + Size of the data FIFO in words.
> >>> + $ref: "/schemas/types.yaml#/definitions/uint32"
> >>> + enum: [ 128, 256 ]
> >>> + default: 128
> >>> +
> >>> + cdns,fifo-width:
> >>> + $ref: /schemas/types.yaml#/definitions/uint32
> >>> + description:
> >>> + Bus width of the data FIFO in bytes.
> >>> + default: 4
> >> I assume there's some constraints on this?
> > IIUC this is a matter of how the peripheral is implemented and there are
> > no clear constraints. Different implementations can use different bus
> > widths for the SRAM bus but I don't see any mention of minimum or
> > maximum values. FWIW, all users in the kernel use a 4 byte bus.
> >
>
> IMO a safe constraint would be to set a range of 1 to 4 (8/16/24/32 bit
> wide) given this represents SRAM bus width. Binding can always be
> updated if there exists an implementation with higher SRAM bus
> width/fifo-width (although that's highly unlikely given there are no
> such examples today).
>
> But leaving it open ended with range of 0 to UINT_MAX sounds incorrect
> to me.
Ok. Will respin.
>
> >> With that,
> >>
> >> Reviewed-by: Rob Herring <robh@kernel.org>
> > Thanks.
> >
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2021-04-01 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 13:00 [PATCH 0/4] Convert Cadence QSPI bindings to yaml Pratyush Yadav
2021-03-26 13:00 ` [PATCH 1/4] arm64: dts: ti: k3-j721e-mcu: Fix ospi compatible Pratyush Yadav
2021-04-01 6:28 ` Vignesh Raghavendra
2021-03-26 13:00 ` [PATCH 2/4] arm64: dts: ti: k3-j7200-mcu: " Pratyush Yadav
2021-04-01 6:28 ` Vignesh Raghavendra
2021-03-26 13:00 ` [PATCH 3/4] arm64: dts: ti: k3-am64-main: " Pratyush Yadav
2021-04-01 6:29 ` Vignesh Raghavendra
2021-03-26 13:00 ` [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml Pratyush Yadav
2021-03-27 18:36 ` Rob Herring
2021-03-29 18:22 ` Pratyush Yadav
2021-04-01 8:27 ` Vignesh Raghavendra
2021-04-01 8:56 ` Pratyush Yadav [this message]
2021-03-31 19:11 ` Mark Brown
2021-03-31 19:39 ` Pratyush Yadav
2021-04-01 14:13 ` Mark Brown
2021-04-05 8:34 ` Pratyush Yadav
2021-04-01 10:16 ` (subset) [PATCH 0/4] Convert Cadence QSPI bindings to yaml Mark Brown
2021-04-01 13:52 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401085649.deocs3cbd7kiljrf@ti.com \
--to=p.yadav@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).