From: Mark Brown <broonie@kernel.org>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] linux/spi: Remove repeated struct declaration
Date: Thu, 1 Apr 2021 11:46:19 +0100 [thread overview]
Message-ID: <20210401104619.GA4512@sirena.org.uk> (raw)
In-Reply-To: <20210401065904.994121-1-wanjiabing@vivo.com>
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On Thu, Apr 01, 2021 at 02:59:04PM +0800, Wan Jiabing wrote:
> struct spi_transfer is declared twice. One is declared at 24th line.
> The blew one is not needed though. Remove the duplicate.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-04-01 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 6:59 [PATCH] linux/spi: Remove repeated struct declaration Wan Jiabing
2021-04-01 10:46 ` Mark Brown [this message]
2021-04-01 16:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401104619.GA4512@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).