From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] spi: Avoid potential UB when counting unused native CSs
Date: Tue, 20 Apr 2021 16:22:03 +0100 [thread overview]
Message-ID: <20210420152203.GD6073@sirena.org.uk> (raw)
In-Reply-To: <YH7uGhEmnk2sBzVv@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 389 bytes --]
On Tue, Apr 20, 2021 at 06:07:06PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 20, 2021 at 03:56:16PM +0100, Mark Brown wrote:
> > On Tue, Apr 20, 2021 at 05:10:04PM +0300, Andy Shevchenko wrote:
> > > ffz(), that has been used to count unused native CSs, might produce UB
> > Bit of an IA there...
> UB -- undefined behaviour.
> I'll decode it. Should I decode CS as well?
CS is fine.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-04-20 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 14:10 [PATCH v1 1/2] spi: Allow to have all native CSs in use along with GPIOs Andy Shevchenko
2021-04-20 14:10 ` [PATCH v1 2/2] spi: Avoid potential UB when counting unused native CSs Andy Shevchenko
2021-04-20 14:56 ` Mark Brown
2021-04-20 15:07 ` Andy Shevchenko
2021-04-20 15:22 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420152203.GD6073@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).