From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] spi: Remove unneeded parentheses in spi_map_buf()
Date: Mon, 21 Jun 2021 11:39:23 +0100 [thread overview]
Message-ID: <20210621103923.GA4094@sirena.org.uk> (raw)
In-Reply-To: <20210619111526.27776-1-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
On Sat, Jun 19, 2021 at 02:15:26PM +0300, Andy Shevchenko wrote:
> The boolean expression to get kmap_buf is hard to read due to
> too many unneeded parentheses. Remove them for good.
> - const bool kmap_buf = ((unsigned long)buf >= PKMAP_BASE &&
> - (unsigned long)buf < (PKMAP_BASE +
> - (LAST_PKMAP * PAGE_SIZE)));
> + const bool kmap_buf = (unsigned long)buf >= PKMAP_BASE &&
> + (unsigned long)buf < (PKMAP_BASE + LAST_PKMAP * PAGE_SIZE);
No, I think this makes things worse - to the extent there's an issue
here it's not excessive brackets.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-21 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 11:15 [PATCH v1 1/1] spi: Remove unneeded parentheses in spi_map_buf() Andy Shevchenko
2021-06-21 10:39 ` Mark Brown [this message]
2021-06-21 10:43 ` Andy Shevchenko
2021-06-21 11:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621103923.GA4094@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).