From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E86D1C49EAF for ; Mon, 28 Jun 2021 06:05:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4BBB61926 for ; Mon, 28 Jun 2021 06:05:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232217AbhF1GHa (ORCPT ); Mon, 28 Jun 2021 02:07:30 -0400 Received: from mga09.intel.com ([134.134.136.24]:50167 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232191AbhF1GHa (ORCPT ); Mon, 28 Jun 2021 02:07:30 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10028"; a="207835158" X-IronPort-AV: E=Sophos;i="5.83,305,1616482800"; d="scan'208";a="207835158" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2021 23:05:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,305,1616482800"; d="scan'208";a="492207683" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.162]) by fmsmga002.fm.intel.com with ESMTP; 27 Jun 2021 23:05:01 -0700 Date: Mon, 28 Jun 2021 13:59:42 +0800 From: Xu Yilun To: Martin =?iso-8859-1?Q?Hundeb=F8ll?= Cc: Wu Hao , Tom Rix , Moritz Fischer , Jean Delvare , Guenter Roeck , Lee Jones , Mark Brown , Martin =?iso-8859-1?Q?Hundeb=F8ll?= , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: [PATCH v2 4/5] mfd: intel-m10-bmc: add n5010 variant Message-ID: <20210628055942.GD72330@yilunxu-OptiPlex-7050> References: <20210625074213.654274-1-martin@geanix.com> <20210625074213.654274-5-martin@geanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210625074213.654274-5-martin@geanix.com> Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org It is good to me. On Fri, Jun 25, 2021 at 09:42:12AM +0200, Martin Hundebøll wrote: > From: Martin Hundebøll > > The m10-bmc is used on the Silicom N5010 PAC too, so add it to list of > m10bmc types. > > Signed-off-by: Martin Hundebøll > --- > > Changes since v1: > * Patch split out to separate mfd changes > > drivers/mfd/intel-m10-bmc.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/intel-m10-bmc.c b/drivers/mfd/intel-m10-bmc.c > index 1a9bfb7f48cd..8db3bcf5fccc 100644 > --- a/drivers/mfd/intel-m10-bmc.c > +++ b/drivers/mfd/intel-m10-bmc.c > @@ -15,7 +15,8 @@ > > enum m10bmc_type { > M10_N3000, > - M10_D5005 > + M10_D5005, > + M10_N5010, > }; > > static struct mfd_cell m10bmc_d5005_subdevs[] = { > @@ -28,6 +29,10 @@ static struct mfd_cell m10bmc_pacn3000_subdevs[] = { > { .name = "n3000bmc-secure" }, > }; > > +static struct mfd_cell m10bmc_n5010_subdevs[] = { > + { .name = "n5010bmc-hwmon" }, > +}; > + > static const struct regmap_range m10bmc_regmap_range[] = { > regmap_reg_range(M10BMC_LEGACY_BUILD_VER, M10BMC_LEGACY_BUILD_VER), > regmap_reg_range(M10BMC_SYS_BASE, M10BMC_SYS_END), > @@ -192,6 +197,10 @@ static int intel_m10_bmc_spi_probe(struct spi_device *spi) > cells = m10bmc_d5005_subdevs; > n_cell = ARRAY_SIZE(m10bmc_d5005_subdevs); > break; > + case M10_N5010: > + cells = m10bmc_n5010_subdevs; > + n_cell = ARRAY_SIZE(m10bmc_n5010_subdevs); > + break; > default: > return -ENODEV; > } > @@ -207,6 +216,7 @@ static int intel_m10_bmc_spi_probe(struct spi_device *spi) > static const struct spi_device_id m10bmc_spi_id[] = { > { "m10-n3000", M10_N3000 }, > { "m10-d5005", M10_D5005 }, > + { "m10-n5010", M10_N5010 }, > { } > }; > MODULE_DEVICE_TABLE(spi, m10bmc_spi_id); > -- > 2.31.0