From: Mark Brown <broonie@kernel.org>
To: Alain Volmat <alain.volmat@foss.st.com>
Cc: amelie.delaunay@foss.st.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, linux-spi@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, fabrice.gasnier@foss.st.com
Subject: Re: [PATCH 1/6] spi: stm32: fixes pm_runtime calls in probe/remove
Date: Wed, 30 Jun 2021 13:34:18 +0100 [thread overview]
Message-ID: <20210630123418.GC5106@sirena.org.uk> (raw)
In-Reply-To: <1625042723-661-2-git-send-email-alain.volmat@foss.st.com>
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
On Wed, Jun 30, 2021 at 10:45:18AM +0200, Alain Volmat wrote:
> + pm_runtime_set_autosuspend_delay(&pdev->dev,
> + STM32_SPI_AUTOSUSPEND_DELAY);
> + pm_runtime_use_autosuspend(&pdev->dev);
The driver wasn't using autosuspend at all prior to this patch so
there's no fix from that part of the change, the enabling of autosuspend
ought to be split out into a separate patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-30 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 8:45 [PATCH 0/6] spi: stm32: various fixes & cleanup Alain Volmat
2021-06-30 8:45 ` [PATCH 1/6] spi: stm32: fixes pm_runtime calls in probe/remove Alain Volmat
2021-06-30 12:34 ` Mark Brown [this message]
2021-06-30 8:45 ` [PATCH 2/6] spi: stm32h7: fix full duplex irq handler handling Alain Volmat
2021-06-30 8:45 ` [PATCH 3/6] Revert "spi: stm32: properly handle 0 byte transfer" Alain Volmat
2021-06-30 12:34 ` Mark Brown
2021-06-30 8:45 ` [PATCH 4/6] spi: stm32h7: rework rx fifo read function Alain Volmat
2021-06-30 8:45 ` [PATCH 5/6] spi: stm32h7: don't wait for EOT and flush fifo on disable Alain Volmat
2021-06-30 8:45 ` [PATCH 6/6] spi: stm32: finalize message either on dma callback or EOT Alain Volmat
2021-06-30 10:10 ` [PATCH 0/6] spi: stm32: various fixes & cleanup Amelie DELAUNAY
2021-06-30 16:10 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630123418.GC5106@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).