From: Pratyush Yadav <p.yadav@ti.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Michael Walle <michael@walle.cc>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Jonathan Corbet <corbet@lwn.net>,
Mauro Lima <mauro.lima@eclypsium.com>,
Alexander Sverdlin <alexander.sverdlin@nokia.com>,
<linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>
Subject: Re: [PATCH 2/3] mtd: spi-nor: intel-spi: Convert to SPI MEM
Date: Fri, 8 Oct 2021 16:26:48 +0530 [thread overview]
Message-ID: <20211008105646.ity7isvuum4yyvpj@ti.com> (raw)
In-Reply-To: <YWAJJLST7KYAD6Fw@lahna>
On 08/10/21 12:02PM, Mika Westerberg wrote:
> Hi,
>
> On Thu, Oct 07, 2021 at 11:30:31PM +0530, Pratyush Yadav wrote:
> > > Probably but I would not call these "problems" - it is how the
> > > controller is designed. This one is meant only for SPI-NOR flash access,
> > > typically used by the BIOS. It is by no means general purpose SPI
> > > controller (as you can see from the datasheet). The BIOS does need the
> > > full SPI stack, it just issues these simple commands and let's the
> > > controller figure out what actually needs to be done.
> >
> > The problem is not the controller itself. It is perfectly fine piece to
> > have a controller like this IMO. The problem is how do we make it fit
> > into the SPI MEM model, which seems to be designed for general purpose
> > controllers only. This problem is shared with this and the Cadence xSPI
> > controller.
>
> Fully agree. IMHO trying to shoehorn driver like this into a generic SPI
> subsystem does not make much sense to me. These things can only talk to
> SPI-NOR chips, nothing else.
>
> Do you have any suggestions how to solve this "problem" so we can move
> forward with the drivers?
No, I unfortunately don't. But I suppose the same problem existed with
the old driver as well. It ignored nor->read_opcode, etc. and did its
own thing, so at least I don't expect things to get much worse with the
SPI MEM model.
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2021-10-08 10:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 10:07 [PATCH 0/3] mtd: spi-nor / spi / MFD: Convert intel-spi to SPI MEM Mika Westerberg
2021-09-30 10:07 ` [PATCH 1/3] mtd: spi-nor: intel-spi: Disable write protection only if asked Mika Westerberg
2021-10-01 20:23 ` Mauro Lima
2021-10-04 5:18 ` Mika Westerberg
2021-10-12 18:49 ` Mauro Lima
2021-10-13 9:03 ` Mika Westerberg
2021-10-13 18:22 ` Mauro Lima
2021-09-30 10:07 ` [PATCH 2/3] mtd: spi-nor: intel-spi: Convert to SPI MEM Mika Westerberg
2021-10-04 9:52 ` Pratyush Yadav
2021-10-04 10:07 ` Mika Westerberg
2021-10-07 12:36 ` Pratyush Yadav
2021-10-07 16:46 ` Mika Westerberg
2021-10-07 18:00 ` Pratyush Yadav
2021-10-08 9:02 ` Mika Westerberg
2021-10-08 10:56 ` Pratyush Yadav [this message]
2021-10-04 14:29 ` Andy Shevchenko
2021-10-05 9:41 ` Mika Westerberg
2021-09-30 10:07 ` [PATCH 3/3] Documentation / MTD: Rename the intel-spi driver Mika Westerberg
2021-09-30 15:03 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211008105646.ity7isvuum4yyvpj@ti.com \
--to=p.yadav@ti.com \
--cc=alexander.sverdlin@nokia.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=lee.jones@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mauro.lima@eclypsium.com \
--cc=michael@walle.cc \
--cc=mika.westerberg@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).