From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Michael Walle <michael@walle.cc>, <linux-mtd@lists.infradead.org>,
Mark Brown <broonie@kernel.org>, <linux-spi@vger.kernel.org>,
Julien Su <juliensu@mxic.com.tw>,
Jaime Liao <jaimeliao@mxic.com.tw>,
Boris Brezillon <boris.brezillon@collabora.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Xiangsheng Hou <xiangsheng.hou@mediatek.com>
Subject: Re: [PATCH v8 01/14] spi: spi-mem: reject partial cycle transfers in
Date: Wed, 22 Dec 2021 09:12:23 +0100 [thread overview]
Message-ID: <20211222091223.5bf11221@xps13> (raw)
In-Reply-To: <20211221184148.pw4blwxdvxcoerjo@ti.com>
Hi Pratyush,
p.yadav@ti.com wrote on Wed, 22 Dec 2021 00:11:50 +0530:
> Hi,
>
> On 21/12/21 06:48PM, Miquel Raynal wrote:
> > From: Pratyush Yadav <p.yadav@ti.com>
> >
> > In 8D-8D-8D mode two bytes are transferred per cycle. So an odd number
> > of bytes cannot be transferred because it would leave a residual half
> > cycle at the end. Consider such a transfer invalid and reject it.
> >
> > Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> > Reviewed-by: Mark Brown <broonie@kernel.org>
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> Sorry, I didn't realize this before. This patch would break a couple of
> SPI NOR flashes. You need patch 1, 2, and 3 from my series as well to
> make sure this does not happen. Since those patches have some pending
> comments, can you just drop this patch and I will re-roll it on top of
> your series later when I can find some time for it? Again, sorry for not
> noticing this before.
Yes no problem, I might as well drop it when applying.
Thanks,
Miquèl
next prev parent reply other threads:[~2021-12-22 8:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 17:48 [PATCH v8 00/14] External ECC engines & Macronix support Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 01/14] spi: spi-mem: reject partial cycle transfers in Miquel Raynal
2021-12-21 18:41 ` Pratyush Yadav
2021-12-22 8:12 ` Miquel Raynal [this message]
2021-12-22 8:31 ` Pratyush Yadav
2021-12-22 8:33 ` Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 02/14] spi: spi-mem: Introduce a capability structure Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 03/14] spi: spi-mem: Check the controller extra capabilities Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 04/14] spi: cadence-quadspi: Provide a capability structure Miquel Raynal
2021-12-21 18:42 ` Pratyush Yadav
2021-12-21 17:48 ` [PATCH v8 05/14] spi: mxic: " Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 06/14] spi: spi-mem: Kill the spi_mem_dtr_supports_op() helper Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 07/14] spi: spi-mem: Add an ecc parameter to the spi_mem_op structure Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 08/14] mtd: spinand: Delay a little bit the dirmap creation Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 09/14] mtd: spinand: Create direct mapping descriptors for ECC operations Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 10/14] spi: mxic: Fix the transmit path Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 11/14] spi: mxic: Create a helper to configure the controller before an operation Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 12/14] spi: mxic: Create a helper to ease the start of " Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 13/14] spi: mxic: Add support for direct mapping Miquel Raynal
2021-12-21 17:48 ` [PATCH v8 14/14] spi: mxic: Add support for pipelined ECC operations Miquel Raynal
2021-12-30 15:54 ` [PATCH v8 00/14] External ECC engines & Macronix support Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222091223.5bf11221@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=boris.brezillon@collabora.com \
--cc=broonie@kernel.org \
--cc=jaimeliao@mxic.com.tw \
--cc=juliensu@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael@walle.cc \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
--cc=xiangsheng.hou@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).