From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jarkko Sakkinen <jarkko@kernel.org>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Gwendal Grignou" <gwendal@chromium.org>,
"Yasunari Takiguchi" <Yasunari.Takiguchi@sony.com>,
"Claudius Heine" <ch@denx.de>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Nanyong Sun" <sunnanyong@huawei.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
dri-devel@lists.freedesktop.org,
"Jaroslav Kysela" <perex@perex.cz>,
"Frieder Schrempf" <frieder.schrempf@kontron.de>,
"Pavel Machek" <pavel@ucw.cz>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Christian Lamparter" <chunkeey@googlemail.com>,
"Ajay Singh" <ajay.kathat@microchip.com>,
linux-clk@vger.kernel.org,
"Stefan Schmidt" <stefan@datenfreihafen.org>,
"Sidong Yang" <realwakka@gmail.com>,
libertas-dev@lists.infradead.org, linux-omap@vger.kernel.org,
"Antti Palosaari" <crope@iki.fi>,
"Jean Delvare" <jdelvare@suse.com>,
linux-serial@vger.kernel.org,
"Łukasz Stelmach" <l.stelmach@samsung.com>,
"Mark Tomlinson" <mark.tomlinson@alliedtelesis.co.nz>,
"James Schulman" <james.schulman@cirrus.com>,
"Kamlesh Gurudasani" <kamlesh.gurudasani@gmail.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Zhang Qilong" <zhangqilong3@huawei.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
"Michael Walle" <michael@walle.cc>,
"Noralf Trønnes" <noralf@tronnes.org>,
kernel@pengutronix.de, linux-mtd@lists.infradead.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Vladimir Oltean" <olteanv@gmail.com>,
linux-wpan@vger.kernel.org,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Dan Robertson" <dan@dlrobertson.com>,
"Markuss Broks" <markuss.broks@gmail.com>,
"Lucas Tanure" <tanureal@opensource.cirrus.com>,
"David Airlie" <airlied@linux.ie>,
linux-wireless@vger.kernel.org,
"David Rhodes" <david.rhodes@cirrus.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Solomon Peachy" <pizza@shaftnet.org>,
"Marek Behún" <kabel@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Emmanuel Gil Peyrot" <linkmauve@linkmauve.fr>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Tudor Ambarus" <tudor.ambarus@microchip.com>,
"Minghao Chi" <chi.minghao@zte.com.cn>,
"Jon Hunter" <jonathanh@nvidia.com>,
dingsenjie <dingsenjie@yulong.com>, "Heiko Schocher" <hs@denx.de>,
"Wolfgang Grandegger" <wg@grandegger.com>,
"Matt Kline" <matt@bitbashing.io>,
"Woojung Huh" <woojung.huh@microchip.com>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"Ronald Tschalär" <ronald@innovation.ch>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Maxime Ripard" <mripard@kernel.org>,
linux-can@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Davidlohr Bueso" <dbueso@suse.de>,
UNGLinuxDriver@microchip.com, linux-usb@vger.kernel.org,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
linux-integrity@vger.kernel.org,
"Jonathan Cameron" <jic23@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
linux-staging@lists.linux.dev, linux-iio@vger.kernel.org,
"Michael Turquette" <mturquette@baylibre.com>,
alsa-devel@alsa-project.org, "Nuno Sá" <nuno.sa@analog.com>,
netdev@vger.kernel.org, "Wei Yongjun" <weiyongjun1@huawei.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Jérôme Pouiller" <jerome.pouiller@silabs.com>,
linux-rtc@vger.kernel.org,
"Marcus Folkesson" <marcus.folkesson@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Aditya Srivastava" <yashsri421@gmail.com>,
"Varka Bhadram" <varkabhadram@gmail.com>,
wengjianfeng <wengjianfeng@yulong.com>,
linux-input@vger.kernel.org, linux-media@vger.kernel.org,
"Arnd Bergmann" <arnd@arndb.de>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Mark Greer" <mgreer@animalcreek.com>,
"Mark Gross" <markgross@kernel.org>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
linux-fbdev@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Stefan Mätje" <stefan.maetje@esd.eu>,
linux-hwmon@vger.kernel.org, "Felipe Balbi" <balbi@kernel.org>,
"Paulo Miguel Almeida" <paulo.miguel.almeida.rodenas@gmail.com>,
"Support Opensource" <support.opensource@diasemi.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-mmc@vger.kernel.org, "Liam Girdwood" <lgirdwood@gmail.com>,
"Julia Lawall" <Julia.Lawall@inria.fr>,
"Yang Li" <yang.lee@linux.alibaba.com>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
patches@opensource.cirrus.com,
"Kent Gustavsson" <kent@minoris.se>,
"David S. Miller" <davem@davemloft.net>,
"Alexander Aring" <alex.aring@gmail.com>,
"Jiri Prchal" <jiri.prchal@aksignal.cz>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Emma Anholt" <emma@anholt.net>,
"Peter Zijlstra" <peterz@infradead.org>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Alexandru Ardelean" <ardeleanalex@gmail.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Torin Cooper-Bennun" <torin@maxiluxsystems.com>,
"Lee Jones" <lee.jones@linaro.org>,
linux-leds@vger.kernel.org,
"Eric Piel" <eric.piel@tremplin-utc.net>,
"Stephan Gerhold" <stephan@gerhold.net>,
"Richard Weinberger" <richard@nod.at>,
"Russell King" <linux@armlinux.org.uk>,
"Thomas Kopp" <thomas.kopp@microchip.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
platform-driver-x86@vger.kernel.org,
"Stefan Wahren" <stefan.wahren@i2se.com>,
"Xue Liu" <liuxuenetmail@gmail.com>,
"David Lechner" <david@lechnology.com>,
"Will Deacon" <will@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Kalle Valo" <kvalo@kernel.org>,
"Rui Miguel Silva" <rmfrfs@gmail.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Vincent Mailhol" <mailhol.vincent@wanadoo.fr>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Yang Shen" <shenyang39@huawei.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Takashi Iwai" <tiwai@suse.com>,
"Cai Huoqing" <caihuoqing@baidu.com>,
"Daniel Mack" <daniel@zonque.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Colin Ian King" <colin.king@intel.com>,
"Helge Deller" <deller@gmx.de>, "Alan Ott" <alan@signal11.us>
Subject: Re: [PATCH 5/5] spi: make remove callback a void function
Date: Tue, 25 Jan 2022 11:29:03 +0100 [thread overview]
Message-ID: <20220125102903.werurj56umtglcue@pengutronix.de> (raw)
In-Reply-To: <20220125094759.000019c5@Huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1914 bytes --]
[Dropped a few people from Cc that are not reachable (Harry Morris,
Charles-Antoine Couret, Marco Felsch)]
On Tue, Jan 25, 2022 at 09:47:59AM +0000, Jonathan Cameron wrote:
> On Sun, 23 Jan 2022 18:52:01 +0100
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>
> > The value returned by an spi driver's remove function is mostly ignored.
> > (Only an error message is printed if the value is non-zero that the
> > error is ignored.)
> >
> > So change the prototype of the remove function to return no value. This
> > way driver authors are not tempted to assume that passing an error to
> > the upper layer is a good idea. All drivers are adapted accordingly.
> > There is no intended change of behaviour, all callbacks were prepared to
> > return 0 before.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> For iio drivers.
>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> As you mention in the cover letter we'll be wanting an immutable
> branch somewhere to pull into subsystem trees.
>
> Soon is good if possible as otherwise we'll end up with a bunch of merge
> conflicts getting resolved in next.
Yes, I considered creating a tag to pull already when sending out this
series, but I guessed delaying that a little bit to give people the
opportunity to ack would be a good idea.
@broonie: Do you think this change is a good idea? Would you require
some more acks for the preparatory patches? I had hoped to get Acks from
the corresponding maintainers, maybe they are busy and missed this
series as I put them on Cc: only. I promoted them to To: in this mail.
Or is it too ambitious to get this in during the next merge window?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-25 10:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 17:51 [PATCH 0/5] spi: make remove callback a void function Uwe Kleine-König
2022-01-23 17:51 ` [PATCH 1/5] staging: fbtft: Fix error path in fbtft_driver_module_init() Uwe Kleine-König
2022-01-23 17:51 ` [PATCH 2/5] staging: fbtft: Deduplicate driver registration macros Uwe Kleine-König
2022-01-27 21:36 ` Uwe Kleine-König
2022-01-28 7:16 ` Greg Kroah-Hartman
2022-01-23 17:51 ` [PATCH 3/5] tpm: st33zp24: Make st33zp24_remove() a void function Uwe Kleine-König
2022-01-23 17:52 ` [PATCH 4/5] platform/chrome: cros_ec: Make cros_ec_unregister() return void Uwe Kleine-König
2022-01-23 17:52 ` [PATCH 5/5] spi: make remove callback a void function Uwe Kleine-König
2022-01-23 22:49 ` Marc Kleine-Budde
2022-01-24 12:23 ` Andy Shevchenko
2022-01-25 9:35 ` Alexandre Belloni
2022-01-25 9:44 ` Stefan Schmidt
2022-01-25 9:47 ` Jonathan Cameron
2022-01-25 10:29 ` Uwe Kleine-König [this message]
2022-01-25 10:19 ` Miquel Raynal
2022-01-25 10:25 ` Claudius Heine
2022-01-25 10:37 ` Geert Uytterhoeven
[not found] ` <CGME20220125124340eucas1p2504c36206c5c17f63663a814fc8f7feb@eucas1p2.samsung.com>
2022-01-25 12:43 ` Lukasz Stelmach
2022-01-27 11:39 ` Ulf Hansson
2022-02-08 13:39 ` Mark Brown
2022-02-18 12:37 ` Hans Verkuil
2022-03-02 7:30 ` Pavel Machek
2022-01-25 9:30 ` [PATCH 0/5] " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125102903.werurj56umtglcue@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Jonathan.Cameron@Huawei.com \
--cc=Julia.Lawall@inria.fr \
--cc=Michael.Hennerich@analog.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Yasunari.Takiguchi@sony.com \
--cc=a.zummo@towertech.it \
--cc=airlied@linux.ie \
--cc=ajay.kathat@microchip.com \
--cc=akpm@linux-foundation.org \
--cc=alan@signal11.us \
--cc=alex.aring@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=antoniu.miclaus@analog.com \
--cc=ardeleanalex@gmail.com \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=bleung@chromium.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=caihuoqing@baidu.com \
--cc=ch@denx.de \
--cc=chi.minghao@zte.com.cn \
--cc=chunkeey@googlemail.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=claudiu.beznea@microchip.com \
--cc=colin.king@intel.com \
--cc=crope@iki.fi \
--cc=dan.carpenter@oracle.com \
--cc=dan@dlrobertson.com \
--cc=daniel.thompson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=david.rhodes@cirrus.com \
--cc=david@lechnology.com \
--cc=dbueso@suse.de \
--cc=deller@gmx.de \
--cc=dingsenjie@yulong.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=eric.piel@tremplin-utc.net \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=gwendal@chromium.org \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=hs@denx.de \
--cc=j.neuschaefer@gmx.net \
--cc=james.schulman@cirrus.com \
--cc=jarkko@kernel.org \
--cc=jdelvare@suse.com \
--cc=jerome.pouiller@silabs.com \
--cc=jgg@ziepe.ca \
--cc=jic23@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=jiri.prchal@aksignal.cz \
--cc=jirislaby@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kabel@kernel.org \
--cc=kamlesh.gurudasani@gmail.com \
--cc=kent@minoris.se \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linkmauve@linkmauve.fr \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=liuxuenetmail@gmail.com \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mani@kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=mark.tomlinson@alliedtelesis.co.nz \
--cc=markgross@kernel.org \
--cc=markuss.broks@gmail.com \
--cc=matt@bitbashing.io \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mgreer@animalcreek.com \
--cc=michael@walle.cc \
--cc=mike.looijmans@topic.nl \
--cc=miquel.raynal@bootlin.com \
--cc=mkl@pengutronix.de \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=nuno.sa@analog.com \
--cc=olteanv@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=paulo.miguel.almeida.rodenas@gmail.com \
--cc=pavel@ucw.cz \
--cc=perex@perex.cz \
--cc=peterhuewe@gmx.de \
--cc=peterz@infradead.org \
--cc=pizza@shaftnet.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=realwakka@gmail.com \
--cc=rf@opensource.cirrus.com \
--cc=richard@nod.at \
--cc=rmfrfs@gmail.com \
--cc=ronald@innovation.ch \
--cc=sam@ravnborg.org \
--cc=sboyd@kernel.org \
--cc=shenyang39@huawei.com \
--cc=stefan.maetje@esd.eu \
--cc=stefan.wahren@i2se.com \
--cc=stefan@datenfreihafen.org \
--cc=stephan@gerhold.net \
--cc=sunnanyong@huawei.com \
--cc=support.opensource@diasemi.com \
--cc=tanureal@opensource.cirrus.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.kopp@microchip.com \
--cc=tiwai@suse.com \
--cc=torin@maxiluxsystems.com \
--cc=tudor.ambarus@microchip.com \
--cc=tzimmermann@suse.de \
--cc=ulf.hansson@linaro.org \
--cc=varkabhadram@gmail.com \
--cc=vigneshr@ti.com \
--cc=vivien.didelot@gmail.com \
--cc=weiyongjun1@huawei.com \
--cc=wengjianfeng@yulong.com \
--cc=wg@grandegger.com \
--cc=will@kernel.org \
--cc=woojung.huh@microchip.com \
--cc=yang.lee@linux.alibaba.com \
--cc=yashsri421@gmail.com \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).