From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"David Airlie" <airlied@linux.ie>,
"Alexandru Ardelean" <aardelean@deviqon.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Tomislav Denis" <tomislav.denis@avl.com>,
"André Gustavo Nakagomi Lopez" <andregnl@usp.br>,
"Nuno Sá" <nuno.sa@analog.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-i2c@vger.kernel.org,
"Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>,
"Oleksij Rempel" <linux@rempel-privat.de>,
"Lee Jones" <lee.jones@linaro.org>,
linux-clk@vger.kernel.org, "Jerome Brunet" <jbrunet@baylibre.com>,
linux-rtc@vger.kernel.org, "Lars-Peter Clausen" <lars@metafoo.de>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Russell King" <linux@armlinux.org.uk>,
linux-pwm@vger.kernel.org,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
linux-iio@vger.kernel.org, "Andy Gross" <agross@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
"Keguang Zhang" <keguang.zhang@gmail.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Michal Simek" <michal.simek@xilinx.com>,
kernel@pengutronix.de,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
"Anand Ashok Dumbre" <anand.ashok.dumbre@xilinx.com>,
"Vladimir Zapolskiy" <vz@mleia.com>,
linux-gpio@vger.kernel.org, "Mark Brown" <broonie@kernel.org>,
dri-devel@lists.freedesktop.org,
"Fabio Estevam" <festevam@gmail.com>,
"Matt Mackall" <mpm@selenic.com>,
linux-amlogic@lists.infradead.org,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Lars Povlsen" <lars.povlsen@microchip.com>,
linux-hwmon@vger.kernel.org,
"Alessandro Zummo" <a.zummo@towertech.it>,
linux-watchdog@vger.kernel.org, "Stephen Boyd" <sboyd@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
linux-stm32@st-md-mailman.stormreply.com,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
UNGLinuxDriver@microchip.com, "Vinod Koul" <vkoul@kernel.org>,
"Cai Huoqing" <caihuoqing@baidu.com>,
linux-crypto@vger.kernel.org, "Daniel Vetter" <daniel@ffwll.ch>,
dmaengine@vger.kernel.org,
"Amireddy Mallikarjuna reddy"
<mallikarjunax.reddy@linux.intel.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Steen Hegelund" <Steen.Hegelund@microchip.com>
Subject: Re: [PATCH v8 02/16] clk: Provide new devm_clk helpers for prepared and enabled clocks
Date: Mon, 21 Mar 2022 08:22:15 +0100 [thread overview]
Message-ID: <20220321072215.5lffm7qtpvg5ofk4@pengutronix.de> (raw)
In-Reply-To: <20220319182936.06d75742@jic23-huawei>
[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]
On Sat, Mar 19, 2022 at 06:29:36PM +0000, Jonathan Cameron wrote:
> On Mon, 14 Mar 2022 15:16:29 +0100
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>
> > When a driver keeps a clock prepared (or enabled) during the whole
> > lifetime of the driver, these helpers allow to simplify the drivers.
> >
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Reviewed-by: Alexandru Ardelean <aardelean@deviqon.com>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> One trivial thing below.
>
> > ---
> > drivers/clk/clk-devres.c | 31 ++++++++++++++
> > include/linux/clk.h | 90 +++++++++++++++++++++++++++++++++++++++-
> > 2 files changed, 120 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c
> > index fb7761888b30..4707fe718f0b 100644
> > --- a/drivers/clk/clk-devres.c
> > +++ b/drivers/clk/clk-devres.c
> > @@ -67,12 +67,43 @@ struct clk *devm_clk_get(struct device *dev, const char *id)
> > }
> > EXPORT_SYMBOL(devm_clk_get);
> >
> > +struct clk *devm_clk_get_prepared(struct device *dev, const char *id)
> > +{
> > + return __devm_clk_get(dev, id, clk_get, clk_prepare, clk_unprepare);
>
> Nitpick but this spacing before } in functions is rather unusual and not
> in keeping with the existing code in this file.
>
> > +
> > +}
ack, I fixed that in my tree, so this will be part of an v9. I won't
send it just for this change, though. I fixed three further functions
that had a similar empty line, too.
Thanks for looking
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-21 7:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 14:16 [PATCH v8 00/16] clk: provide new devm helpers for prepared and enabled clocks Uwe Kleine-König
2022-03-14 14:16 ` [PATCH v8 01/16] clk: generalize devm_clk_get() a bit Uwe Kleine-König
2022-06-21 19:57 ` Jon Hunter
2022-06-21 20:49 ` Uwe Kleine-König
2022-06-22 10:36 ` Andy Shevchenko
2022-06-22 11:14 ` Neil Armstrong
2022-06-22 15:28 ` Jon Hunter
2022-03-14 14:16 ` [PATCH v8 02/16] clk: Provide new devm_clk helpers for prepared and enabled clocks Uwe Kleine-König
2022-03-19 18:29 ` Jonathan Cameron
2022-03-21 7:22 ` Uwe Kleine-König [this message]
2022-03-14 14:16 ` [PATCH v8 15/16] spi: davinci: Simplify using devm_clk_get_enabled() Uwe Kleine-König
2022-03-15 18:03 ` [PATCH v8 00/16] clk: provide new devm helpers for prepared and enabled clocks Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321072215.5lffm7qtpvg5ofk4@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=a.zummo@towertech.it \
--cc=aardelean@deviqon.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=anand.ashok.dumbre@xilinx.com \
--cc=andregnl@usp.br \
--cc=bjorn.andersson@linaro.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=caihuoqing@baidu.com \
--cc=claudiu.beznea@microchip.com \
--cc=daniel@ffwll.ch \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=jbrunet@baylibre.com \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=keguang.zhang@gmail.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=lars.povlsen@microchip.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=linux@roeck-us.net \
--cc=mallikarjunax.reddy@linux.intel.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=mpm@selenic.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=nuno.sa@analog.com \
--cc=patrice.chotard@foss.st.com \
--cc=paul@crapouillou.net \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tomislav.denis@avl.com \
--cc=vkoul@kernel.org \
--cc=vz@mleia.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).