From: Pratyush Yadav <p.yadav@ti.com>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: <linux-spi@vger.kernel.org>, Mark Brown <broonie@kernel.org>,
Dinh Nguyen <dinguyen@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: cadence-quadspi: fix Direct Access Mode disable for SoCFPGA
Date: Fri, 29 Apr 2022 11:28:33 +0530 [thread overview]
Message-ID: <20220429055833.ahgioqdjwgshpylk@ti.com> (raw)
In-Reply-To: <20220427153446.10113-1-abbotti@mev.co.uk>
On 27/04/22 04:34PM, Ian Abbott wrote:
> The Cadence QSPI compatible string required for the SoCFPGA platform
> changed from the default "cdns,qspi-nor" to "intel,socfpga-qspi" with
> the introduction of an additional quirk in
> commit 98d948eb8331 ("spi: cadence-quadspi: fix write completion support").
> However, that change did not preserve the previously used
> quirk for this platform. Reinstate the `CQSPI_DISABLE_DAC_MODE` quirk
> for the SoCFPGA platform.
>
> Fixes: 98d948eb8331 ("spi: cadence-quadspi: fix write completion support")
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
> ---
> drivers/spi/spi-cadence-quadspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
> index 41922a5ea1f4..30307392c75a 100644
> --- a/drivers/spi/spi-cadence-quadspi.c
> +++ b/drivers/spi/spi-cadence-quadspi.c
> @@ -1781,7 +1781,7 @@ static const struct cqspi_driver_platdata intel_lgm_qspi = {
> };
>
> static const struct cqspi_driver_platdata socfpga_qspi = {
> - .quirks = CQSPI_NO_SUPPORT_WR_COMPLETION,
> + .quirks = CQSPI_DISABLE_DAC_MODE | CQSPI_NO_SUPPORT_WR_COMPLETION,
> };
>
> static const struct cqspi_driver_platdata versal_ospi = {
> --
> 2.35.1
>
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2022-04-29 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 15:34 [PATCH] spi: cadence-quadspi: fix Direct Access Mode disable for SoCFPGA Ian Abbott
2022-04-29 5:58 ` Pratyush Yadav [this message]
2022-05-03 15:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429055833.ahgioqdjwgshpylk@ti.com \
--to=p.yadav@ti.com \
--cc=abbotti@mev.co.uk \
--cc=broonie@kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).