linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>,
	Kamal Dasu <kdasu.kdev@gmail.com>,
	Broadcom internal kernel review list 
	<bcm-kernel-feedback-list@broadcom.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Heiko Stuebner <heiko@sntech.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andi Shyti <andi@etezian.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: [PATCH 16/16] spi: rspi: Mark OF related data as maybe unused
Date: Fri, 10 Mar 2023 23:28:57 +0100	[thread overview]
Message-ID: <20230310222857.315629-16-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230310222857.315629-1-krzysztof.kozlowski@linaro.org>

Driver can match via ID or OF ID table, thus several OF-related methods
will be unused.  Mark the OF structures as __maybe_unused so compiler
can drop them:

  drivers/spi/spi-rspi.c:1203:29: error: ‘qspi_ops’ defined but not used [-Werror=unused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/spi/spi-rspi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c
index f494c86bafea..4724854e6726 100644
--- a/drivers/spi/spi-rspi.c
+++ b/drivers/spi/spi-rspi.c
@@ -1190,7 +1190,7 @@ static const struct spi_ops rspi_ops = {
 	.num_hw_ss =		2,
 };
 
-static const struct spi_ops rspi_rz_ops = {
+static const struct spi_ops rspi_rz_ops __maybe_unused = {
 	.set_config_register =	rspi_rz_set_config_register,
 	.transfer_one =		rspi_rz_transfer_one,
 	.min_div =		2,
@@ -1200,7 +1200,7 @@ static const struct spi_ops rspi_rz_ops = {
 	.num_hw_ss =		1,
 };
 
-static const struct spi_ops qspi_ops = {
+static const struct spi_ops qspi_ops __maybe_unused = {
 	.set_config_register =	qspi_set_config_register,
 	.transfer_one =		qspi_transfer_one,
 	.extra_mode_bits =	SPI_TX_DUAL | SPI_TX_QUAD |
@@ -1212,8 +1212,7 @@ static const struct spi_ops qspi_ops = {
 	.num_hw_ss =		1,
 };
 
-#ifdef CONFIG_OF
-static const struct of_device_id rspi_of_match[] = {
+static const struct of_device_id rspi_of_match[] __maybe_unused = {
 	/* RSPI on legacy SH */
 	{ .compatible = "renesas,rspi", .data = &rspi_ops },
 	/* RSPI on RZ/A1H */
@@ -1225,6 +1224,7 @@ static const struct of_device_id rspi_of_match[] = {
 
 MODULE_DEVICE_TABLE(of, rspi_of_match);
 
+#ifdef CONFIG_OF
 static void rspi_reset_control_assert(void *data)
 {
 	reset_control_assert(data);
-- 
2.34.1


  parent reply	other threads:[~2023-03-10 22:30 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 22:28 [PATCH 01/16] spi: armada-3700: Drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-10 22:28 ` [PATCH 02/16] spi: mtk-pmif: " Krzysztof Kozlowski
2023-03-13  8:46   ` AngeloGioacchino Del Regno
2023-03-29  4:15   ` Stephen Boyd
2023-03-29  4:17   ` Stephen Boyd
2023-03-29  7:13     ` Krzysztof Kozlowski
2023-03-10 22:28 ` [PATCH 03/16] spi: meson-spicc: " Krzysztof Kozlowski
2023-03-11 21:02   ` Martin Blumenstingl
2023-03-10 22:28 ` [PATCH 04/16] spi: meson-spifc: " Krzysztof Kozlowski
2023-03-11 21:03   ` Martin Blumenstingl
2023-03-10 22:28 ` [PATCH 05/16] spi: orion: " Krzysztof Kozlowski
2023-03-10 22:28 ` [PATCH 06/16] spi: rockchip: " Krzysztof Kozlowski
2023-03-11 12:56   ` Heiko Stuebner
2023-03-10 22:28 ` [PATCH 07/16] spi: s3c64xx: " Krzysztof Kozlowski
2023-03-11 11:45   ` Andi Shyti
2023-03-10 22:28 ` [PATCH 08/16] spi: img-spfi: " Krzysztof Kozlowski
2023-03-10 22:28 ` [PATCH 09/16] spi: pic32-sqi: " Krzysztof Kozlowski
2023-03-10 22:28 ` [PATCH 10/16] spi: pic32: " Krzysztof Kozlowski
2023-03-10 22:28 ` [PATCH 11/16] spi: st-ssc4: " Krzysztof Kozlowski
2023-03-10 22:28 ` [PATCH 12/16] spi: pxa2xx: Mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-10 22:28 ` [PATCH 13/16] spi: bcm-qspi: " Krzysztof Kozlowski
2023-03-10 22:36   ` Florian Fainelli
2023-03-10 22:28 ` [PATCH 14/16] spi: sh-msiof: " Krzysztof Kozlowski
2023-03-10 22:28 ` [PATCH 15/16] spi: sc18is602: " Krzysztof Kozlowski
2023-03-10 22:28 ` Krzysztof Kozlowski [this message]
2023-03-13 13:55 ` [PATCH 01/16] spi: armada-3700: Drop of_match_ptr for ID table Mark Brown
2023-03-13 18:39   ` Krzysztof Kozlowski
2023-03-13 19:22     ` Mark Brown
2023-03-14  6:44       ` Krzysztof Kozlowski
2023-03-14 13:26         ` Mark Brown
2023-03-13 18:20 ` (subset) " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310222857.315629-16-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andi@etezian.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=broonie@kernel.org \
    --cc=daniel@zonque.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=heiko@sntech.de \
    --cc=jbrunet@baylibre.com \
    --cc=kdasu.kdev@gmail.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robert.jarzmik@free.fr \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).