linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vignesh Raghavendra <vigneshr@ti.com>
To: "Ramuthevar,
	Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	"Mark Brown" <broonie@kernel.org>,
	simon.k.r.goldschmidt@gmail.com,
	"Dinh Nguyen" <dinguyen@kernel.org>,
	tien.fong.chee@intel.com, "Marek Vašut" <marex@denx.de>,
	cheol.yong.kim@intel.com, qi-ming.wu@intel.com
Subject: Re: [PATCH v10 1/2] dt-bindings: spi: Add schema for Cadence QSPI Controller driver
Date: Thu, 27 Feb 2020 10:53:58 +0530	[thread overview]
Message-ID: <22bb0c6c-db03-dee5-eccf-84b00216308f@ti.com> (raw)
In-Reply-To: <98c90f35-297b-a13c-61ad-ce7a7f1d650f@linux.intel.com>



On 26/02/20 7:02 am, Ramuthevar, Vadivel MuruganX wrote:
> Hi,
> 
> On 25/2/2020 7:00 PM, Vignesh Raghavendra wrote:
>>
>> On 25/02/20 1:08 pm, Ramuthevar, Vadivel MuruganX wrote:
>>>>>>> +
>>>>>>> +  cdns,fifo-depth:
>>>>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>>>>> +    description:
>>>>>>> +      Size of the data FIFO in words.
>>>>>> A 4GB fifo is valid? Add some constraints.
>>>>> 128 is valid, will update.
>>>> Nope, the width of this field is 8bits -> 256 bytes
>>> correct me if I am wrong, the width of this field is 4bits -> 128 bytes
>>> (based on QUAD mode) .
>> This has nothing to do with quad-mode. Its about how much SRAM amount of
>> SRAM is present to buffer INDAC mode data. For TI platforms this is 256
>> bytes.
>> See CQSPI_REG_SRAMPARTITION definition in your datasheet.
> Agreed, Thanks!
> Yes , I have gone through it , Intel and Altera SoC's SRAM(act as
> FIFO)size is 128 bytes and TI has 256 .
> BTW old legacy DT binding mentioned size is 128, as per your earlier
> suggestion you have mention that
> keep the contents from old dt bindings as it is, so shall I keep 128/256?

Old bindings does not impose a restriction that this needs to be 128
bytes always (Its just the example that shows this property to be set to
128)

What Rob is asking for is to add range of values that is valid for this
field and not single value. So, both 128 and 256 bytes should be allowed
as valid values for this property.


-- 
Regards
Vignesh

  reply	other threads:[~2020-02-27  5:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19  2:28 [PATCH v10 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
     [not found] ` <20200219022852.28065-1-vadivel.muruganx.ramuthevar-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2020-02-19  2:28   ` [PATCH v10 1/2] dt-bindings: spi: Add schema for Cadence QSPI Controller driver Ramuthevar,Vadivel MuruganX
     [not found]     ` <20200219022852.28065-2-vadivel.muruganx.ramuthevar-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2020-02-24 15:54       ` Rob Herring
     [not found]         ` <CAL_JsqKJky=y4nhECUFVzTYvEpjFoOH_6UY9uZG5bvBVWq=SYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-25  6:24           ` Ramuthevar, Vadivel MuruganX
     [not found]             ` <64b7ab12-0c11-df25-95e7-ee62227ec7ec-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2020-02-25  6:41               ` Vignesh Raghavendra
     [not found]                 ` <85178128-4906-8b1a-e3f1-ab7a36ff8c23-l0cyMroinI0@public.gmane.org>
2020-02-25  7:38                   ` Ramuthevar, Vadivel MuruganX
     [not found]                     ` <c119a70d-b7ef-ab1b-4590-7ac77395297f-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2020-02-25 11:00                       ` Vignesh Raghavendra
     [not found]                         ` <8c329860-84fd-463b-782f-83a788998878-l0cyMroinI0@public.gmane.org>
2020-02-26  1:32                           ` Ramuthevar, Vadivel MuruganX
2020-02-27  5:23                             ` Vignesh Raghavendra [this message]
     [not found]                               ` <22bb0c6c-db03-dee5-eccf-84b00216308f-l0cyMroinI0@public.gmane.org>
2020-02-27  5:59                                 ` Ramuthevar, Vadivel MuruganX
2020-02-19  2:28   ` [PATCH v10 2/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
2020-02-19  8:28   ` [PATCH v10 0/2] " Marek Vasut
2020-02-25  4:23   ` Vignesh Raghavendra
     [not found]     ` <99f7e23f-268d-f32b-086f-4a46fc232ce9-l0cyMroinI0@public.gmane.org>
2020-02-25  6:33       ` Ramuthevar, Vadivel MuruganX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22bb0c6c-db03-dee5-eccf-84b00216308f@ti.com \
    --to=vigneshr@ti.com \
    --cc=broonie@kernel.org \
    --cc=cheol.yong.kim@intel.com \
    --cc=dinguyen@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=qi-ming.wu@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=simon.k.r.goldschmidt@gmail.com \
    --cc=tien.fong.chee@intel.com \
    --cc=vadivel.muruganx.ramuthevar@linux.intel.com \
    --subject='Re: [PATCH v10 1/2] dt-bindings: spi: Add schema for Cadence QSPI Controller driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).