From: <Tudor.Ambarus@microchip.com>
To: <bbrezillon@kernel.org>
Cc: <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
<alexandre.belloni@bootlin.com>, <linux-kernel@vger.kernel.org>,
<Cyrille.Pitchen@microchip.com>, <Nicolas.Ferre@microchip.com>,
<robh+dt@kernel.org>, <linux-spi@vger.kernel.org>,
<Ludovic.Desroches@microchip.com>, <broonie@kernel.org>,
<linux-mtd@lists.infradead.org>, <bugalski.piotr@gmail.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 10/13] dt-bindings: spi: atmel-quadspi: make "pclk" mandatory
Date: Sat, 2 Feb 2019 08:47:00 +0000 [thread overview]
Message-ID: <25ed6e19-4fe6-7b8c-4eeb-5bd5be1075fe@microchip.com> (raw)
In-Reply-To: <20190202081502.47ca404d@bbrezillon>
On 02/02/2019 09:15 AM, Boris Brezillon wrote:
> On Sat, 2 Feb 2019 04:07:39 +0000
> <Tudor.Ambarus@microchip.com> wrote:
>
>> From: Tudor Ambarus <tudor.ambarus@microchip.com>
>>
>> Naming clocks is a good practice. Make "pclk" madatory even if
>> we support unnamed clock in the driver, to be backward compatible
>> with old DTs.
>>
>> Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> ---
>> v3: new patch
>>
>> Documentation/devicetree/bindings/spi/atmel-quadspi.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/atmel-quadspi.txt b/Documentation/devicetree/bindings/spi/atmel-quadspi.txt
>> index e9dae6264d89..1de54e87f5d6 100644
>> --- a/Documentation/devicetree/bindings/spi/atmel-quadspi.txt
>> +++ b/Documentation/devicetree/bindings/spi/atmel-quadspi.txt
>> @@ -9,6 +9,7 @@ Required properties:
>> - qspi_mmap: memory mapped address space
>> - interrupts: Should contain the interrupt for the device.
>> - clocks: The phandle of the clock needed by the QSPI controller.
>> +- clock-names: Should contain "pclk" for the peripheral clock.
>> - #address-cells: Should be <1>.
>> - #size-cells: Should be <0>.
>>
>> @@ -20,6 +21,7 @@ spi@f0020000 {
>> reg-names = "qspi_base", "qspi_mmap";
>> interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>;
>> clocks = <&pmc PMC_TYPE_PERIPHERAL 52>;
>> + clock-names = "pclk"
>
> Missing semicolon. Once fixed you can add
>
> Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>
will do, thanks!
>
>> #address-cells = <1>;
>> #size-cells = <0>;
>> pinctrl-names = "default";
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
next prev parent reply other threads:[~2019-02-02 8:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 4:07 [PATCH v3 00/13] spi: atmel-quadspi: introduce sam9x60 qspi controller Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 01/13] spi: atmel-quadspi: cache MR value to avoid a write access Tudor.Ambarus
2019-02-02 7:06 ` Boris Brezillon
2019-02-02 8:38 ` Tudor.Ambarus
2019-02-02 13:20 ` Boris Brezillon
2019-02-02 4:07 ` [PATCH v3 02/13] spi: atmel-quadspi: order header files inclusion alphabetically Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 03/13] spi: atmel-quadspi: drop wrappers for iomem accesses Tudor.Ambarus
2019-02-02 7:11 ` Boris Brezillon
2019-02-02 8:44 ` Tudor.Ambarus
2019-02-02 13:23 ` Boris Brezillon
2019-02-02 4:07 ` [PATCH v3 04/13] spi: atmel-quadspi: fix naming scheme Tudor.Ambarus
2019-02-02 7:12 ` Boris Brezillon
2019-02-02 4:07 ` [PATCH v3 05/13] spi: atmel-quadspi: remove unnecessary cast Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 06/13] spi: atmel-quadspi: return appropriate error code Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 07/13] spi: atmel-quadspi: switch to SPDX license identifiers Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 08/13] spi: atmel-quadspi: drop unused and NOP transfer macros Tudor.Ambarus
2019-02-02 7:13 ` Boris Brezillon
2019-02-02 8:46 ` Tudor.Ambarus
2019-02-02 13:27 ` Boris Brezillon
2019-02-02 4:07 ` [PATCH v3 09/13] dt-bindings: spi: atmel-quadspi: update example to new clock binding Tudor.Ambarus
2019-02-02 4:07 ` [PATCH v3 10/13] dt-bindings: spi: atmel-quadspi: make "pclk" mandatory Tudor.Ambarus
2019-02-02 7:15 ` Boris Brezillon
2019-02-02 8:47 ` Tudor.Ambarus [this message]
2019-02-02 4:07 ` [PATCH v3 11/13] spi: atmel-quadspi: add support for named peripheral clock Tudor.Ambarus
2019-02-02 7:16 ` Boris Brezillon
2019-02-02 4:07 ` [PATCH v3 12/13] dt-bindings: spi: atmel-quadspi: QuadSPI driver for Microchip SAM9X60 Tudor.Ambarus
2019-02-02 7:17 ` Boris Brezillon
2019-02-02 4:07 ` [PATCH v3 13/13] spi: atmel-quadspi: add support for sam9x60 qspi controller Tudor.Ambarus
2019-02-02 7:29 ` Boris Brezillon
2019-02-02 8:58 ` Tudor.Ambarus
2019-02-02 13:30 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25ed6e19-4fe6-7b8c-4eeb-5bd5be1075fe@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Cyrille.Pitchen@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=bugalski.piotr@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).