linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tomoya MORINAGA" <tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
To: "'Grant Likely'" <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: 'David Brownell'
	<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"'Wang, Qi'" <qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"'linux-kernel-u79uwXL29TaiAVqoAR/hOA49XUYAGyU/@public.gmane.org@intel.com'"@angua.secretlab.ca,
	yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	'Milton Miller' <miltonm-ogEGBHC/i9Y@public.gmane.org>,
	'Toshiharu Okada'
	<toshiharu-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>,
	kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: RE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213
Date: Mon, 24 Jan 2011 12:14:22 +0900	[thread overview]
Message-ID: <26379C01EA414D11A4FF5A504D1E0CBB@hacdom.okisemi.com> (raw)
In-Reply-To: <20110121184852.GA18603-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>

Hi Grant,

Thank you for your explanation.

On Saturday, January 22, 2011 3:49 AM, Grant Likely wrote:
> Am I correct so far?

No, not true.
Both Topcliff(Intel EG20 PCH) and OKISEMI ML7213 IOH SPI devices
can't use multi-ChipSelect but 1 ChipSelect only.

I show the my modified diagram below.

- Currently upstreamed version,
 /sys/devices/.../0000:00:1a.0 (pci_dev bound to driver 'pch_spi_pcidev')
   |
   \--spi0.0  (spi_device 0 on spi_master 0)

- I posted before version.
 /sys/devices/.../0000:00:1a.0 (pci_dev bound to driver 'pch_spi_pcidev')
   |
   +--spi0.0  (spi_device 0 on spi_master 0)
   |
   \--spi1.0  (spi_device 0 on spi_master 1)

- Your anticipated becomes like below
 /sys/devices/.../0000:00:1a.0 (pci_dev bound to driver 'pch_spi_pcidev')
   |
   +--pch_spi.0
   |   |
   |   +--spi0.0  (spi_device 0 on spi_master 0)
   |
   \--pch_spi.1
       |
       \--spi1.0  (spi_device 0 on spi_master 1)


Still above,  don't you change your opinion?

> Make sense?
I probably understand your saying.
You mean insert platform_device as wrapper between pci_driver and spi_topcliff_pch.

Thanks,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.


------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d

  parent reply	other threads:[~2011-01-24  3:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-27 11:23 [PATCH 1/3] spi_topcliff_pch: support new device ML7213 Tomoya MORINAGA
2010-12-27 11:23 ` [PATCH 2/3] spi_topcliff_pch: change calling function order correctly in remove Tomoya MORINAGA
2010-12-27 11:23   ` [PATCH 3/3] spi_topcliff_pch: fix resource leak issue Tomoya MORINAGA
2010-12-29  6:51     ` Grant Likely
2010-12-29  6:51   ` [PATCH 2/3] spi_topcliff_pch: change calling function order correctly in remove Grant Likely
2010-12-29  6:49 ` [PATCH 1/3] spi_topcliff_pch: support new device ML7213 Grant Likely
2011-01-05  2:34   ` Tomoya MORINAGA
2011-01-05 16:38     ` Grant Likely
2011-01-07  6:40       ` Tomoya MORINAGA
     [not found]         ` <46862922F48B45F781832619CF3F4B79-c0cKtqp5df7I9507bXv2FdBPR1lH4CV8@public.gmane.org>
2011-01-07  9:21           ` Milton Miller
     [not found]             ` <topcliff-split-kM9DGJe42AJBDgjK7y7TUQ@public.gmane.org>
2011-01-07  9:45               ` Tomoya MORINAGA
2011-01-11  9:38               ` Tomoya MORINAGA
     [not found]                 ` <84FF3503839A46E0B9919DF000DDE5C5-c0cKtqp5df7I9507bXv2FdBPR1lH4CV8@public.gmane.org>
2011-01-21 18:48                   ` Grant Likely
     [not found]                     ` <20110121184852.GA18603-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2011-01-24  3:14                       ` Tomoya MORINAGA [this message]
2011-01-11  9:42             ` Tomoya MORINAGA
2011-01-12  5:27               ` Tomoya MORINAGA
2011-01-18 12:36                 ` Tomoya MORINAGA
2011-01-19  6:25                   ` Grant Likely
2011-01-07  9:45           ` Milton Miller
2011-01-07  9:57         ` Milton Miller
2011-01-07  6:47       ` Tomoya MORINAGA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26379C01EA414D11A4FF5A504D1E0CBB@hacdom.okisemi.com \
    --to=tomoya-linux-ecg8zkttlr0c6lszws/t0g@public.gmane.org \
    --cc="'linux-kernel-u79uwXL29TaiAVqoAR/hOA49XUYAGyU/@public.gmane.org@intel.com'"@angua.secretlab.ca \
    --cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=miltonm-ogEGBHC/i9Y@public.gmane.org \
    --cc=qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=toshiharu-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org \
    --cc=yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).